From 56dc7243dd86bc175940ad0944386928878fcea2 Mon Sep 17 00:00:00 2001
From: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
Date: Thu, 30 Apr 2020 15:04:39 -0300
Subject: [PATCH] [FIX] Pending update (#2066)

Co-authored-by: Diego Mello <diegolmello@gmail.com>
---
 app/lib/methods/subscriptions/room.js | 63 +++++++++++----------------
 1 file changed, 26 insertions(+), 37 deletions(-)

diff --git a/app/lib/methods/subscriptions/room.js b/app/lib/methods/subscriptions/room.js
index f6df8b34..8dfb45d0 100644
--- a/app/lib/methods/subscriptions/room.js
+++ b/app/lib/methods/subscriptions/room.js
@@ -160,22 +160,17 @@ export default class RoomSubscription {
 			const msgCollection = db.collections.get('messages');
 			const threadsCollection = db.collections.get('threads');
 			const threadMessagesCollection = db.collections.get('thread_messages');
-			let messageRecord;
-			let threadRecord;
-			let threadMessageRecord;
 
 			// Create or update message
 			try {
-				messageRecord = await msgCollection.find(message._id);
-			} catch (error) {
-				// Do nothing
-			}
-			if (messageRecord) {
-				const update = messageRecord.prepareUpdate((m) => {
-					Object.assign(m, message);
-				});
-				this._messagesBatch[message._id] = update;
-			} else {
+				const messageRecord = await msgCollection.find(message._id);
+				if (!messageRecord._hasPendingUpdate) {
+					const update = messageRecord.prepareUpdate(protectedFunction((m) => {
+						Object.assign(m, message);
+					}));
+					this._messagesBatch[message._id] = update;
+				}
+			} catch {
 				const create = msgCollection.prepareCreate(protectedFunction((m) => {
 					m._raw = sanitizedRaw({ id: message._id }, msgCollection.schema);
 					m.subscription.id = this.rid;
@@ -187,17 +182,14 @@ export default class RoomSubscription {
 			// Create or update thread
 			if (message.tlm) {
 				try {
-					threadRecord = await threadsCollection.find(message._id);
-				} catch (error) {
-					// Do nothing
-				}
-
-				if (threadRecord) {
-					const updateThread = threadRecord.prepareUpdate(protectedFunction((t) => {
-						Object.assign(t, message);
-					}));
-					this._threadsBatch[message._id] = updateThread;
-				} else {
+					const threadRecord = await threadsCollection.find(message._id);
+					if (!threadRecord._hasPendingUpdate) {
+						const updateThread = threadRecord.prepareUpdate(protectedFunction((t) => {
+							Object.assign(t, message);
+						}));
+						this._threadsBatch[message._id] = updateThread;
+					}
+				} catch {
 					const createThread = threadsCollection.prepareCreate(protectedFunction((t) => {
 						t._raw = sanitizedRaw({ id: message._id }, threadsCollection.schema);
 						t.subscription.id = this.rid;
@@ -210,19 +202,16 @@ export default class RoomSubscription {
 			// Create or update thread message
 			if (message.tmid) {
 				try {
-					threadMessageRecord = await threadMessagesCollection.find(message._id);
-				} catch (error) {
-					// Do nothing
-				}
-
-				if (threadMessageRecord) {
-					const updateThreadMessage = threadMessageRecord.prepareUpdate(protectedFunction((tm) => {
-						Object.assign(tm, message);
-						tm.rid = message.tmid;
-						delete tm.tmid;
-					}));
-					this._threadMessagesBatch[message._id] = updateThreadMessage;
-				} else {
+					const threadMessageRecord = await threadMessagesCollection.find(message._id);
+					if (!threadMessageRecord._hasPendingUpdate) {
+						const updateThreadMessage = threadMessageRecord.prepareUpdate(protectedFunction((tm) => {
+							Object.assign(tm, message);
+							tm.rid = message.tmid;
+							delete tm.tmid;
+						}));
+						this._threadMessagesBatch[message._id] = updateThreadMessage;
+					}
+				} catch {
 					const createThreadMessage = threadMessagesCollection.prepareCreate(protectedFunction((tm) => {
 						tm._raw = sanitizedRaw({ id: message._id }, threadMessagesCollection.schema);
 						Object.assign(tm, message);