From 66d986e2b5aa6702c87eb1b8d9f06045db6fc154 Mon Sep 17 00:00:00 2001 From: Diego Mello Date: Mon, 19 Jul 2021 18:04:45 -0300 Subject: [PATCH] Chore: Improve QA workflow (#3285) --- .circleci/config.yml | 34 +++++++++++++++++++++++++++++----- android/fastlane/Fastfile | 8 ++++++++ android/fastlane/README.md | 27 +++++++++++---------------- 3 files changed, 48 insertions(+), 21 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 182e6433..0f72a02c 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -290,6 +290,23 @@ commands: command: bundle exec fastlane android beta official:<< parameters.official >> working_directory: android + # EXPERIMENTAL ONLY + upload-to-internal-app-sharing: + description: "Upload to Internal App Sharing" + steps: + - checkout + - attach_workspace: + at: android + - run: + name: Store the google service account key + command: echo "$FASTLANE_GOOGLE_SERVICE_ACCOUNT" | base64 --decode > service_account.json + working_directory: android + - run: *update-fastlane-android + - run: + name: Fastlane Play Store Upload + command: bundle exec fastlane android internal_app_sharing + working_directory: android + # EXPERIMENTAL ONLY # No plans to do it for Official upload-to-google-play-production: @@ -391,6 +408,14 @@ jobs: steps: - android-build + android-internal-app-sharing-experimental: + <<: *defaults + docker: + - image: circleci/android:api-28-node + + steps: + - upload-to-internal-app-sharing + android-google-play-beta-experimental: <<: *defaults docker: @@ -452,13 +477,9 @@ workflows: - ios-build-experimental: requires: - ios-hold-build-experimental - - ios-hold-testflight-experimental: - type: approval - requires: - - ios-build-experimental - ios-testflight-experimental: requires: - - ios-hold-testflight-experimental + - ios-build-experimental # iOS Official - ios-hold-build-official: @@ -484,6 +505,9 @@ workflows: - android-build-experimental: requires: - android-hold-build-experimental + - android-internal-app-sharing-experimental: + requires: + - android-build-experimental - android-hold-google-play-beta-experimental: type: approval requires: diff --git a/android/fastlane/Fastfile b/android/fastlane/Fastfile index a1c5bd70..0f600c36 100644 --- a/android/fastlane/Fastfile +++ b/android/fastlane/Fastfile @@ -33,6 +33,14 @@ platform :android do end end + desc "Upload App to Internal App Sharing" + lane :internal_app_sharing do + upload_to_play_store_internal_app_sharing( + package_name: 'chat.rocket.reactnative', + aab: 'android/app/build/outputs/bundle/experimentalPlayRelease/app-experimental-play-release.aab' + ) + end + desc "Upload App to Play Store Production" lane :production do |options| upload_to_play_store( diff --git a/android/fastlane/README.md b/android/fastlane/README.md index 32a0f12c..8c462602 100644 --- a/android/fastlane/README.md +++ b/android/fastlane/README.md @@ -12,33 +12,28 @@ Install _fastlane_ using ``` [sudo] gem install fastlane -NV ``` -or alternatively using `brew cask install fastlane` +or alternatively using `brew install fastlane` # Available Actions ## Android -### android playBuild +### android beta ``` -fastlane android playBuild +fastlane android beta ``` -Play build for development -### android fossRelease +Upload App to Play Store Internal +### android internal_app_sharing ``` -fastlane android fossRelease +fastlane android internal_app_sharing ``` -Foss build for release -### android playRelease +Upload App to Internal App Sharing +### android production ``` -fastlane android playRelease +fastlane android production ``` -Play build for release -### android playAlpha -``` -fastlane android playAlpha -``` -Upload App to Play store +Upload App to Play Store Production ---- -This README.md is auto-generated and will be re-generated every time [fastlane](https://fastlane.tools) is run. +This README.md is auto-generated and will be re-generated every time [_fastlane_](https://fastlane.tools) is run. More information about fastlane can be found on [fastlane.tools](https://fastlane.tools). The documentation of fastlane can be found on [docs.fastlane.tools](https://docs.fastlane.tools).