From 744893fa3177c075574707ee00ae5b8503fd552c Mon Sep 17 00:00:00 2001 From: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com> Date: Wed, 20 Oct 2021 15:00:35 -0300 Subject: [PATCH] Chore: Migrate AuthenticationWebView to Typescript (#3441) * Chore: Migrate AuthenticationWebView to Typescript * minor tweak * added @types/url-parser --- ...onWebView.js => AuthenticationWebView.tsx} | 66 ++++++++++++------- package.json | 1 + yarn.lock | 5 ++ 3 files changed, 49 insertions(+), 23 deletions(-) rename app/views/{AuthenticationWebView.js => AuthenticationWebView.tsx} (79%) diff --git a/app/views/AuthenticationWebView.js b/app/views/AuthenticationWebView.tsx similarity index 79% rename from app/views/AuthenticationWebView.js rename to app/views/AuthenticationWebView.tsx index bba518d7..870af956 100644 --- a/app/views/AuthenticationWebView.js +++ b/app/views/AuthenticationWebView.tsx @@ -1,8 +1,9 @@ import React from 'react'; -import PropTypes from 'prop-types'; -import { WebView } from 'react-native-webview'; +import { WebView, WebViewNavigation } from 'react-native-webview'; import { connect } from 'react-redux'; import parse from 'url-parse'; +import { StackNavigationProp } from '@react-navigation/stack'; +import { WebViewMessage } from 'react-native-webview/lib/WebViewTypes'; import RocketChat from '../lib/rocketchat'; import { isIOS } from '../utils/deviceInfo'; @@ -40,17 +41,44 @@ window.addEventListener('popstate', function() { }); `; -class AuthenticationWebView extends React.PureComponent { - static propTypes = { - navigation: PropTypes.object, - route: PropTypes.object, - server: PropTypes.string, - Accounts_Iframe_api_url: PropTypes.bool, - Accounts_Iframe_api_method: PropTypes.bool, - theme: PropTypes.string +interface IRoute { + params: { + authType: string; + url: string; + ssoToken?: string; + }; +} + +interface INavigationOption { + navigation: StackNavigationProp; + route: IRoute; +} + +interface IAuthenticationWebView extends INavigationOption { + server: string; + Accounts_Iframe_api_url: string; + Accounts_Iframe_api_method: string; + theme: string; +} + +interface IState { + logging: boolean; + loading: boolean; +} + +class AuthenticationWebView extends React.PureComponent { + private oauthRedirectRegex: RegExp; + private iframeRedirectRegex: RegExp; + + static navigationOptions = ({ route, navigation }: INavigationOption) => { + const { authType } = route.params; + return { + headerLeft: () => , + title: ['saml', 'cas', 'iframe'].includes(authType) ? 'SSO' : 'OAuth' + }; }; - constructor(props) { + constructor(props: IAuthenticationWebView) { super(props); this.state = { logging: false, @@ -71,7 +99,7 @@ class AuthenticationWebView extends React.PureComponent { navigation.pop(); }; - login = params => { + login = (params: any) => { const { logging } = this.state; if (logging) { return; @@ -89,7 +117,7 @@ class AuthenticationWebView extends React.PureComponent { }; // Force 3s delay so the server has time to evaluate the token - debouncedLogin = debounce(params => this.login(params), 3000); + debouncedLogin = debounce((params: any) => this.login(params), 3000); tryLogin = debounce( async () => { @@ -104,7 +132,7 @@ class AuthenticationWebView extends React.PureComponent { true ); - onNavigationStateChange = webViewState => { + onNavigationStateChange = (webViewState: WebViewNavigation | WebViewMessage) => { const url = decodeURIComponent(webViewState.url); const { route } = this.props; const { authType } = route.params; @@ -180,18 +208,10 @@ class AuthenticationWebView extends React.PureComponent { } } -const mapStateToProps = state => ({ +const mapStateToProps = (state: any) => ({ server: state.server.server, Accounts_Iframe_api_url: state.settings.Accounts_Iframe_api_url, Accounts_Iframe_api_method: state.settings.Accounts_Iframe_api_method }); -AuthenticationWebView.navigationOptions = ({ route, navigation }) => { - const { authType } = route.params; - return { - headerLeft: () => , - title: ['saml', 'cas', 'iframe'].includes(authType) ? 'SSO' : 'OAuth' - }; -}; - export default connect(mapStateToProps)(withTheme(AuthenticationWebView)); diff --git a/package.json b/package.json index dcf82c98..fbc64341 100644 --- a/package.json +++ b/package.json @@ -51,6 +51,7 @@ "@rocket.chat/react-native-fast-image": "^8.2.0", "@rocket.chat/sdk": "RocketChat/Rocket.Chat.js.SDK#mobile", "@rocket.chat/ui-kit": "0.13.0", + "@types/url-parse": "^1.4.4", "bytebuffer": "^5.0.1", "color2k": "1.2.4", "commonmark": "git+https://github.com/RocketChat/commonmark.js.git", diff --git a/yarn.lock b/yarn.lock index 38816238..f4ad938a 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4506,6 +4506,11 @@ dependencies: source-map "^0.6.1" +"@types/url-parse@^1.4.4": + version "1.4.4" + resolved "https://registry.yarnpkg.com/@types/url-parse/-/url-parse-1.4.4.tgz#ebeb0ec8b581318739cf73e9f9b186f610764255" + integrity sha512-KtQLad12+4T/NfSxpoDhmr22+fig3T7/08QCgmutYA6QSznSRmEtuL95GrhVV40/0otTEdFc+etRcCTqhh1q5Q== + "@types/webpack-env@^1.15.0": version "1.15.2" resolved "https://registry.yarnpkg.com/@types/webpack-env/-/webpack-env-1.15.2.tgz#927997342bb9f4a5185a86e6579a0a18afc33b0a"