From b8474286a80df21b81e7f2499d1cce123bdd9c62 Mon Sep 17 00:00:00 2001 From: Youssef Muhamad Date: Thu, 15 Oct 2020 10:43:12 -0300 Subject: [PATCH] [FIX] Failing iOS build on fork PR (#2558) * Fix fastlane build for a fork PR * Change the iOS fastlane command to build_fork --- .circleci/config.yml | 2 +- ios/fastlane/Fastfile | 17 +++-------------- 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 5f8110d9..422667f1 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -347,7 +347,7 @@ jobs: echo $APP_STORE_CONNECT_API_KEY | base64 --decode > ./fastlane/app_store_connect_api_key.p8 bundle exec fastlane ios release else - bundle exec fastlane ios build + bundle exec fastlane ios build_fork fi working_directory: ios diff --git a/ios/fastlane/Fastfile b/ios/fastlane/Fastfile index 0b014fce..456a8a2c 100644 --- a/ios/fastlane/Fastfile +++ b/ios/fastlane/Fastfile @@ -59,20 +59,9 @@ platform :ios do gym(scheme: "RocketChatRN", workspace: "RocketChatRN.xcworkspace") end - desc "Build App for development" - lane :build do |options| - xcodebuild( - workspace: "RocketChatRN.xcworkspace", - scheme: "RocketChatRN", - configuration: "Debug", - clean: options[:clean], - build: true, - destination: "generic/platform=iOS", - build_settings: { - "CODE_SIGNING_REQUIRED" => "NO", - "CODE_SIGN_IDENTITY" => "" - } - ) + desc "Build fork app" + lane :build_fork do + gym(scheme: "RocketChatRN", workspace: "RocketChatRN.xcworkspace", skip_codesigning: true, skip_archive: true) end after_all do |lane|