Explicit export Detox imports as per documentation

.eslintrc.js

@@ -240,19 +240,8 @@ module.exports = {
 		},
 		{
 			files: ['e2e/**'],
-			globals: {
-				by: true,
-				detox: true,
-				device: true,
-				element: true,
-				waitFor: true
-			},
 			rules: {
-				'import/no-extraneous-dependencies': 0,
-				'no-await-in-loop': 0,
-				'no-restricted-syntax': 0,
-				// TODO: remove this rule when update Detox to 20 and test if the namespace Detox is available
-				'no-undef': 1
+				'no-await-in-loop': 0
 			}
 		}
 	]

e2e/helpers/app.ts

@@ -1,4 +1,4 @@
-import { by, expect, element } from 'detox';
+import Detox, { device, waitFor, element, by, expect } from 'detox';
 
 import data from '../data';
 

e2e/tests/assorted/01-e2eencryption.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import {
 	navigateToLogin,

e2e/tests/assorted/02-broadcast.spec.ts

@@ -1,6 +1,6 @@
 // const OTP = require('otp.js');
 // const GA = OTP.googleAuthenticator;
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import {
 	navigateToLogin,

e2e/tests/assorted/03-profile.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import { navigateToLogin, login, sleep, platformTypes, TTextMatcher } from '../../helpers/app';
 import { createRandomUser, ITestUser } from '../../helpers/data_setup';

e2e/tests/assorted/04-setting.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import { navigateToLogin, login, platformTypes, TTextMatcher } from '../../helpers/app';
 import { createRandomRoom, createRandomUser, ITestUser } from '../../helpers/data_setup';

e2e/tests/assorted/05-joinpublicroom.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import data from '../../data';
 import { navigateToLogin, login, tapBack, searchRoom, platformTypes, TTextMatcher, mockRandomMessage } from '../../helpers/app';

e2e/tests/assorted/06-status.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import { navigateToLogin, login, sleep } from '../../helpers/app';
 import { createRandomUser, ITestUser } from '../../helpers/data_setup';

e2e/tests/assorted/07-changeserver.spec.ts

@@ -1,3 +1,5 @@
+import { device, waitFor, element, by } from 'detox';
+
 import data from '../../data';
 import { navigateToLogin, login, checkServer, expectValidRegisterOrRetry } from '../../helpers/app';
 import { createRandomRoom, createRandomUser, ITestUser } from '../../helpers/data_setup';

e2e/tests/assorted/08-joinprotectedroom.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import data from '../../data';
 import { navigateToLogin, login, searchRoom, mockRandomMessage } from '../../helpers/app';

e2e/tests/assorted/09-joinfromdirectory.spec.ts

@@ -1,3 +1,5 @@
+import { device, waitFor, element, by } from 'detox';
+
 import data from '../../data';
 import { navigateToLogin, login, tapBack, sleep } from '../../helpers/app';
 import { createRandomTeam, createRandomUser, ITestUser, sendMessage } from '../../helpers/data_setup';

e2e/tests/assorted/10-deleteserver.spec.ts

@@ -1,3 +1,5 @@
+import { device, waitFor, element, by } from 'detox';
+
 import data from '../../data';
 import {
 	sleep,

e2e/tests/assorted/11-deeplinking.spec.ts

@@ -1,3 +1,4 @@
+import { device, waitFor, element, by } from 'detox';
 import EJSON from 'ejson';
 
 import data from '../../data';

e2e/tests/assorted/12-i18n.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import Detox, { device, waitFor, element, by, expect } from 'detox';
 
 import { navigateToLogin, login } from '../../helpers/app';
 import { createRandomUser, ITestUser } from '../../helpers/data_setup';

e2e/tests/assorted/13-display-pref.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import { login, navigateToLogin } from '../../helpers/app';
 import { createRandomUser } from '../../helpers/data_setup';

e2e/tests/assorted/14-in-app-notification.spec.ts

@@ -1,3 +1,5 @@
+import { device, waitFor, element, by } from 'detox';
+
 import { navigateToLogin, login, sleep, tapBack, navigateToRoom, checkRoomTitle } from '../../helpers/app';
 import { sendMessage, post, ITestUser, createRandomUser, createRandomRoom } from '../../helpers/data_setup';
 

e2e/tests/onboarding/01-onboarding.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import { TTextMatcher, platformTypes } from '../../helpers/app';
 import data from '../../data';

e2e/tests/onboarding/02-legal.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import { navigateToRegister, navigateToLogin } from '../../helpers/app';
 

e2e/tests/onboarding/03-forgotpassword.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import { navigateToLogin, platformTypes, TTextMatcher } from '../../helpers/app';
 import { createRandomUser, ITestUser } from '../../helpers/data_setup';

e2e/tests/onboarding/04-createuser.spec.ts

@@ -1,3 +1,5 @@
+import { device, element, by } from 'detox';
+
 import { navigateToRegister, expectValidRegisterOrRetry } from '../../helpers/app';
 import data from '../../data';
 

e2e/tests/onboarding/05-login.spec.ts

@@ -1,3 +1,5 @@
+import { device, waitFor, element, by } from 'detox';
+
 import { navigateToLogin, tapBack, platformTypes, navigateToWorkspace, login, TTextMatcher } from '../../helpers/app';
 import { createRandomUser, ITestUser } from '../../helpers/data_setup';
 

e2e/tests/onboarding/06-roomslist.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import { login, navigateToLogin, logout, tapBack, searchRoom } from '../../helpers/app';
 import { createRandomUser } from '../../helpers/data_setup';

e2e/tests/onboarding/07-server-history.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import { login, navigateToLogin, logout, tapBack, tapAndWaitFor } from '../../helpers/app';
 import data from '../../data';

e2e/tests/room/01-createroom.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import { tapBack, navigateToLogin, login, platformTypes, TTextMatcher, tapAndWaitFor } from '../../helpers/app';
 import { createRandomUser } from '../../helpers/data_setup';

e2e/tests/room/02-room.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import {
 	navigateToLogin,

e2e/tests/room/03-roomactions.spec.ts

@@ -1,6 +1,5 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
-// import data from '../../data';
 import {
 	navigateToLogin,
 	login,

e2e/tests/room/04-discussion.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import {
 	TTextMatcher,

e2e/tests/room/05-threads.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import {
 	navigateToLogin,

e2e/tests/room/06-createdmgroup.spec.ts

@@ -1,3 +1,5 @@
+import { device, waitFor, element, by } from 'detox';
+
 import { navigateToLogin, login, platformTypes, TTextMatcher } from '../../helpers/app';
 import { createRandomUser, ITestUser } from '../../helpers/data_setup';
 

e2e/tests/room/07-markasunread.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import { navigateToLogin, login, sleep, platformTypes, TTextMatcher, navigateToRoom } from '../../helpers/app';
 import { createRandomUser, ITestUser, sendMessage } from '../../helpers/data_setup';

e2e/tests/room/08-roominfo.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import Detox, { device, waitFor, element, by, expect } from 'detox';
 
 import { navigateToLogin, login, tapBack, sleep, platformTypes, TTextMatcher, navigateToRoom } from '../../helpers/app';
 import { createRandomRoom, createRandomUser, ITestUser } from '../../helpers/data_setup';

e2e/tests/room/09-jumptomessage.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import data from '../../data';
 import { navigateToLogin, tapBack, login, sleep, platformTypes, TTextMatcher, navigateToRoom } from '../../helpers/app';

e2e/tests/room/10-ignoreuser.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import {
 	navigateToLogin,

e2e/tests/team/01-createteam.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import { device, waitFor, element, by, expect } from 'detox';
 
 import { navigateToLogin, login, platformTypes, TTextMatcher } from '../../helpers/app';
 import { createRandomUser, ITestUser } from '../../helpers/data_setup';

e2e/tests/team/02-team.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'detox';
+import Detox, { device, waitFor, element, by, expect } from 'detox';
 
 import {
 	navigateToLogin,

e2e/tests/team/03-moveconvert.spec.ts

@@ -1,3 +1,5 @@
+import { device, waitFor, element, by } from 'detox';
+
 import { navigateToLogin, login, tapBack, platformTypes, TTextMatcher, sleep, navigateToRoom } from '../../helpers/app';
 import { createRandomUser, ITestUser } from '../../helpers/data_setup';
 import random from '../../helpers/random';