Chore: Migrate LoginView to TypeScript (#3423)

* Initial commit

* Update interface

* Minor tweaks

* Update FormContainer.tsx

* Minor tweaks

* update snapshots

* Update TextInput interface

* Update snapshots

* Merge branch 'develop' into chore.migrate-loginview-ts

* Minor tweak

__tests__/__snapshots__/Storyshots.test.js.snap

@@ -76288,8 +76288,6 @@ exports[`Storyshots Text Input Short and Long Text 1`] = `
     }
   >
     <Text
-      accessibilityLabel={null}
-      contentDescription={null}
       style={
         Array [
           Object {
@@ -76321,7 +76319,6 @@ exports[`Storyshots Text Input Short and Long Text 1`] = `
         allowFontScaling={true}
         autoCapitalize="none"
         autoCorrect={false}
-        contentDescription="placeholder"
         keyboardAppearance="light"
         placeholder="placeholder"
         placeholderTextColor="#9ca2a8"
@@ -76374,8 +76371,6 @@ exports[`Storyshots Text Input Short and Long Text 1`] = `
     }
   >
     <Text
-      accessibilityLabel={null}
-      contentDescription={null}
       style={
         Array [
           Object {
@@ -76407,7 +76402,6 @@ exports[`Storyshots Text Input Short and Long Text 1`] = `
         allowFontScaling={true}
         autoCapitalize="none"
         autoCorrect={false}
-        contentDescription="placeholder"
         keyboardAppearance="light"
         placeholder="placeholder"
         placeholderTextColor="#9ca2a8"

app/containers/TextInput.tsx

@@ -146,17 +146,10 @@ export default class RCTextInput extends React.PureComponent<IRCTextInputProps,
 		return (
 			<View style={[styles.inputContainer, containerStyle]}>
 				{label ? (
-					<Text
+					<Text style={[styles.label, { color: themes[theme].titleText }, error?.error && { color: dangerColor }]}>{label}</Text>
-						contentDescription={null}
-						// @ts-ignore
-						accessibilityLabel={null}
-						style={[styles.label, { color: themes[theme].titleText }, error?.error && { color: dangerColor }]}>
-						{label}
-					</Text>
 				) : null}
 				<View style={styles.wrap}>
 					<TextInput
-						/* @ts-ignore*/
 						style={[
 							styles.input,
 							iconLeft && styles.inputIconLeft,
@@ -173,7 +166,6 @@ export default class RCTextInput extends React.PureComponent<IRCTextInputProps,
 							inputStyle
 						]}
 						ref={inputRef}
-						/* @ts-ignore*/
 						autoCorrect={false}
 						autoCapitalize='none'
 						underlineColorAndroid='transparent'
@@ -181,8 +173,6 @@ export default class RCTextInput extends React.PureComponent<IRCTextInputProps,
 						testID={testID}
 						accessibilityLabel={placeholder}
 						placeholder={placeholder}
-						/* @ts-ignore*/
-						contentDescription={placeholder}
 						theme={theme}
 						{...inputProps}
 					/>

app/presentation/TextInput.tsx

@@ -1,5 +1,5 @@
 import React from 'react';
-import { I18nManager, StyleSheet, TextInput, TextInputProps } from 'react-native';
+import { I18nManager, StyleProp, StyleSheet, TextInput, TextInputProps, TextStyle } from 'react-native';
 
 import { themes } from '../constants/colors';
 
@@ -10,7 +10,7 @@ const styles = StyleSheet.create({
 });
 
 interface IThemedTextInput extends TextInputProps {
-	style: object;
+	style: StyleProp<TextStyle>;
 	theme: string;
 }
 

app/views/LoginView.tsx

@@ -1,8 +1,9 @@
 import React from 'react';
-import PropTypes from 'prop-types';
 import { Alert, Keyboard, StyleSheet, Text, View } from 'react-native';
 import { connect } from 'react-redux';
 import { dequal } from 'dequal';
+import { StackNavigationProp } from '@react-navigation/stack';
+import { RouteProp } from '@react-navigation/core';
 
 import Button from '../containers/Button';
 import I18n from '../i18n';
@@ -46,31 +47,35 @@ const styles = StyleSheet.create({
 	}
 });
 
-class LoginView extends React.Component {
+interface IProps {
-	static navigationOptions = ({ route, navigation }) => ({
+	navigation: StackNavigationProp<any>;
-		title: route.params?.title ?? 'Rocket.Chat',
+	route: RouteProp<any, 'RegisterView'>;
+	Site_Name: string;
+	Accounts_RegistrationForm: string;
+	Accounts_RegistrationForm_LinkReplacementText: string;
+	Accounts_EmailOrUsernamePlaceholder: string;
+	Accounts_PasswordPlaceholder: string;
+	Accounts_PasswordReset: boolean;
+	Accounts_ShowFormLogin: boolean;
+	isFetching: boolean;
+	error: {
+		error: string;
+	};
+	failure: boolean;
+	theme: string;
+	loginRequest: Function;
+	inviteLinkToken: string;
+}
+
+class LoginView extends React.Component<IProps, any> {
+	private passwordInput: any;
+
+	static navigationOptions = ({ route, navigation }: Partial<IProps>) => ({
+		title: route?.params?.title ?? 'Rocket.Chat',
 		headerRight: () => <HeaderButton.Legal testID='login-view-more' navigation={navigation} />
 	});
 
-	static propTypes = {
+	constructor(props: IProps) {
-		navigation: PropTypes.object,
-		route: PropTypes.object,
-		Site_Name: PropTypes.string,
-		Accounts_RegistrationForm: PropTypes.string,
-		Accounts_RegistrationForm_LinkReplacementText: PropTypes.string,
-		Accounts_EmailOrUsernamePlaceholder: PropTypes.string,
-		Accounts_PasswordPlaceholder: PropTypes.string,
-		Accounts_PasswordReset: PropTypes.bool,
-		Accounts_ShowFormLogin: PropTypes.bool,
-		isFetching: PropTypes.bool,
-		error: PropTypes.object,
-		failure: PropTypes.bool,
-		theme: PropTypes.string,
-		loginRequest: PropTypes.func,
-		inviteLinkToken: PropTypes.string
-	};
-
-	constructor(props) {
 		super(props);
 		this.state = {
 			user: props.route.params?.username ?? '',
@@ -78,10 +83,10 @@ class LoginView extends React.Component {
 		};
 	}
 
-	UNSAFE_componentWillReceiveProps(nextProps) {
+	UNSAFE_componentWillReceiveProps(nextProps: IProps) {
 		const { error } = this.props;
 		if (nextProps.failure && !dequal(error, nextProps.error)) {
-			if (nextProps.error.error === 'error-invalid-email') {
+			if (nextProps.error?.error === 'error-invalid-email') {
 				this.resendEmailConfirmation();
 			} else {
 				Alert.alert(I18n.t('Oops'), I18n.t('Login_error'));
@@ -156,7 +161,7 @@ class LoginView extends React.Component {
 					placeholder={Accounts_EmailOrUsernamePlaceholder || I18n.t('Username_or_email')}
 					keyboardType='email-address'
 					returnKeyType='next'
-					onChangeText={value => this.setState({ user: value })}
+					onChangeText={(value: string) => this.setState({ user: value })}
 					onSubmitEditing={() => {
 						this.passwordInput.focus();
 					}}
@@ -176,7 +181,7 @@ class LoginView extends React.Component {
 					returnKeyType='send'
 					secureTextEntry
 					onSubmitEditing={this.submit}
-					onChangeText={value => this.setState({ password: value })}
+					onChangeText={(value: string) => this.setState({ password: value })}
 					testID='login-view-password'
 					textContentType='password'
 					autoCompleteType='password'
@@ -237,7 +242,7 @@ class LoginView extends React.Component {
 	}
 }
 
-const mapStateToProps = state => ({
+const mapStateToProps = (state: any) => ({
 	server: state.server.server,
 	Site_Name: state.settings.Site_Name,
 	Accounts_ShowFormLogin: state.settings.Accounts_ShowFormLogin,
@@ -252,8 +257,8 @@ const mapStateToProps = state => ({
 	inviteLinkToken: state.inviteLinks.token
 });
 
-const mapDispatchToProps = dispatch => ({
+const mapDispatchToProps = (dispatch: any) => ({
-	loginRequest: params => dispatch(loginRequestAction(params))
+	loginRequest: (params: any) => dispatch(loginRequestAction(params))
 });
 
 export default connect(mapStateToProps, mapDispatchToProps)(withTheme(LoginView));