fix: floating promises and fork usage on login saga (#5589)

app/lib/methods/getCustomEmojis.ts

@@ -146,6 +146,8 @@ export function getCustomEmojis() {
 			if (changedEmojis) {
 				setCustomEmojis();
 			}
+
+			return resolve();
 		} catch (e) {
 			log(e);
 			return resolve();

app/lib/methods/getSlashCommands.ts

@@ -70,6 +70,7 @@ export function getSlashCommands() {
 					return allRecords.length;
 				});
 			}
+			return resolve();
 		} catch (e) {
 			log(e);
 			return resolve();

app/sagas/login.js

@@ -168,10 +168,6 @@ const fetchEnterpriseModulesFork = function* fetchEnterpriseModulesFork({ user }
 	}
 };
 
-const fetchRoomsFork = function* fetchRoomsFork() {
-	yield put(roomsRequest());
-};
-
 const fetchUsersRoles = function* fetchRoomsFork() {
 	const roles = yield Services.getUsersRoles();
 	if (roles.length) {
@@ -184,7 +180,7 @@ const handleLoginSuccess = function* handleLoginSuccess({ user }) {
 		getUserPresence(user.id);
 
 		const server = yield select(getServer);
-		yield fork(fetchRoomsFork);
+		yield put(roomsRequest());
 		yield fork(fetchPermissionsFork);
 		yield fork(fetchCustomEmojisFork);
 		yield fork(fetchRolesFork);