swagger: use X-Forwarded-Host for basePath
This commit is contained in:
parent
dd27b2428c
commit
6838087a5c
|
@ -114,12 +114,14 @@ function addRoute(app, uri, doc, opts) {
|
||||||
// can't guarantee this path is either reachable or desirable if it's set
|
// can't guarantee this path is either reachable or desirable if it's set
|
||||||
// as a part of the options.
|
// as a part of the options.
|
||||||
//
|
//
|
||||||
// The simplest way around this is to reflect the value of the `Host` HTTP
|
// The simplest way around this is to reflect the value of the `Host` and/or
|
||||||
// header as the `basePath`. Because we pre-build the Swagger data, we don't
|
// `X-Forwarded-Host` HTTP headers as the `basePath`.
|
||||||
// know that header at the time the data is built.
|
// Because we pre-build the Swagger data, we don't know that header at
|
||||||
|
// the time the data is built.
|
||||||
if (hasBasePath) {
|
if (hasBasePath) {
|
||||||
var headers = req.headers;
|
var headers = req.headers;
|
||||||
var host = headers.Host || headers.host;
|
// NOTE header names (keys) are always all-lowercase
|
||||||
|
var host = headers['x-forwarded-host'] || headers.host;
|
||||||
doc.basePath = (opts.protocol || req.protocol) + '://' +
|
doc.basePath = (opts.protocol || req.protocol) + '://' +
|
||||||
host + initialPath;
|
host + initialPath;
|
||||||
}
|
}
|
||||||
|
|
|
@ -81,6 +81,18 @@ describe('swagger definition', function() {
|
||||||
done();
|
done();
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('respects X-Forwarded-Host header (behind a proxy)', function(done) {
|
||||||
|
var app = mountSwagger();
|
||||||
|
getAPIDeclaration(app, 'products')
|
||||||
|
.set('X-Forwarded-Host', 'example.com')
|
||||||
|
.end(function(err, res) {
|
||||||
|
if (err) return done(err);
|
||||||
|
var baseUrl = url.parse(res.body.basePath);
|
||||||
|
expect(baseUrl.hostname).to.equal('example.com');
|
||||||
|
done();
|
||||||
|
});
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
describe('Model definition attributes', function() {
|
describe('Model definition attributes', function() {
|
||||||
|
|
Loading…
Reference in New Issue