verdnatura-mirror
/
loopback-component-explorer
mirror of https://github.com/strongloop/loopback-component-explorer.git
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[SEMVER-MAJOR] Remove deprecated CORS support 

It's the responsibility of the applications using API Explorer
to configure an app-wide CORS middleware.
This commit is contained in:
Hiran del Castillo 2018-04-05 14:06:30 -05:00 committed by Miroslav Bajtoš
parent 6419f48d83
commit fc43ff6e63
No known key found for this signature in database
GPG Key ID: 6F2304BA9361C7E3
3 changed files with 0 additions and 59 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
index.js
View File

@ -12,12 +12,10 @@ var g = SG();
/*!
* Adds dynamically-updated docs as /explorer
*/
var deprecated = require('depd')('loopback-explorer');
var url = require('url');
var path = require('path');
var urlJoin = require('./lib/url-join');
var _defaults = require('lodash').defaults;
var cors = require('cors');
var createSwaggerObject = require('loopback-swagger').generateSwaggerSpec;
var SWAGGER_UI_ROOT = require('swagger-ui/index').dist;
var STATIC_ROOT = path.join(__dirname, 'public');
@ -135,9 +133,6 @@ function mountSwagger(loopbackApplication, swaggerApp, opts) {
var resourcePath = (opts && opts.resourcePath) || 'swagger.json';
if (resourcePath[0] !== '/') resourcePath = '/' + resourcePath;
var remotes = loopbackApplication.remotes();
setupCors(swaggerApp, remotes);
swaggerApp.get(resourcePath, function sendSwaggerObject(req, res) {
res.status(200).send(swaggerObject);
});
@ -146,22 +141,3 @@ function mountSwagger(loopbackApplication, swaggerApp, opts) {
swaggerObject = createSwaggerObject(loopbackApplication, opts);
}
}
function setupCors(swaggerApp, remotes) {
var corsOptions = remotes.options && remotes.options.cors;
if (corsOptions === false) return;
deprecated(
g.f(
'The built-in CORS middleware provided by loopback-component-explorer ' +
'was deprecated. See %s for more details.',
'https://loopback.io/doc/en/lb3/Security-considerations.html'
)
);
if (corsOptions === undefined) {
corsOptions = { origin: true, credentials: true };
}
swaggerApp.use(cors(corsOptions));
}

2
package.json
View File

@ -35,9 +35,7 @@
},
"license": "MIT",
"dependencies": {
"cors": "^2.7.1",
"debug": "^2.2.0",
"depd": "^1.1.0",
"lodash": "^4.17.5",
"loopback-swagger": "^5.0.0",
"strong-globalize": "^3.1.0",

33
test/explorer.test.js
View File

@ -258,39 +258,6 @@ describe('explorer', function() {
});
});
describe('Cross-origin resource sharing', function() {
it('allows cross-origin requests by default', function(done) {
var app = loopback();
process.once('deprecation', function() { /* ignore */ });
configureRestApiAndExplorer(app, '/explorer');
request(app)
.options('/explorer/swagger.json')
.set('Origin', 'http://example.com/')
.expect('Access-Control-Allow-Origin', /^http:\/\/example.com\/|\*/)
.expect('Access-Control-Allow-Methods', /\bGET\b/)
.end(done);
});
it('can be disabled by configuration', function(done) {
var app = loopback();
app.set('remoting', { cors: false });
configureRestApiAndExplorer(app, '/explorer');
request(app)
.options('/explorer/swagger.json')
.end(function(err, res) {
if (err) return done(err);
var allowOrigin = res.get('Access-Control-Allow-Origin');
expect(allowOrigin, 'Access-Control-Allow-Origin')
.to.equal(undefined);
done();
});
});
});
it('updates swagger object when a new model is added', function(done) {
var app = loopback();
app.set('remoting', { cors: false });