verdnatura-mirror
/
loopback-component-storage
mirror of https://github.com/strongloop/loopback-component-storage.git
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Image not found should return 404

This commit is contained in:
David Cheung 2016-12-07 12:07:52 -05:00
parent 9a2de90157
commit 2df5bc152a
1 changed files with 13 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
test/upload-download.test.js
View File

@ -91,7 +91,7 @@ describe('storage service', function() {
.set('Content-Type', 'application/json')
.expect('Content-Type', /json/)
.expect(200, function(err, res) {
if (err) done(err);
if (err) return done(err);
verifyMetadata(res.body, 'test-container');
done();
});
@ -103,7 +103,7 @@ describe('storage service', function() {
.set('Accept', 'application/json')
.expect('Content-Type', /json/)
.expect(200, function(err, res) {
if (err) done(err);
if (err) return done(err);
verifyMetadata(res.body, 'test-container');
done();
});
@ -115,7 +115,7 @@ describe('storage service', function() {
.set('Accept', 'application/json')
.expect('Content-Type', /json/)
.expect(200, function(err, res) {
if (err) done(err);
if (err) return done(err);
assert(Array.isArray(res.body));
assert.equal(res.body.length, 2);
res.body.forEach(function(c) {
@ -130,9 +130,7 @@ describe('storage service', function() {
.del('/containers/test-container')
.set('Accept', 'application/json')
.expect('Content-Type', /json/)
.expect(200, function(err, res) {
done(err);
});
.expect(200, done);
});
it('should list containers after delete', function(done) {
@ -141,7 +139,7 @@ describe('storage service', function() {
.set('Accept', 'application/json')
.expect('Content-Type', /json/)
.expect(200, function(err, res) {
if (err) done(err);
if (err) return done(err);
assert(Array.isArray(res.body));
assert.equal(res.body.length, 1);
done();
@ -154,7 +152,7 @@ describe('storage service', function() {
.set('Accept', 'application/json')
.expect('Content-Type', /json/)
.expect(200, function(err, res) {
if (err) done(err);
if (err) return done(err);
assert(Array.isArray(res.body));
res.body.forEach(function(f) {
verifyMetadata(f);
@ -170,7 +168,7 @@ describe('storage service', function() {
.set('Accept', 'application/json')
.expect('Content-Type', /json/)
.expect(200, function(err, res) {
if (err) done(err);
if (err) return done(err);
assert.deepEqual(res.body, {'result': {'files': {'image': [
{'container': 'album1', 'name': 'test.jpg', 'type': 'image/jpeg',
'size': 60475},
@ -186,7 +184,7 @@ describe('storage service', function() {
.set('Accept', 'application/json')
.expect('Content-Type', /json/)
.expect(200, function(err, res) {
if (err) done(err);
if (err) return done(err);
assert.deepEqual(res.body, {'result': {'files': {'image': [
{'container': 'album1', 'name': 'image-test.jpg', 'originalFilename': 'test.jpg', 'type': 'image/jpeg', 'acl': 'public-read', 'size': 60475},
]}, 'fields': {}}});
@ -277,10 +275,7 @@ describe('storage service', function() {
request('http://localhost:' + app.get('port'))
.get('/containers/album1/download/test.jpg')
.expect('Content-Type', 'image/jpeg')
.expect(200, function(err, res) {
if (err) done(err);
done();
});
.expect(200, done);
});
it('should run a function before a download is started by a client', function(done) {
@ -297,7 +292,7 @@ describe('storage service', function() {
.get('/containers/album1/download/test.jpg')
.expect('Content-Type', 'image/jpeg')
.expect(200, function(err, res) {
if (err) done(err);
if (err) return done(err);
assert(hookCalled, 'beforeRemote hook was not called');
done();
});
@ -317,7 +312,7 @@ describe('storage service', function() {
.get('/containers/album1/download/test.jpg')
.expect('Content-Type', 'image/jpeg')
.expect(200, function(err, res) {
if (err) done(err);
if (err) return done(err);
assert(hookCalled, 'afterRemote hook was not called');
done();
});
@ -346,16 +341,14 @@ describe('storage service', function() {
.del('/containers/album1/files/test.jpg')
.set('Accept', 'application/json')
.expect('Content-Type', /json/)
.expect(200, function(err, res) {
done(err);
});
.expect(200, done);
});
it('reports errors if it fails to find the file to download', function(done) {
request('http://localhost:' + app.get('port'))
.get('/containers/album1/download/test_not_exist.jpg')
.expect('Content-Type', /json/)
.expect(500, function(err, res) {
.expect(404, function(err, res) {
if (err) return done(err);
assert(res.body.error);
done();