Now, the AWS S3 options for server side encryptions are passed to the
upload handler. Thus, the client can specify the AWS options and use
AWS Server Side Encryption.
Without this change, generated Swagger spec for the upload operation
does not have `container` parameter even it's a variable on the path.
As a result, the sepc fails validations.
An optional `container` is added to the remote method. Conditional
check is added to ensure backward compatibility.
Per Swagger spec 2.0, parameters coming from the path must be marked
as required.
Before this change, the Swagger spec produced by loopback-swagger
was not valid because path parameters were optional.
Note that this commit does not fix the problem of the "uploaded"
method which does not have any swagger-supported parameters now,
and therefore the swagger spec will remain invalid (but with less
errors).
Fixes issue where upload and download methods in FileSystemProvider
cause crashes in downstream methods by not returning streams in error
scenarios
- Add streamError, readStreamError, writeStreamError helper function
- Wrap all returns from upload / download methods in streams
- Fix incorrect format string
- Add new unit tests
Now, the AWS S3 options for server side encryptions are passed to the
upload handler. Thus, the client can specify the AWS options and use
AWS Server Side Encryption.
Without this change, generated Swagger spec for the upload operation
does not have `container` parameter even it's a variable on the path.
As a result, the sepc fails validations.
An optional `container` is added to the remote method. Conditional
check is added to ensure backward compatibility.
Per Swagger spec 2.0, parameters coming from the path must be marked
as required.
Before this change, the Swagger spec produced by loopback-swagger
was not valid because path parameters were optional.
Note that this commit does not fix the problem of the "uploaded"
method which does not have any swagger-supported parameters now,
and therefore the swagger spec will remain invalid (but with less
errors).
Fixes issue where upload and download methods in FileSystemProvider
cause crashes in downstream methods by not returning streams in error
scenarios
- Add streamError, readStreamError, writeStreamError helper function
- Wrap all returns from upload / download methods in streams
- Fix incorrect format string
- Add new unit tests
Stop sending constructing the error response directly inside the
storage component and send the error back to the application to handle
it.
As a result:
- `File.afterRemoteError` hook is trigered now
- App-provided error handling strategy is used to build error
responses, e.g. using the production mode of strong-error-handler
to hide sensitive information.
Miguel González Aravena
Timo Wolf
Raymond Feng
Miroslav Bajtoš
Jose De Gouveia
Jeff Burn
Oscar Bernal
ole3021
Cristobal Vergara
Raymond Feng
Loay
Raymond Camden
Miroslav Bajtoš