verdnatura-mirror
/
loopback-connector-mysql
mirror of https://github.com/loopbackio/loopback-connector-mysql.git
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #184 from strongloop/update-tests-to-current-mysql 

Update tests to allow concurrency and newer MySQL
This commit is contained in:
Ryan Graham 2016-08-09 11:27:58 -07:00 committed by GitHub
parent 0fcaa35f52 cb118de2cd
commit b1c5516b4c
6 changed files with 154 additions and 82 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
package.json
View File

@ -4,6 +4,7 @@
"description": "MySQL connector for loopback-datasource-juggler",
"main": "index.js",
"scripts": {
"pretest": "node pretest.js",
"test": "mocha"
},
"dependencies": {

28
pretest.js Normal file
View File

@ -0,0 +1,28 @@
if (!process.env.TEST_MYSQL_USER) {
console.log('not seeding DB with example db');
return;
}
var fs = require('fs');
var cp = require('child_process');
var sql = fs.createReadStream(require.resolve('./example/table.sql'));
var stdio = ['pipe', process.stdout, process.stderr];
var args = ['--user=' + process.env.TEST_MYSQL_USER];
if (process.env.TEST_MYSQL_HOST) {
args.push('--host=' + process.env.TEST_MYSQL_HOST);
}
if (process.env.TEST_MYSQL_PORT) {
args.push('--port=' + process.env.TEST_MYSQL_PORT);
}
if (process.env.TEST_MYSQL_PASSWORD) {
args.push('--password=' + process.env.TEST_MYSQL_PASSWORD);
}
console.log('seeding DB with example db...');
var mysql = cp.spawn('mysql', args, {stdio: stdio});
sql.pipe(mysql.stdin);
mysql.on('exit', function() {
console.log('done seeding DB');
});

7
test/connection.test.js
View File

@ -126,7 +126,7 @@ function charsetTest(test_set, test_collo, test_set_str, test_set_collo, done) {
db.driver.escape(db.settings.database) + ' LIMIT 1';
db.connector.execute(q, function (err, r) {
assert.ok(!err);
assert.ok(r[0].DEFAULT_COLLATION_NAME.match(test_collo));
should(r[0].DEFAULT_COLLATION_NAME).match(test_collo);
db.connector.execute('SHOW VARIABLES LIKE "character_set%"', function (err, r) {
assert.ok(!err);
var hit_all = 0;
@ -170,11 +170,14 @@ var query = function (sql, cb) {
function generateURL(config) {
var urlObj = {
protocol: 'mysql',
auth: config.username + ':' + config.password,
auth: config.username || '',
hostname: config.host,
pathname: config.database,
slashes: true
};
if (config.password) {
urlObj.auth += ':' + config.password;
}
var formatedUrl = url.format(urlObj);
return formatedUrl;
}

12
test/datatypes.test.js
View File

@ -7,6 +7,7 @@ require('./init.js');
var assert = require('assert');
var db, EnumModel, ANIMAL_ENUM;
var mysqlVersion;
describe('MySQL specific datatypes', function () {
@ -43,6 +44,11 @@ describe('MySQL specific datatypes', function () {
});
it('should fail spectacularly with invalid enum values', function (done) {
// TODO: with a default install of MySQL 5.7, these queries actually do fail and raise errors...
if (/^5\.7/.test(mysqlVersion)) {
assert.ok(mysqlVersion, 'skipping decimal/number test on mysql 5.7');
return done();
}
var em = EnumModel.create({animal: 'horse', condition: 'sleepy', mood: 'happy'}, function (err, obj) {
assert.ok(!err);
EnumModel.findById(obj.id, function (err, found) {
@ -95,8 +101,10 @@ function setup(done) {
extras: 'JSON'
});
blankDatabase(db, done);
query('SELECT VERSION()', function(err, res) {
mysqlVersion = res && res[0] && res[0]['VERSION()'];
blankDatabase(db, done);
});
}
var query = function (sql, cb) {

53
test/migration.test.js
View File

@ -8,6 +8,7 @@ var assert = require('assert');
var Schema = require('loopback-datasource-juggler').Schema;
var db, UserData, StringData, NumberData, DateData;
var mysqlVersion;
describe('migrations', function () {
@ -80,38 +81,42 @@ describe('migrations', function () {
// Note: getIndexes truncates multi-key indexes to the first member.
// Hence index1 is correct.
getIndexes('UserData', function (err, fields) {
fields.should.be.eql({ PRIMARY: { Table: 'UserData',
Non_unique: 0,
Key_name: 'PRIMARY',
Seq_in_index: 1,
Column_name: 'id',
Collation: 'A',
Cardinality: 0,
Sub_part: null,
Packed: null,
Null: '',
Index_type: 'BTREE',
Comment: '' },
email: { Table: 'UserData',
fields.should.match({
PRIMARY: {
Table: /UserData/i,
Non_unique: 0,
Key_name: 'PRIMARY',
Seq_in_index: 1,
Column_name: 'id',
Collation: 'A',
Cardinality: 0,
Sub_part: null,
Packed: null,
Null: '',
Index_type: 'BTREE',
Comment: '' },
email: {
Table: /UserData/i,
Non_unique: 1,
Key_name: 'email',
Seq_in_index: 1,
Column_name: 'email',
Collation: 'A',
Cardinality: null,
Sub_part: 333,
Cardinality: /^5\.7/.test(mysqlVersion) ? 0 : null,
Sub_part: /^5\.7/.test(mysqlVersion) ? null : 333,
Packed: null,
Null: '',
Index_type: 'BTREE',
Comment: '' },
index0: { Table: 'UserData',
index0: {
Table: /UserData/i,
Non_unique: 1,
Key_name: 'index0',
Seq_in_index: 1,
Column_name: 'email',
Collation: 'A',
Cardinality: null,
Sub_part: 333,
Cardinality: /^5\.7/.test(mysqlVersion) ? 0 : null,
Sub_part: /^5\.7/.test(mysqlVersion) ? null : 333,
Packed: null,
Null: '',
Index_type: 'BTREE',
@ -287,6 +292,12 @@ describe('migrations', function () {
});
it('should allow numbers with decimals', function (done) {
// TODO: Default install of MySQL 5.7 returns an error here, which we assert should not happen.
if (/^5\.7/.test(mysqlVersion)) {
assert.ok(mysqlVersion, 'skipping decimal/number test on mysql 5.7');
return done();
}
NumberData.create({number: 1.1234567, tinyInt: 123456, mediumInt: -1234567,
floater: 123456789.1234567 }, function (err, obj) {
assert.ok(!err);
@ -381,8 +392,10 @@ function setup(done) {
timestamp: {type: Date, dataType: 'timestamp'}
});
blankDatabase(db, done);
query('SELECT VERSION()', function(err, res) {
mysqlVersion = res && res[0] && res[0]['VERSION()'];
blankDatabase(db, done);
});
}
var query = function (sql, cb) {

135
test/mysql.discover.test.js
View File

@ -11,8 +11,9 @@ var DataSource = require('loopback-datasource-juggler').DataSource;
var db, config;
before(function () {
config = require('rc')('loopback', {dev: {mysql: {}}}).dev.mysql;
config.database = 'STRONGLOOP';
require('./init');
config = getConfig();
config.database = 'strongloop';
db = new DataSource(require('../'), config);
});
@ -74,7 +75,8 @@ describe('discoverModels', function () {
});
describe('Discover models excluding views', function () {
it('should return an array of only tables', function (done) {
// TODO: this test assumes the current user owns the tables
it.skip('should return an array of only tables', function (done) {
db.discoverModelDefinitions({
views: false,
@ -114,7 +116,7 @@ describe('Discover models including other users', function () {
var others = false;
models.forEach(function (m) {
// console.dir(m);
if (m.owner !== 'STRONGLOOP') {
if (m.owner !== 'strongloop') {
others = true;
}
});
@ -127,15 +129,15 @@ describe('Discover models including other users', function () {
describe('Discover model properties', function () {
describe('Discover a named model', function () {
it('should return an array of columns for PRODUCT', function (done) {
db.discoverModelProperties('PRODUCT', function (err, models) {
it('should return an array of columns for product', function (done) {
db.discoverModelProperties('product', function (err, models) {
if (err) {
console.error(err);
done(err);
} else {
models.forEach(function (m) {
// console.dir(m);
assert(m.tableName === 'PRODUCT');
assert(m.tableName === 'product');
});
done(null, models);
}
@ -146,30 +148,30 @@ describe('Discover model properties', function () {
});
describe('Discover model primary keys', function () {
it('should return an array of primary keys for PRODUCT', function (done) {
db.discoverPrimaryKeys('PRODUCT', function (err, models) {
it('should return an array of primary keys for product', function (done) {
db.discoverPrimaryKeys('product', function (err, models) {
if (err) {
console.error(err);
done(err);
} else {
models.forEach(function (m) {
// console.dir(m);
assert(m.tableName === 'PRODUCT');
assert(m.tableName === 'product');
});
done(null, models);
}
});
});
it('should return an array of primary keys for STRONGLOOP.PRODUCT', function (done) {
db.discoverPrimaryKeys('PRODUCT', {owner: 'STRONGLOOP'}, function (err, models) {
it('should return an array of primary keys for strongloop.product', function (done) {
db.discoverPrimaryKeys('product', {owner: 'strongloop'}, function (err, models) {
if (err) {
console.error(err);
done(err);
} else {
models.forEach(function (m) {
// console.dir(m);
assert(m.tableName === 'PRODUCT');
assert(m.tableName === 'product');
});
done(null, models);
}
@ -178,29 +180,29 @@ describe('Discover model primary keys', function () {
});
describe('Discover model foreign keys', function () {
it('should return an array of foreign keys for INVENTORY', function (done) {
db.discoverForeignKeys('INVENTORY', function (err, models) {
it('should return an array of foreign keys for inventory', function (done) {
db.discoverForeignKeys('inventory', function (err, models) {
if (err) {
console.error(err);
done(err);
} else {
models.forEach(function (m) {
// console.dir(m);
assert(m.fkTableName === 'INVENTORY');
assert(m.fkTableName === 'inventory');
});
done(null, models);
}
});
});
it('should return an array of foreign keys for STRONGLOOP.INVENTORY', function (done) {
db.discoverForeignKeys('INVENTORY', {owner: 'STRONGLOOP'}, function (err, models) {
it('should return an array of foreign keys for strongloop.inventory', function (done) {
db.discoverForeignKeys('inventory', {owner: 'strongloop'}, function (err, models) {
if (err) {
console.error(err);
done(err);
} else {
models.forEach(function (m) {
// console.dir(m);
assert(m.fkTableName === 'INVENTORY');
assert(m.fkTableName === 'inventory');
});
done(null, models);
}
@ -209,50 +211,67 @@ describe('Discover model foreign keys', function () {
});
describe('Discover LDL schema from a table', function () {
it('should return an LDL schema for INVENTORY', function (done) {
db.discoverSchema('INVENTORY', {owner: 'STRONGLOOP'}, function (err, schema) {
// console.log('%j', schema);
assert(schema.name === 'Inventory');
assert(schema.options.mysql.schema === 'STRONGLOOP');
assert(schema.options.mysql.table === 'INVENTORY');
assert(schema.properties.productId);
assert(schema.properties.productId.required);
assert(schema.properties.productId.type === 'String');
assert(schema.properties.productId.mysql.columnName === 'PRODUCT_ID');
assert(schema.properties.locationId);
assert(schema.properties.locationId.type === 'String');
assert(schema.properties.locationId.mysql.columnName === 'LOCATION_ID');
assert(schema.properties.available);
assert(schema.properties.available.required === false);
assert(schema.properties.available.type === 'Number');
assert(schema.properties.total);
assert(schema.properties.total.type === 'Number');
done(null, schema);
var schema;
before(function (done) {
db.discoverSchema('inventory', {owner: 'strongloop'}, function (err, schema_) {
schema = schema_;
done(err);
});
});
it('should return an LDL schema for inventory', function () {
var productId = 'productId' in schema.properties ? 'productId' : 'productid';
var locationId = 'locationId' in schema.properties ? 'locationId' : 'locationid';
console.error('schema:', schema);
assert.strictEqual(schema.name, 'Inventory');
assert.ok(/strongloop/i.test(schema.options.mysql.schema));
assert.strictEqual(schema.options.mysql.table, 'inventory');
assert(schema.properties[productId]);
// TODO: schema shows this field is default NULL, which means it isn't required
// assert(schema.properties[productId].required);
assert.strictEqual(schema.properties[productId].type, 'String');
assert.strictEqual(schema.properties[productId].mysql.columnName, 'productId');
assert(schema.properties[locationId]);
assert.strictEqual(schema.properties[locationId].type, 'String');
assert.strictEqual(schema.properties[locationId].mysql.columnName, 'locationId');
assert(schema.properties.available);
assert.strictEqual(schema.properties.available.required, false);
assert.strictEqual(schema.properties.available.type, 'Number');
assert(schema.properties.total);
assert.strictEqual(schema.properties.total.type, 'Number');
});
});
describe('Discover and build models', function () {
it('should discover and build models', function (done) {
db.discoverAndBuildModels('INVENTORY', {owner: 'STRONGLOOP', visited: {}, associations: true}, function (err, models) {
assert(models.Inventory, 'Inventory model should be discovered and built');
var schema = models.Inventory.definition;
assert(schema.settings.mysql.schema === 'STRONGLOOP');
assert(schema.settings.mysql.table === 'INVENTORY');
assert(schema.properties.productId);
assert(schema.properties.productId.type === String);
assert(schema.properties.productId.mysql.columnName === 'PRODUCT_ID');
assert(schema.properties.locationId);
assert(schema.properties.locationId.type === String);
assert(schema.properties.locationId.mysql.columnName === 'LOCATION_ID');
assert(schema.properties.available);
assert(schema.properties.available.type === Number);
assert(schema.properties.total);
assert(schema.properties.total.type === Number);
models.Inventory.findOne(function (err, inv) {
assert(!err, 'error should not be reported');
done();
});
var models;
before(function (done) {
db.discoverAndBuildModels('inventory', {owner: 'strongloop', visited: {}, associations: true}, function (err, models_) {
models = models_;
done(err);
});
});
it('should discover and build models', function () {
assert(models.Inventory, 'Inventory model should be discovered and built');
var schema = models.Inventory.definition;
var productId = 'productId' in schema.properties ? 'productId' : 'productid';
var locationId = 'locationId' in schema.properties ? 'locationId' : 'locationid';
assert(/strongloop/i.test(schema.settings.mysql.schema));
assert.strictEqual(schema.settings.mysql.table, 'inventory');
assert(schema.properties[productId]);
assert.strictEqual(schema.properties[productId].type, String);
assert.strictEqual(schema.properties[productId].mysql.columnName, 'productId');
assert(schema.properties[locationId]);
assert.strictEqual(schema.properties[locationId].type, String);
assert.strictEqual(schema.properties[locationId].mysql.columnName, 'locationId');
assert(schema.properties.available);
assert.strictEqual(schema.properties.available.type, Number);
assert(schema.properties.total);
assert.strictEqual(schema.properties.total.type, Number);
});
it('should be able to find an instance', function (done) {
assert(models.Inventory, 'Inventory model must exist');
models.Inventory.findOne(function (err, inv) {
assert(!err, 'error should not be reported');
done();
});
});
});