fix (core) accepts boolean type

Signed-off-by: Mario Estrada <marioestradarosa@yahoo.com>

lib/mysql.js

@@ -435,7 +435,10 @@ MySQL.prototype.fromColumnValue = function(prop, val) {
         }
         break;
       case 'Boolean':
-        val = Boolean(val);
+        // BIT(1) case: <Buffer 01> for true and <Buffer 00> for false
+        // CHAR(1) case: '1' for true and '0' for false
+        // TINYINT(1) case: 1 for true and 0 for false
+        val = Buffer.isBuffer(val) && val.length === 1 ? Boolean(val[0]) : Boolean(parseInt(val));
         break;
       case 'GeoPoint':
       case 'Point':

test/booleantype.test.js

@@ -0,0 +1,144 @@
+// Copyright IBM Corp. 2013,2016. All Rights Reserved.
+// Node module: loopback-connector-mysql
+// This file is licensed under the MIT License.
+// License text available at https://opensource.org/licenses/MIT
+
+'use strict';
+require('./init.js');
+const assert = require('assert');
+
+let db;
+
+function sortByOrder(a, b) {
+  return a.order < b.order ? -1 : 1;
+}
+
+function createDefinition(dataType) {
+  return {
+    order: {
+      type: Number,
+    },
+    pass: {
+      type: Boolean,
+      mysql: {
+        dataType: dataType,
+      },
+    },
+  };
+}
+
+describe('Boolean type', function() {
+  const data = [
+    {
+      order: 0,
+      pass: true,
+    },
+    {
+      order: 1,
+      pass: false,
+    },
+  ];
+
+  function createAndTest(Model, done) {
+    Model.create(data, function(err, result) {
+      if (err) return done(err);
+      assert.strictEqual(result[0].pass, true);
+      assert.strictEqual(result[1].pass, false);
+
+      Model.find(function(err, queryResults) {
+        queryResults.sort(sortByOrder);
+        assert.strictEqual(queryResults[0].pass, true);
+        assert.strictEqual(queryResults[1].pass, false);
+        done();
+      });
+    });
+  }
+
+  describe('Support TINYINT(1)', function() {
+    const ModelDefinition = createDefinition('TINYINT(1)');
+    let BooleanModel_tiny;
+    before(function(done) {
+      db = global.getSchema();
+      BooleanModel_tiny = db.define('BooleanModel_tiny', ModelDefinition);
+      db.automigrate(['BooleanModel_tiny'], done);
+    });
+
+    after(function(done) {
+      BooleanModel_tiny.destroyAll(done);
+    });
+
+    it('Should work if mysql data type is TINYINT(1)', function(done) {
+      BooleanModel_tiny.create(data, function(err, result) {
+        if (err) return done(err);
+        assert.strictEqual(result[0].pass, true);
+        assert.strictEqual(result[1].pass, false);
+
+        BooleanModel_tiny.find(function(err, queryResults) {
+          queryResults.sort(sortByOrder);
+          assert.strictEqual(queryResults[0].pass, true);
+          assert.strictEqual(queryResults[1].pass, false);
+          done();
+        });
+      });
+    });
+  });
+
+  describe('Support CHAR(1)', function() {
+    const ModelDefinition = createDefinition('CHAR(1)');
+    let BooleanModel_char;
+    before(function(done) {
+      db = global.getSchema();
+      BooleanModel_char = db.define('BooleanModel_char', ModelDefinition);
+      db.automigrate(['BooleanModel_char'], done);
+    });
+
+    after(function(done) {
+      BooleanModel_char.destroyAll(done);
+    });
+
+    it('Should work if mysql data type is CHAR(1)', function(done) {
+      BooleanModel_char.create(data, function(err, result) {
+        if (err) return done(err);
+        assert.strictEqual(result[0].pass, true);
+        assert.strictEqual(result[1].pass, false);
+
+        BooleanModel_char.find(function(err, queryResults) {
+          queryResults.sort(sortByOrder);
+          assert.strictEqual(queryResults[0].pass, true);
+          assert.strictEqual(queryResults[1].pass, false);
+          done();
+        });
+      });
+    });
+  });
+
+  describe('Support BIT(1)', function() {
+    const ModelDefinition = createDefinition('BIT(1)');
+    let BooleanModel_bit;
+
+    before(function(done) {
+      db = global.getSchema();
+      BooleanModel_bit = db.define('BooleanModel_bit', ModelDefinition);
+      db.automigrate(['BooleanModel_bit'], done);
+    });
+
+    after(function(done) {
+      BooleanModel_bit.destroyAll(done);
+    });
+
+    it('Should work if mysql data type is BIT(1)', function(done) {
+      BooleanModel_bit.create(data, function(err, result) {
+        if (err) return done(err);
+        assert.strictEqual(result[0].pass, true);
+        assert.strictEqual(result[1].pass, false);
+
+        BooleanModel_bit.find(function(err, queryResults) {
+          queryResults.sort(sortByOrder);
+          assert.strictEqual(queryResults[0].pass, true);
+          assert.strictEqual(queryResults[1].pass, false);
+          done();
+        });
+      });
+    });
+  });
+});