From 1ee0c2f3bb27a17addae9765edd414ec2fd8b8aa Mon Sep 17 00:00:00 2001 From: Partap Davis Date: Mon, 2 Mar 2015 15:10:19 -0700 Subject: [PATCH 1/2] Query string length for schema in characters in addition to bytes --- lib/discovery.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/discovery.js b/lib/discovery.js index 46429b0..804314e 100644 --- a/lib/discovery.js +++ b/lib/discovery.js @@ -144,6 +144,7 @@ function mixinDiscovery(MySQL) { sql = paginateSQL('SELECT table_schema AS "owner",' + ' table_name AS "tableName", column_name AS "columnName",' + ' data_type AS "dataType",' + + ' character_maximum_length AS "length",' + ' character_octet_length AS "dataLength",' + ' numeric_precision AS "dataPrecision",' + ' numeric_scale AS "dataScale",' + @@ -156,6 +157,7 @@ function mixinDiscovery(MySQL) { sql = paginateSQL('SELECT table_schema AS "owner",' + ' table_name AS "tableName", column_name AS "columnName",' + ' data_type AS "dataType",' + + ' character_maximum_length AS "length",' + ' character_octet_length AS "dataLength",' + ' numeric_precision AS "dataPrecision",' + ' numeric_scale AS "dataScale",' + From 0964a2634a63ac8f14062f6fceb0bc1fc35a2d3b Mon Sep 17 00:00:00 2001 From: Partap Davis Date: Sat, 7 Mar 2015 20:09:10 -0700 Subject: [PATCH 2/2] replace dataLength instead of adding length property --- lib/discovery.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/discovery.js b/lib/discovery.js index 804314e..8e45e14 100644 --- a/lib/discovery.js +++ b/lib/discovery.js @@ -144,8 +144,7 @@ function mixinDiscovery(MySQL) { sql = paginateSQL('SELECT table_schema AS "owner",' + ' table_name AS "tableName", column_name AS "columnName",' + ' data_type AS "dataType",' + - ' character_maximum_length AS "length",' + - ' character_octet_length AS "dataLength",' + + ' character_maximum_length AS "dataLength",' + ' numeric_precision AS "dataPrecision",' + ' numeric_scale AS "dataScale",' + ' is_nullable = \'YES\' AS "nullable"' + @@ -157,8 +156,7 @@ function mixinDiscovery(MySQL) { sql = paginateSQL('SELECT table_schema AS "owner",' + ' table_name AS "tableName", column_name AS "columnName",' + ' data_type AS "dataType",' + - ' character_maximum_length AS "length",' + - ' character_octet_length AS "dataLength",' + + ' character_maximum_length AS "dataLength",' + ' numeric_precision AS "dataPrecision",' + ' numeric_scale AS "dataScale",' + ' is_nullable = \'YES\' AS "nullable"' +