Fix formatting

lib/remote-connector.js

@@ -17,7 +17,9 @@ module.exports = RemoteConnector;
  */
 
 function RemoteConnector(settings) {
-  assert(typeof settings === 'object', 'cannot initiaze RemoteConnector without a settings object');
+  assert(typeof settings ===
+    'object',
+    'cannot initiaze RemoteConnector without a settings object');
   this.client = settings.client;
   this.adapter = settings.adapter || 'rest';
   this.protocol = settings.protocol || 'http'
@@ -29,14 +31,15 @@ function RemoteConnector(settings) {
   // TODO(ritch) make sure this name works with Model.getSourceId()
   this.name = 'remote-connector';
 
-  if(settings.url) {
+  if (settings.url) {
     this.url = settings.url;
   } else {
     this.url = this.protocol + '://' + this.host + ':' + this.port + this.root;
   }
 
   // handle mixins in the define() method
-  var DAO = this.DataAccessObject = function() {};
+  var DAO = this.DataAccessObject = function() {
+  };
 }
 
 RemoteConnector.prototype.connect = function() {
@@ -44,7 +47,8 @@ RemoteConnector.prototype.connect = function() {
 }
 
 RemoteConnector.initialize = function(dataSource, callback) {
-  var connector = dataSource.connector = new RemoteConnector(dataSource.settings);
+  var connector = dataSource.connector =
+    new RemoteConnector(dataSource.settings);
   connector.connect();
   callback();
 }
@@ -54,18 +58,19 @@ RemoteConnector.prototype.define = function(definition) {
   var remotes = this.remotes;
   var SharedClass;
 
-  assert(Model.sharedClass, 'cannot attach ' + Model.modelName
-    + ' to a remote connector without a Model.sharedClass');
+  assert(Model.sharedClass,
+      'cannot attach ' +
+      Model.modelName +
+      ' to a remote connector without a Model.sharedClass');
 
   remotes.addClass(Model.sharedClass);
 
-  Model
-    .sharedClass
-    .methods()
-    .forEach(function(remoteMethod) {
+  Model.sharedClass.methods().forEach(function(remoteMethod) {
       // TODO(ritch) more elegant way of ignoring a nested shared class
-      if(remoteMethod.name !== 'Change'
-        && remoteMethod.name !== 'Checkpoint') {
+      if (remoteMethod.name !==
+        'Change' &&
+        remoteMethod.name !==
+        'Checkpoint') {
         createProxyMethod(Model, remotes, remoteMethod);
       }
     });
@@ -74,12 +79,12 @@ RemoteConnector.prototype.define = function(definition) {
 function createProxyMethod(Model, remotes, remoteMethod) {
   var scope = remoteMethod.isStatic ? Model : Model.prototype;
   var original = scope[remoteMethod.name];
-  
+
   scope[remoteMethod.name] = function remoteMethodProxy() {
     var args = Array.prototype.slice.call(arguments);
     var lastArgIsFunc = typeof args[args.length - 1] === 'function';
     var callback;
-    if(lastArgIsFunc) {
+    if (lastArgIsFunc) {
       callback = args.pop();
     }
 
@@ -87,4 +92,5 @@ function createProxyMethod(Model, remotes, remoteMethod) {
   }
 }
 
-function noop() {}
+function noop() {
+}

test/remote-connector.test.js

@@ -33,7 +33,8 @@ describe('RemoteConnector', function() {
     var test = this;
     remoteApp = this.remoteApp = loopback();
     remoteApp.use(loopback.rest());
-    var ServerModel = this.ServerModel = loopback.PersistedModel.extend('TestModel');
+    var ServerModel = this.ServerModel =
+      loopback.PersistedModel.extend('TestModel');
 
     remoteApp.model(ServerModel);
 
@@ -47,7 +48,7 @@ describe('RemoteConnector', function() {
     });
   });
 
-  it('should support the save method', function (done) {
+  it('should support the save method', function(done) {
     var calledServerCreate = false;
     var RemoteModel = loopback.PersistedModel.extend('TestModel');
     RemoteModel.attachTo(this.remote);

test/util/model-tests.js

@@ -10,240 +10,255 @@ var TaskEmitter = require('strong-task-emitter');
 
 module.exports = function defineModelTestsWithDataSource(options) {
 
-describe('Model Tests', function() {
+  describe('Model Tests', function() {
 
-  var User, dataSource;
+    var User, dataSource;
 
-  if(options.beforeEach) {
-    beforeEach(options.beforeEach);
-  }
-
-  beforeEach(function() {
-    var test = this;
-
-    // setup a model / datasource
-    dataSource = this.dataSource || loopback.createDataSource(options.dataSource);
-
-    var extend = PersistedModel.extend;
-
-    // create model hook
-    PersistedModel.extend = function() {
-      var extendedModel = extend.apply(PersistedModel, arguments);
-
-      if(options.onDefine) {
-        options.onDefine.call(test, extendedModel);
-      }
-
-      return extendedModel;
+    if (options.beforeEach) {
+      beforeEach(options.beforeEach);
     }
 
-    User = PersistedModel.extend('user', {
-      'first': String,
-      'last': String,
-      'age': Number,
-      'password': String,
-      'gender': String,
-      'domain': String,
-      'email': String
-    }, {
-      trackChanges: true
+    beforeEach(function() {
+      var test = this;
+
+      // setup a model / datasource
+      dataSource =
+        this.dataSource || loopback.createDataSource(options.dataSource);
+
+      var extend = PersistedModel.extend;
+
+      // create model hook
+      PersistedModel.extend = function() {
+        var extendedModel = extend.apply(PersistedModel, arguments);
+
+        if (options.onDefine) {
+          options.onDefine.call(test, extendedModel);
+        }
+
+        return extendedModel;
+      }
+
+      User = PersistedModel.extend('user', {
+        'first': String,
+        'last': String,
+        'age': Number,
+        'password': String,
+        'gender': String,
+        'domain': String,
+        'email': String
+      }, {
+        trackChanges: true
+      });
+
+      // enable destroy all for testing
+      User.destroyAll.shared = true;
+      User.attachTo(dataSource);
     });
 
-    // enable destroy all for testing
-    User.destroyAll.shared = true;
-    User.attachTo(dataSource);
-  });
-
-  describe('Model.validatesPresenceOf(properties...)', function() {
-    it("Require a model to include a property to be considered valid", function() {
-      User.validatesPresenceOf('first', 'last', 'age');
-      var joe = new User({first: 'joe'});
-      assert(joe.isValid() === false, 'model should not validate');
-      assert(joe.errors.last, 'should have a missing last error');
-      assert(joe.errors.age, 'should have a missing age error');
+    describe('Model.validatesPresenceOf(properties...)', function() {
+      it("Require a model to include a property to be considered valid",
+        function() {
+          User.validatesPresenceOf('first', 'last', 'age');
+          var joe = new User({first: 'joe'});
+          assert(joe.isValid() === false, 'model should not validate');
+          assert(joe.errors.last, 'should have a missing last error');
+          assert(joe.errors.age, 'should have a missing age error');
+        });
     });
-  });
 
-  describe('Model.validatesLengthOf(property, options)', function() {
-    it("Require a property length to be within a specified range", function() {
-      User.validatesLengthOf('password', {min: 5, message: {min: 'Password is too short'}});
-      var joe = new User({password: '1234'});
-      assert(joe.isValid() === false, 'model should not be valid');
-      assert(joe.errors.password, 'should have password error');
+    describe('Model.validatesLengthOf(property, options)', function() {
+      it("Require a property length to be within a specified range",
+        function() {
+          User.validatesLengthOf('password',
+            {min: 5, message: {min: 'Password is too short'}});
+          var joe = new User({password: '1234'});
+          assert(joe.isValid() === false, 'model should not be valid');
+          assert(joe.errors.password, 'should have password error');
+        });
     });
-  });
 
-  describe('Model.validatesInclusionOf(property, options)', function() {
-    it("Require a value for `property` to be in the specified array", function() {
-      User.validatesInclusionOf('gender', {in: ['male', 'female']});
-      var foo = new User({gender: 'bar'});
-      assert(foo.isValid() === false, 'model should not be valid');
-      assert(foo.errors.gender, 'should have gender error');
+    describe('Model.validatesInclusionOf(property, options)', function() {
+      it("Require a value for `property` to be in the specified array",
+        function() {
+          User.validatesInclusionOf('gender', {in: ['male', 'female']});
+          var foo = new User({gender: 'bar'});
+          assert(foo.isValid() === false, 'model should not be valid');
+          assert(foo.errors.gender, 'should have gender error');
+        });
     });
-  });
 
-  describe('Model.validatesExclusionOf(property, options)', function() {
-    it("Require a value for `property` to not exist in the specified array", function() {
-      User.validatesExclusionOf('domain', {in: ['www', 'billing', 'admin']});
-      var foo = new User({domain: 'www'});
-      var bar = new User({domain: 'billing'});
-      var bat = new User({domain: 'admin'});
-      assert(foo.isValid() ===  false);
-      assert(bar.isValid() === false);
-      assert(bat.isValid() === false);
-      assert(foo.errors.domain, 'model should have a domain error');
-      assert(bat.errors.domain, 'model should have a domain error');
-      assert(bat.errors.domain, 'model should have a domain error');
+    describe('Model.validatesExclusionOf(property, options)', function() {
+      it("Require a value for `property` to not exist in the specified array",
+        function() {
+          User.validatesExclusionOf('domain',
+            {in: ['www', 'billing', 'admin']});
+          var foo = new User({domain: 'www'});
+          var bar = new User({domain: 'billing'});
+          var bat = new User({domain: 'admin'});
+          assert(foo.isValid() === false);
+          assert(bar.isValid() === false);
+          assert(bat.isValid() === false);
+          assert(foo.errors.domain, 'model should have a domain error');
+          assert(bat.errors.domain, 'model should have a domain error');
+          assert(bat.errors.domain, 'model should have a domain error');
+        });
     });
-  });
 
-  describe('Model.validatesNumericalityOf(property, options)', function() {
-    it("Require a value for `property` to be a specific type of `Number`", function() {
-      User.validatesNumericalityOf('age', {int: true});
-      var joe = new User({age: 10.2});
-      assert(joe.isValid() === false);
-      var bob = new User({age: 0});
-      assert(bob.isValid() === true);
-      assert(joe.errors.age, 'model should have an age error');
+    describe('Model.validatesNumericalityOf(property, options)', function() {
+      it("Require a value for `property` to be a specific type of `Number`",
+        function() {
+          User.validatesNumericalityOf('age', {int: true});
+          var joe = new User({age: 10.2});
+          assert(joe.isValid() === false);
+          var bob = new User({age: 0});
+          assert(bob.isValid() === true);
+          assert(joe.errors.age, 'model should have an age error');
+        });
     });
-  });
 
-  describe('myModel.isValid()', function() {
-    it("Validate the model instance", function() {
-      User.validatesNumericalityOf('age', {int: true});
-      var user = new User({first: 'joe', age: 'flarg'})
-      var valid = user.isValid();
-      assert(valid === false);
-      assert(user.errors.age, 'model should have age error');
-    });
-    
-    it('Asynchronously validate the model', function(done) {
-      User.validatesNumericalityOf('age', {int: true});
-      var user = new User({first: 'joe', age: 'flarg'});
-      user.isValid(function (valid) {
+    describe('myModel.isValid()', function() {
+      it("Validate the model instance", function() {
+        User.validatesNumericalityOf('age', {int: true});
+        var user = new User({first: 'joe', age: 'flarg'})
+        var valid = user.isValid();
         assert(valid === false);
         assert(user.errors.age, 'model should have age error');
-        done();
       });
-    });
-  });
 
-  describe('Model.create([data], [callback])', function() {
-    it("Create an instance of Model with given data and save to the attached data source", function(done) {
-      User.create({first: 'Joe', last: 'Bob'}, function(err, user) {
-        assert(user instanceof User);
-        done();
-      });
-    });
-  });
-
-  describe('model.save([options], [callback])', function() {
-    it("Save an instance of a Model to the attached data source", function(done) {
-      var joe = new User({first: 'Joe', last: 'Bob'});
-      joe.save(function(err, user) {
-        assert(user.id);
-        assert(!err);
-        assert(!user.errors);
-        done();
-      });
-    });
-  });
-
-  describe('model.updateAttributes(data, [callback])', function() {
-    it("Save specified attributes to the attached data source", function(done) {
-      User.create({first: 'joe', age: 100}, function (err, user) {
-        assert(!err);
-        assert.equal(user.first, 'joe');
-        
-        user.updateAttributes({
-          first: 'updatedFirst',
-          last: 'updatedLast'
-        }, function (err, updatedUser) {
-          assert(!err);
-          assert.equal(updatedUser.first, 'updatedFirst');
-          assert.equal(updatedUser.last, 'updatedLast');
-          assert.equal(updatedUser.age, 100);
+      it('Asynchronously validate the model', function(done) {
+        User.validatesNumericalityOf('age', {int: true});
+        var user = new User({first: 'joe', age: 'flarg'});
+        user.isValid(function(valid) {
+          assert(valid === false);
+          assert(user.errors.age, 'model should have age error');
           done();
         });
       });
     });
-  });
 
-  describe('Model.upsert(data, callback)', function() {
-    it("Update when record with id=data.id found, insert otherwise", function(done) {
-      User.upsert({first: 'joe', id: 7}, function (err, user) {
-        assert(!err);
-        assert.equal(user.first, 'joe');
-        
-        User.upsert({first: 'bob', id: 7}, function (err, updatedUser) {
-          assert(!err);
-          assert.equal(updatedUser.first, 'bob');
-          done();
+    describe('Model.create([data], [callback])', function() {
+      it("Create an instance of Model with given data and save to the attached data source",
+        function(done) {
+          User.create({first: 'Joe', last: 'Bob'}, function(err, user) {
+            assert(user instanceof User);
+            done();
+          });
         });
-      });
     });
-  });
 
-  describe('model.destroy([callback])', function() {
-    it("Remove a model from the attached data source", function(done) {
-      User.create({first: 'joe', last: 'bob'}, function (err, user) {
-        User.findById(user.id, function (err, foundUser) {
-          assert.equal(user.id, foundUser.id);
-          foundUser.destroy(function () {
-            User.findById(user.id, function (err, notFound) {
-              assert.equal(notFound, null);
+    describe('model.save([options], [callback])', function() {
+      it("Save an instance of a Model to the attached data source",
+        function(done) {
+          var joe = new User({first: 'Joe', last: 'Bob'});
+          joe.save(function(err, user) {
+            assert(user.id);
+            assert(!err);
+            assert(!user.errors);
+            done();
+          });
+        });
+    });
+
+    describe('model.updateAttributes(data, [callback])', function() {
+      it("Save specified attributes to the attached data source",
+        function(done) {
+          User.create({first: 'joe', age: 100}, function(err, user) {
+            assert(!err);
+            assert.equal(user.first, 'joe');
+
+            user.updateAttributes({
+              first: 'updatedFirst',
+              last: 'updatedLast'
+            }, function(err, updatedUser) {
+              assert(!err);
+              assert.equal(updatedUser.first, 'updatedFirst');
+              assert.equal(updatedUser.last, 'updatedLast');
+              assert.equal(updatedUser.age, 100);
               done();
             });
           });
         });
+    });
+
+    describe('Model.upsert(data, callback)', function() {
+      it("Update when record with id=data.id found, insert otherwise",
+        function(done) {
+          User.upsert({first: 'joe', id: 7}, function(err, user) {
+            assert(!err);
+            assert.equal(user.first, 'joe');
+
+            User.upsert({first: 'bob', id: 7}, function(err, updatedUser) {
+              assert(!err);
+              assert.equal(updatedUser.first, 'bob');
+              done();
+            });
+          });
+        });
+    });
+
+    describe('model.destroy([callback])', function() {
+      it("Remove a model from the attached data source", function(done) {
+        User.create({first: 'joe', last: 'bob'}, function(err, user) {
+          User.findById(user.id, function(err, foundUser) {
+            assert.equal(user.id, foundUser.id);
+            foundUser.destroy(function() {
+              User.findById(user.id, function(err, notFound) {
+                assert.equal(notFound, null);
+                done();
+              });
+            });
+          });
+        });
       });
     });
-  });
 
-  describe('Model.deleteById(id, [callback])', function () {
-      it("Delete a model instance from the attached data source", function (done) {
-          User.create({first: 'joe', last: 'bob'}, function (err, user) {
-              User.deleteById(user.id, function (err) {
-                  User.findById(user.id, function (err, notFound) {
-                    assert.equal(notFound, null);
-                    done();
-                  });
+    describe('Model.deleteById(id, [callback])', function() {
+      it("Delete a model instance from the attached data source",
+        function(done) {
+          User.create({first: 'joe', last: 'bob'}, function(err, user) {
+            User.deleteById(user.id, function(err) {
+              User.findById(user.id, function(err, notFound) {
+                assert.equal(notFound, null);
+                done();
               });
+            });
           });
-      });
-  });
-
-  describe('Model.findById(id, callback)', function() {
-    it("Find an instance by id", function(done) {
-      User.create({first: 'michael', last: 'jordan', id: 23}, function () {
-        User.findById(23, function (err, user) {
-          assert.equal(user.id, 23);
-          assert.equal(user.first, 'michael');
-          assert.equal(user.last, 'jordan');
-          done();
         });
-      });
     });
-  });
 
-  describe('Model.count([query], callback)', function() {
-    it("Query count of Model instances in data source", function(done) {
-      (new TaskEmitter())
-        .task(User, 'create', {first: 'jill', age: 100})
-        .task(User, 'create', {first: 'bob', age: 200})
-        .task(User, 'create', {first: 'jan'})
-        .task(User, 'create', {first: 'sam'})
-        .task(User, 'create', {first: 'suzy'})
-        .on('done', function () {
-          User.count({age: {gt: 99}}, function (err, count) {
-            assert.equal(count, 2);
+    describe('Model.findById(id, callback)', function() {
+      it("Find an instance by id", function(done) {
+        User.create({first: 'michael', last: 'jordan', id: 23}, function() {
+          User.findById(23, function(err, user) {
+            assert.equal(user.id, 23);
+            assert.equal(user.first, 'michael');
+            assert.equal(user.last, 'jordan');
             done();
           });
         });
+      });
     });
-  });
 
-});
+    describe('Model.count([query], callback)', function() {
+      it("Query count of Model instances in data source", function(done) {
+        (new TaskEmitter()).task(User,
+          'create',
+          {first: 'jill', age: 100}).task(User,
+          'create',
+          {first: 'bob', age: 200}).task(User,
+          'create',
+          {first: 'jan'}).task(User, 'create', {first: 'sam'}).task(User,
+          'create',
+          {first: 'suzy'}).on('done', function() {
+            User.count({age: {gt: 99}}, function(err, count) {
+              assert.equal(count, 2);
+              done();
+            });
+          });
+      });
+    });
+
+  });
 
 
 }