From caebbf47ff14790873436ad6d6a60f6b71691a13 Mon Sep 17 00:00:00 2001 From: Ryan Graham <ryan@strongloop.com> Date: Wed, 1 Oct 2014 18:07:22 -0700 Subject: [PATCH 1/3] Update contribution guidelines Replace commit signing process with https://cla.strongloop.com/ --- CONTRIBUTING.md | 55 ++++++------------------------------------------- 1 file changed, 6 insertions(+), 49 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 80b5737..276cead 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,65 +1,24 @@ - ### Contributing ### Thank you for your interest in `loopback-connector-remote`, an open source project administered by StrongLoop. -Contributing to loopback is easy. In a few simple steps: +Contributing to `loopback-connector-remote` is easy. In a few simple steps: - * Ensure that your effort is aligned with the project’s roadmap by + * Ensure that your effort is aligned with the project's roadmap by talking to the maintainers, especially if you are going to spend a - lot of time on it. This project is currently maintained by - [@ritch](https://github.com/ritch), [@raymondfeng](https://github.com/raymondfeng), - and [@bajtos](https://github.com/bajtos). The preferred channel of communication - is [LoopBack Forum](https://groups.google.com/forum/#!forum/loopbackjs) or - [Github Issues](https://github.com/strongloop/loopback/issues). + lot of time on it. * Make something better or fix a bug. - * Adhere to code style outlined in the + * Adhere to code style outlined in the [Google C++ Style Guide][] and [Google Javascript Style Guide][]. - * [Sign your patches](#signing-patches) to indicate that your are - making your contribution available under the terms of the - [Contributor License Agreement](#contributor-license-agreement). + * Sign the [Contributor License Agreement](https://cla.strongloop.com/strongloop/loopback-connector-remote) * Submit a pull request through Github. -### Signing patches ### - -Like many open source projects, we need a contributor license agreement -from you before we can merge in your changes. - -In summary, by submitting your code, you are granting us a right to use -that code under the terms of this Agreement, including providing it to -others. You are also certifying that you wrote it, and that you are -allowed to license it to us. You are not giving up your copyright in -your work. The license does not change your rights to use your own -contributions for any other purpose. - -Contributor License Agreements are important because they define the -chain of ownership of a piece of software. Some companies won't allow -the use of free software without clear agreements around code ownership. -That's why many open source projects collect similar agreements from -contributors. The CLA here is based on the Apache CLA. - -To signify your agreement to these terms, add the following line to the -bottom of your commit message. Use your real name and an actual e-mail -address. - -``` -Signed-off-by: Random J Developer <random@developer.example.org> -``` - -Alternatively you can use the git command line to automatically add this -line, as follows: - -``` -$ git commit -sm "Replace rainbows by unicorns" -``` - - ### Contributor License Agreement ### ``` @@ -188,7 +147,5 @@ $ git commit -sm "Replace rainbows by unicorns" inaccurate in any respect. Email us at callback@strongloop.com. ``` - +[Google C++ Style Guide]: https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml [Google Javascript Style Guide]: https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml -[license]: LICENSE - From 61a4dd939f79221d95b2963286d23330624f9351 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miroslav=20Bajto=C5=A1?= <miroslav@strongloop.com> Date: Fri, 10 Oct 2014 10:29:23 +0200 Subject: [PATCH 2/3] Fix support for browsers Use `process.nextTick` instead of `setImmediate`, as the latter is not a standard API. https://developer.mozilla.org/en-US/docs/Web/API/Window.setImmediate --- lib/remote-connector.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/remote-connector.js b/lib/remote-connector.js index 118d637..e351932 100644 --- a/lib/remote-connector.js +++ b/lib/remote-connector.js @@ -49,7 +49,7 @@ RemoteConnector.initialize = function(dataSource, callback) { var connector = dataSource.connector = new RemoteConnector(dataSource.settings); connector.connect(); - setImmediate(callback); + process.nextTick(callback); }; RemoteConnector.prototype.define = function(definition) { From e39772c5adfbd53c8dea72ba8a7accb14bb043f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miroslav=20Bajto=C5=A1?= <miroslav@strongloop.com> Date: Fri, 10 Oct 2014 19:57:26 +0200 Subject: [PATCH 3/3] 1.0.2 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index e3207ab..4d41c19 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "loopback-connector-remote", - "version": "1.0.1", + "version": "1.0.2", "description": "Remote REST API connector for Loopback", "main": "index.js", "keywords": [