verdnatura-mirror
/
loopback-datasource-juggler
mirror of https://github.com/loopbackio/loopback-datasource-juggler
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add code review fixups

This commit is contained in:
Simon Ho 2016-09-22 16:13:11 -07:00
parent 5636c15903
commit 06d4b90071
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
test/manipulation.test.js
View File

@ -1675,7 +1675,7 @@ describe('manipulation', function() {
db.automigrate('CustomModel5', done); db.automigrate('CustomModel5', done);
}); });
it('should generate a new id when "defaultFn" is "uuid"', function(done) { it('should generate a new id when "defaultfn" is "uuid"', function(done) {
var inst = CustomModel.create(function(err, m) { var inst = CustomModel.create(function(err, m) {
should.not.exists(err); should.not.exists(err);
m.guid.should.match(UUID_REGEXP); m.guid.should.match(UUID_REGEXP);
@ -1694,7 +1694,7 @@ describe('manipulation', function() {
db.automigrate('CustomModel5', done); db.automigrate('CustomModel5', done);
}); });
it('should generate a new id when "defaultFn" is "uuidv4"', function(done) { it('should generate a new id when "defaultfn" is "uuidv4"', function(done) {
var inst = CustomModel.create(function(err, m) { var inst = CustomModel.create(function(err, m) {
should.not.exists(err); should.not.exists(err);
m.guid.should.match(UUID_REGEXP); m.guid.should.match(UUID_REGEXP);
@ -1704,24 +1704,24 @@ describe('manipulation', function() {
}); });
describe('shortid defaultFn', function() { describe('shortid defaultFn', function() {
var ModelWithShortid; var ModelWithShortId;
before(createModelWithShortId);
before(function(done) {
ModelWithShortid = db.define('ModelWithShortid', {
shortid: {type: String, defaultFn: 'shortid'},
});
db.automigrate('ModelWithShortid', done);
});
it('should generate a new id when "defaultFn" is "shortid"', function(done) { it('should generate a new id when "defaultFn" is "shortid"', function(done) {
var SHORTID_REGEXP = /^[0-9a-z_\-]{7,14}$/i; var SHORTID_REGEXP = /^[0-9a-z_\-]{7,14}$/i;
ModelWithShortId.create(function(err, modelWithShortId) {
ModelWithShortid.create(function(err, modelWithShortid) {
if (err) return done(err); if (err) return done(err);
modelWithShortid.shortid.should.match(SHORTID_REGEXP); modelWithShortId.shortid.should.match(SHORTID_REGEXP);
done(); done();
}); });
}); });
function createModelWithShortId(cb) {
ModelWithShortId = db.define('ModelWithShortId', {
shortid: {type: String, defaultFn: 'shortid'},
});
db.automigrate('ModelWithShortId', cb);
}
}); });
// it('should work when constructor called as function', function() { // it('should work when constructor called as function', function() {