From 9bc79d236697ab29303ed7272ec969b4dacc2708 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miroslav=20Bajto=C5=A1?= <miroslav@strongloop.com>
Date: Tue, 5 May 2015 08:24:08 +0200
Subject: [PATCH] dao: support validateUpsert:false

 - validateUpsert:true reports validation errors back to the callback
 - validateUpsert:false does not call `isValid()` at all
 - any other value report validation errors via `console.warn`
---
 lib/dao.js               | 32 +++++++++++++++++++-------------
 test/validations.test.js | 17 ++++++++++++++++-
 2 files changed, 35 insertions(+), 14 deletions(-)

diff --git a/lib/dao.js b/lib/dao.js
index af85a224..9bbaaf55 100644
--- a/lib/dao.js
+++ b/lib/dao.js
@@ -403,22 +403,28 @@ DataAccessObject.updateOrCreate = DataAccessObject.upsert = function upsert(data
         Model.applyProperties(update, inst);
         Model = Model.lookupModel(update);
 
-        inst.isValid(function(valid) {
-          if (!valid) {
-            // TODO(bajtos) Remove validateUpsert option in v3.0
-            if (Model.settings.validateUpsert) {
-              return cb(new ValidationError(inst), inst);
-            } else {
-              console.warn('Ignoring validation errors in updateOrCreate():');
-              console.warn('  %s', new ValidationError(inst).message);
-              // continue with updateOrCreate
-            }
-          }
-
+        if (Model.settings.validateUpsert === false) {
           update = removeUndefined(update);
           self.getDataSource().connector
             .updateOrCreate(Model.modelName, update, done);
-        }, update);
+        } else {
+          inst.isValid(function(valid) {
+            if (!valid) {
+              if (Model.settings.validateUpsert) {
+                return cb(new ValidationError(inst), inst);
+              } else {
+                // TODO(bajtos) Remove validateUpsert:undefined in v3.0
+                console.warn('Ignoring validation errors in updateOrCreate():');
+                console.warn('  %s', new ValidationError(inst).message);
+                // continue with updateOrCreate
+              }
+            }
+
+            update = removeUndefined(update);
+            self.getDataSource().connector
+              .updateOrCreate(Model.modelName, update, done);
+          }, update);
+        }
 
         function done(err, data, info) {
           var obj;
diff --git a/test/validations.test.js b/test/validations.test.js
index 446586f7..d0e59f40 100644
--- a/test/validations.test.js
+++ b/test/validations.test.js
@@ -184,7 +184,7 @@ describe('validations', function () {
         });
       });
 
-      it('should be skipped on upsert by default', function(done) {
+      it('should ignore errors on upsert by default', function(done) {
         delete User.validations;
         User.validatesPresenceOf('name');
         // It's important to pass an id value, otherwise DAO falls back
@@ -192,6 +192,21 @@ describe('validations', function () {
         User.updateOrCreate({ id: 999 }, done);
       });
 
+      it('should be skipped by upsert when disabled via settings', function(done) {
+        var Customer = User.extend('Customer');
+        Customer.attachTo(db);
+        db.autoupdate(function(err) {
+          if (err) return done(err);
+          Customer.prototype.isValid = function() {
+            throw new Error('isValid() should not be called at all');
+          };
+          Customer.settings.validateUpsert = false;
+          // It's important to pass an id value, otherwise DAO falls back
+          // to regular create()
+          Customer.updateOrCreate({ id: 999 }, done);
+        });
+      });
+
       it('should work on upsert when enabled via settings', function(done) {
         delete User.validations;
         User.validatesPresenceOf('name');