From bf592413e12472bff295cc77cf474b0d7b7a790f Mon Sep 17 00:00:00 2001
From: Raymond Feng <raymond@strongloop.com>
Date: Fri, 13 Dec 2013 16:45:31 -0800
Subject: [PATCH] Dedupe the alias methods during mixin

To prevent the same method from showing up multiple times in API explorer,
for example, Model.deleteById, Model.removeById
---
 lib/jutil.js             | 22 +++++++++++++++++-----
 test/loopback-dl.test.js |  6 ++++++
 2 files changed, 23 insertions(+), 5 deletions(-)

diff --git a/lib/jutil.js b/lib/jutil.js
index 6daa1134..33d81ea7 100644
--- a/lib/jutil.js
+++ b/lib/jutil.js
@@ -55,11 +55,12 @@ exports.mixin = function (newClass, mixinClass, options) {
     }
 
     if (options.staticProperties) {
-        Object.keys(mixinClass).forEach(function (classProp) {
+      var staticProxies = [];
+      Object.keys(mixinClass).forEach(function (classProp) {
             if (classProp !== 'super_' && classProp !== '_mixins' && (!newClass.hasOwnProperty(classProp) || options.override)) {
                 var pd = Object.getOwnPropertyDescriptor(mixinClass, classProp);
                 if(options.proxyFunctions && pd.writable && typeof pd.value === 'function') {
-                  pd.value = exports.proxy(pd.value);
+                  pd.value = exports.proxy(pd.value, staticProxies);
                 }
                 Object.defineProperty(newClass, classProp, pd);
             }
@@ -68,11 +69,12 @@ exports.mixin = function (newClass, mixinClass, options) {
 
     if (options.instanceProperties) {
         if (mixinClass.prototype) {
-            Object.keys(mixinClass.prototype).forEach(function (instanceProp) {
+          var instanceProxies = [];
+          Object.keys(mixinClass.prototype).forEach(function (instanceProp) {
                 if (!newClass.prototype.hasOwnProperty(instanceProp) || options.override) {
                     var pd = Object.getOwnPropertyDescriptor(mixinClass.prototype, instanceProp);
                     if(options.proxyFunctions && pd.writable && typeof pd.value === 'function') {
-                      pd.value = exports.proxy(pd.value);
+                      pd.value = exports.proxy(pd.value, instanceProxies);
                     }
                     Object.defineProperty(newClass.prototype, instanceProp, pd);
                 }
@@ -83,10 +85,20 @@ exports.mixin = function (newClass, mixinClass, options) {
     return newClass;
 };
 
-exports.proxy = function(fn) {
+exports.proxy = function(fn, proxies) {
+  // Make sure same methods referenced by different properties have the same proxy
+  // For example, deleteById is an alias of removeById
+  proxies = proxies || [];
+  for(var i = 0; i<proxies.length; i++) {
+    if(proxies[i]._delegate === fn) {
+      return proxies[i];
+    }
+  }
   var f = function() {
     return fn.apply(this, arguments);
   };
+  f._delegate = fn;
+  proxies.push(f);
   Object.keys(fn).forEach(function(x) {
     f[x] = fn[x];
   });
diff --git a/test/loopback-dl.test.js b/test/loopback-dl.test.js
index a000e8de..f324b97d 100644
--- a/test/loopback-dl.test.js
+++ b/test/loopback-dl.test.js
@@ -868,6 +868,12 @@ describe('Injected methods from connectors', function(){
     assert.equal(m1.shared, true, 'M1.save is now remotable');
     assert.equal(!!m2.shared, false, 'M2.save is not remotable');
 
+    assert.equal(M1.deleteById, M1.removeById,
+      'Same methods on the same model should have the same proxy');
+
+    assert.notEqual(M1.deleteById, M2.deleteById,
+      'Same methods on differnt models should have different proxies');
+
   });
 
 });