verdnatura-mirror
/
loopback-datasource-juggler
mirror of https://github.com/loopbackio/loopback-datasource-juggler
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

afterDestroy not called on adapter error 

Similar to afterCreate and afterUpdate, we don't want to run the afterXXXX handlers if the delete failed according to the adapter.
This commit is contained in:
Scott Nonnenberg 2013-03-30 17:18:47 -07:00
parent 13ac3cf088
commit 2ba862f5af
2 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/model.js
View File

@ -721,8 +721,12 @@ AbstractClass.prototype.destroy = function (cb) {
this.trigger('destroy', function (destroyed) {
this._adapter().destroy(this.constructor.modelName, this.id, function (err) {
if (err) {
return cb(err);
}
destroyed(function () {
if(cb) cb(err);
if(cb) cb();
});
}.bind(this));
});

16
test/hooks.test.js
View File

@ -221,6 +221,22 @@ describe('hooks', function() {
user.destroy();
});
});
it('afterDestroy should not be triggered on failed destroy', function(done) {
var old = User.schema.adapter.destroy;
User.schema.adapter.destroy = function(modelName, id, cb) {
cb(new Error('error'));
}
User.afterDestroy = function() {
throw new Error('shouldn\'t be called')
};
User.create(function (err, user) {
user.destroy(function(err) {
User.schema.adapter.destroy = old;
done();
});
});
});
});
describe('lifecycle', function() {