diff --git a/test/common_test.js b/test/common_test.js index 6f759aa2..5356b81c 100644 --- a/test/common_test.js +++ b/test/common_test.js @@ -59,6 +59,7 @@ function performTestFor(schemaName) { } function testOrm(schema) { + var requestsAreCounted = schema.name !== 'mongodb'; var Post, User, Passport; var start = Date.now(); @@ -449,50 +450,75 @@ function testOrm(schema) { }); + if (schema.name !== 'mongodb') + it('hasMany should support additional conditions', function (test) { + // Finding one post with an existing author associated + Post.findOne({order: 'userId DESC'}, function (err, post) { + // We could get the user with belongs to relationship but it is better if there is no interactions. + User.find(post.userId, function(err, user) { + user.posts({where: {id: post.id}}, function(err, posts) { + test.equal(posts.length, 1, 'There should be only 1 post.'); + test.done(); + }); + }); + }); + }); + + it('hasMany should be cached', function (test) { - User.find(1, function(err, user) { - User.create(function(err, voidUser) { - Post.create({userId: user.id}, function() { + // Finding one post with an existing author associated + Post.findOne({order: 'userId DESC'}, function (err, post) { + // We could get the user with belongs to relationship but it is better if there is no interactions. + User.find(post.userId, function(err, user) { + User.create(function(err, voidUser) { + Post.create({userId: user.id}, function() { - // There can't be any concurrency because we are counting requests - // We are first testing cases when user has posts - user.posts(function(err, data) { - var nbInitialRequests = nbSchemaRequests; - user.posts(function(err, data2) { - test.equal(data.length, 2, 'There should be 2 posts.'); - test.equal(data.length, data2.length, 'Posts should be the same, since we are loading on the same object.'); - test.equal(nbInitialRequests, nbSchemaRequests, 'There should not be any request because value is cached.'); + // There can't be any concurrency because we are counting requests + // We are first testing cases when user has posts + user.posts(function(err, data) { + var nbInitialRequests = nbSchemaRequests; + user.posts(function(err, data2) { + test.equal(data.length, 2, 'There should be 2 posts.'); + test.equal(data.length, data2.length, 'Posts should be the same, since we are loading on the same object.'); + requestsAreCounted && test.equal(nbInitialRequests, nbSchemaRequests, 'There should not be any request because value is cached.'); - user.posts({where: {id: data[0].id}}, function(err, data) { - test.equal(data.length, 1, 'There should be only one post.'); - test.equal(nbInitialRequests + 1, nbSchemaRequests, 'There should be one additional request since we added conditions.'); + if (schema.name === 'mongodb') { // for the moment mongodb doesn\'t support additional conditions on hasMany relations (see above) + test.done(); + } else { + user.posts({where: {id: data[0].id}}, function(err, data) { + console.log('data2', data); + test.equal(data.length, 1, 'There should be only one post.'); + requestsAreCounted && test.equal(nbInitialRequests + 1, nbSchemaRequests, 'There should be one additional request since we added conditions.'); - user.posts(function(err, data) { - test.equal(data.length, 2, 'Previous get shouldn\'t have changed cached value though, since there was additional conditions.'); - test.equal(nbInitialRequests + 1, nbSchemaRequests, 'There should not be any request because value is cached.'); + user.posts(function(err, data) { + test.equal(data.length, 2, 'Previous get shouldn\'t have changed cached value though, since there was additional conditions.'); + requestsAreCounted && test.equal(nbInitialRequests + 1, nbSchemaRequests, 'There should not be any request because value is cached.'); - // We are now testing cases when user doesn't have any post - voidUser.posts(function(err, data) { - var nbInitialRequests = nbSchemaRequests; - voidUser.posts(function(err, data2) { - test.equal(data.length, 0, 'There shouldn\'t be any posts (1/2).'); - test.equal(data2.length, 0, 'There shouldn\'t be any posts (2/2).'); - test.equal(nbInitialRequests, nbSchemaRequests, 'There should not be any request because value is cached.'); + // We are now testing cases when user doesn't have any post + voidUser.posts(function(err, data) { + var nbInitialRequests = nbSchemaRequests; + voidUser.posts(function(err, data2) { + test.equal(data.length, 0, 'There shouldn\'t be any posts (1/2).'); + test.equal(data2.length, 0, 'There shouldn\'t be any posts (2/2).'); + requestsAreCounted && test.equal(nbInitialRequests, nbSchemaRequests, 'There should not be any request because value is cached.'); - voidUser.posts(true, function(err, data3) { - test.equal(data3.length, 0, 'There shouldn\'t be any posts.'); - test.equal(nbInitialRequests + 1, nbSchemaRequests, 'There should be one additional request since we forced refresh.'); + voidUser.posts(true, function(err, data3) { + test.equal(data3.length, 0, 'There shouldn\'t be any posts.'); + requestsAreCounted && test.equal(nbInitialRequests + 1, nbSchemaRequests, 'There should be one additional request since we forced refresh.'); - test.done(); + test.done(); + }); + }); }); + }); }); + } - }); }); }); - }); + }); }); }); }); @@ -947,7 +973,7 @@ function testOrm(schema) { var nbInitialRequests = nbSchemaRequests; passport.owner(function(err, data2) { test.equal(data.id, data2.id, 'The value should remain the same'); - test.equal(nbInitialRequests, nbSchemaRequests, 'There should not be any request because value is cached.'); + requestsAreCounted && test.equal(nbInitialRequests, nbSchemaRequests, 'There should not be any request because value is cached.'); // We are now testing cases when passport has not an owner passport2.owner(function(err, data) { @@ -955,16 +981,16 @@ function testOrm(schema) { passport2.owner(function(err, data2) { test.equal(data, null, 'The value should be null since there is no owner'); test.equal(data, data2, 'The value should remain the same (null)'); - test.equal(nbInitialRequests2, nbSchemaRequests, 'There should not be any request because value is cached.'); + requestsAreCounted && test.equal(nbInitialRequests2, nbSchemaRequests, 'There should not be any request because value is cached.'); passport2.owner(user.id); passport2.owner(function(err, data3) { test.equal(data3.id, user.id, 'Owner should now be the user.'); - test.equal(nbInitialRequests2 + 1, nbSchemaRequests, 'If we changed owner id, there should be one more request.'); + requestsAreCounted && test.equal(nbInitialRequests2 + 1, nbSchemaRequests, 'If we changed owner id, there should be one more request.'); passport2.owner(true, function(err, data4) { test.equal(data3.id, data3.id, 'The value should remain the same'); - test.equal(nbInitialRequests2 + 2, nbSchemaRequests, 'If we forced refreshing, there should be one more request.'); + requestsAreCounted && test.equal(nbInitialRequests2 + 2, nbSchemaRequests, 'If we forced refreshing, there should be one more request.'); test.done(); }); });