From 211f8a9ade58c3e4f2ca6aa7724a7e20c98a44c6 Mon Sep 17 00:00:00 2001 From: Raymond Feng Date: Tue, 10 Sep 2013 12:19:20 -0700 Subject: [PATCH 1/4] Finalize package.json for sls-1.0.0 --- package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index d9465a7d..20fec755 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "loopback-datasource-juggler", - "description": "ORM for every database: redis, mysql, neo4j, mongodb, couchdb, postgres, sqlite", + "description": "LoopBack datasoure juggler", "version": "1.0.0", "repository": { "type": "git", @@ -20,7 +20,7 @@ "devDependencies": { "blanket": "~1.1.5", "should": "~1.2.2", - "mocha": "~1.8.2" + "mocha": "~1.12.1" }, "dependencies": { "async": "~0.2.9", @@ -28,4 +28,4 @@ "traverse": "~0.6.5" }, "license": "MIT" -} \ No newline at end of file +} From 63ce9911cbeb224dc63675907ca04d8bdd1c8138 Mon Sep 17 00:00:00 2001 From: Raymond Feng Date: Wed, 11 Sep 2013 10:46:09 -0700 Subject: [PATCH 2/4] Add keywords to package.json --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 20fec755..81c3b74b 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,8 @@ { "name": "loopback-datasource-juggler", - "description": "LoopBack datasoure juggler", "version": "1.0.0", + "description": "LoopBack DataSoure Juggler", + "keywords": [ "StrongLoop", "LoopBack", "DataSource", "Juggler", "ORM" ], "repository": { "type": "git", "url": "https://github.com/strongloop/loopback-datasource-juggler" From 31b03e7a724723a31ac6986522a6d7fc559f606c Mon Sep 17 00:00:00 2001 From: Raymond Feng Date: Wed, 11 Sep 2013 15:37:10 -0700 Subject: [PATCH 3/4] Set up assets to support embedded diagrams --- README.md | 2 +- docs.json | 6 +++++- overview.png => docs/overview.png | Bin 3 files changed, 6 insertions(+), 2 deletions(-) rename overview.png => docs/overview.png (100%) diff --git a/README.md b/README.md index 4d7a1974..44bedb96 100644 --- a/README.md +++ b/README.md @@ -11,7 +11,7 @@ LoopBack DataSource Juggler consists of the following components: * DataSource * Connector -![loopback-datasource-juggler-overview](overview.png "LoopBack Diagram") +![loopback-datasource-juggler-overview](docs/overview.png "LoopBack Diagram") ## LoopBack Definition Language diff --git a/docs.json b/docs.json index 1830717e..01a9ed58 100644 --- a/docs.json +++ b/docs.json @@ -39,6 +39,10 @@ "docs/definition-language.md", "docs/datasource-connector.md" ], - "codeSectionDepth": 4 + "codeSectionDepth": 4, + "assets": { + "/": "/docs", + "/docs": "/docs" + } } diff --git a/overview.png b/docs/overview.png similarity index 100% rename from overview.png rename to docs/overview.png From bf223320ea8b16119a2ec162e88e8dd1298848c1 Mon Sep 17 00:00:00 2001 From: Raymond Feng Date: Thu, 12 Sep 2013 13:31:21 -0700 Subject: [PATCH 4/4] Allow connector to report failure during initialization --- lib/datasource.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/datasource.js b/lib/datasource.js index 2d7215fb..027eb866 100644 --- a/lib/datasource.js +++ b/lib/datasource.js @@ -220,7 +220,7 @@ DataSource.prototype.setup = function(name, settings) { } if (connector) { - var postInit = function postInit() { + var postInit = function postInit(err, result) { this._setupConnector(); // we have an connector now? @@ -228,8 +228,10 @@ DataSource.prototype.setup = function(name, settings) { throw new Error('Connector is not defined correctly: it should create `connector` member of dataSource'); } - this.connected = true; - this.emit('connected'); + this.connected = !err; // Connected now + if(this.connected) { + this.emit('connected'); + } }.bind(this);