Async validations should not trump previous validations. Previous validations should be true as well as async validations

2011-11-25 10:22:35 -05:00 · 2011-11-25 10:22:35 -05:00 · 3ce01d11b2
parent 4d7b813953
commit 3ce01d11b2
1 changed files with 1 additions and 1 deletions
--- a/lib/validatable.js
+++ b/lib/validatable.js
@ -133,7 +133,7 @@ Validatable.prototype.isValid = function (callback) {
            asyncFail = asyncFail || fail;
            if (--wait === 0 && callback) {
                validationsDone.call(inst, function () {
-                    callback(!asyncFail);
+                    callback(valid && !asyncFail);
                });
            }
        }