From 32e534732c57cebac3a6c52210397ddd44e39085 Mon Sep 17 00:00:00 2001 From: Denis Bardadym Date: Tue, 10 Feb 2015 13:28:47 +0300 Subject: [PATCH] Remove workaround for perfomance degradation --- package.json | 2 +- test/schema.test.js | 8 ++------ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/package.json b/package.json index e23b1cd1..edd7c0e5 100644 --- a/package.json +++ b/package.json @@ -24,7 +24,7 @@ ], "devDependencies": { "mocha": "~1.20.1", - "should": "^4.6.3" + "should": "^5.0.0" }, "dependencies": { "async": "~0.9.0", diff --git a/test/schema.test.js b/test/schema.test.js index 3b04c382..416f9a97 100644 --- a/test/schema.test.js +++ b/test/schema.test.js @@ -15,14 +15,10 @@ describe('dataSource', function () { it('should clone existing model', function () { SlaveModel = slave.copyModel(Model); SlaveModel.dataSource.should.equal(slave); - // Workaround for an performance issue in `should` by customizing the msg - // where it takes ages to evaluate `should.not.equal` for complex objects - // https://github.com/shouldjs/should.js/blob/master/lib/assertion.js#L159-L162 - slave.should.not.equal(db, 'The two data sources should be different'); + slave.should.not.equal(db); var sm = new SlaveModel; sm.should.be.instanceOf(Model); - sm.getDataSource().should.not.equal(db, 'The data source of an instance ' + - 'of the slave model should be different from the original one'); + sm.getDataSource().should.not.equal(db); sm.getDataSource().should.equal(slave); });