verdnatura-mirror
/
loopback-datasource-juggler
mirror of https://github.com/loopbackio/loopback-datasource-juggler
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1033 from strongloop/fix/kvao-expire-error-status-code 

KeyValueAccessObject: return 404 when expiring unknown key
This commit is contained in:
Miroslav Bajtoš 2016-08-09 10:46:37 +02:00 committed by GitHub
parent 83a2826a59 9ced20fdcc
commit 8e81185375
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/connectors/kv-memory.js
View File

@ -109,7 +109,9 @@ function(modelName, key, ttl, options, callback) {
if (!(key in store)) { if (!(key in store)) {
return process.nextTick(function() { return process.nextTick(function() {
callback(new Error('Cannot expire unknown key ' + key)); var err = new Error('Cannot expire unknown key ' + key);
err.statusCode = 404;
callback(err);
}); });
} }

5
test/kvao/expire.suite.js
View File

@ -38,7 +38,10 @@ module.exports = function(dataSourceFactory, connectorCapabilities) {
it('returns error when key does not exist', function() { it('returns error when key does not exist', function() {
return CacheItem.expire('key-does-not-exist', 1).then( return CacheItem.expire('key-does-not-exist', 1).then(
function() { throw new Error('expire() should have failed'); }, function() { throw new Error('expire() should have failed'); },
function(err) { err.message.should.match(/key-does-not-exist/); }); function(err) {
err.message.should.match(/key-does-not-exist/);
err.should.have.property('statusCode', 404);
});
}); });
}); });
}; };