Merge pull request #431 from strongloop/feature/fix-should-not-equal-perf
Fix the perf around should.not.equal for complex objects
This commit is contained in:
commit
90063bc222
|
@ -13,16 +13,16 @@ describe('dataSource', function () {
|
|||
});
|
||||
|
||||
it('should clone existing model', function () {
|
||||
// Workaround for a possible bug in `should`
|
||||
// where it takes ages to evaluate `should.equal` for complex objects
|
||||
this.timeout(20000);
|
||||
|
||||
SlaveModel = slave.copyModel(Model);
|
||||
SlaveModel.dataSource.should.equal(slave);
|
||||
slave.should.not.equal(db);
|
||||
// Workaround for an performance issue in `should` by customizing the msg
|
||||
// where it takes ages to evaluate `should.not.equal` for complex objects
|
||||
// https://github.com/shouldjs/should.js/blob/master/lib/assertion.js#L159-L162
|
||||
slave.should.not.equal(db, 'The two data sources should be different');
|
||||
var sm = new SlaveModel;
|
||||
sm.should.be.instanceOf(Model);
|
||||
sm.getDataSource().should.not.equal(db);
|
||||
sm.getDataSource().should.not.equal(db, 'The data source of an instance ' +
|
||||
'of the slave model should be different from the original one');
|
||||
sm.getDataSource().should.equal(slave);
|
||||
});
|
||||
|
||||
|
|
Loading…
Reference in New Issue