Merge pull request #1433 from strongloop/create-update-pass

Catch errors using cb

lib/dao.js

@@ -283,6 +283,7 @@ DataAccessObject.create = function(data, options, cb) {
   var obj;
   var idValue = getIdValue(this, data);
 
+  try {
   // if we come from save
     if (data instanceof Model && !idValue) {
       obj = data;
@@ -292,6 +293,9 @@ DataAccessObject.create = function(data, options, cb) {
 
     this.applyProperties(enforced, obj);
     obj.setAttributes(enforced);
+  } catch (err) {
+    return cb(err);
+  }
 
   Model = this.lookupModel(data); // data-specific
   if (Model !== obj.constructor) obj = new Model(data);
@@ -3142,7 +3146,11 @@ function(data, options, cb) {
       }
 
       // update instance's properties
+      try {
         inst.setAttributes(data);
+      } catch (err) {
+        return cb(err);
+      }
 
       if (doValidate) {
         inst.isValid(function(valid) {

test/datatype.test.js

@@ -32,12 +32,11 @@ describe('datatypes', function() {
         list: {type: ['object']},
       });
 
-      (function() {
+      myModel.create({list: 'This string will crash the server'}, function(err) {
-        myModel.create({list: 'This string will crash the server'});
+        (err.statusCode).should.equal(400);
-      }).should.throw({statusCode: 400});
-
         done();
       });
+    });
 
   it('should return 400 when property of type array is set to object value',
     function(done) {
@@ -45,12 +44,11 @@ describe('datatypes', function() {
         list: {type: ['object']},
       });
 
-      (function() {
+      myModel.create({list: {key: 'This string will crash the server'}}, function(err) {
-        myModel.create({list: {key: 'This string will crash the server'}});
+        (err.statusCode).should.equal(400);
-      }).should.throw({statusCode: 400});
-
         done();
       });
+    });
 
   it('throws an error when property of type Date is set to an invalid value',
     function() {
@@ -58,9 +56,9 @@ describe('datatypes', function() {
         date: {type: Date},
       });
 
-      (function() {
+      myModel.create({date: 'invalid'}, function(err) {
-        myModel.create({date: 'invalid'});
+        (err.message).should.equal('Invalid date: invalid');
-      }).should.throw({message: 'Invalid date: invalid'});
+      });
     });
 
   it('should keep types when get read data from db', function(done) {

test/manipulation.test.js

@@ -36,6 +36,7 @@ describe('manipulation', function() {
   before(function setupStubUserModel(done) {
     StubUser = db.createModel('StubUser', {password: String}, {forceId: true});
     StubUser.setter.password = function(plain) {
+      if (plain.length === 0) throw new Error('password cannot be empty');
       var hashed = false;
       if (!plain) return;
       var pos = plain.indexOf('-');
@@ -484,6 +485,23 @@ describe('manipulation', function() {
       });
     });
 
+    it('should reject created StubUser with empty password', function(done) {
+      StubUser.create({email: 'b@example.com', password: ''}, function(err, createdUser) {
+        (err.message).should.match(/password cannot be empty/);
+        done();
+      });
+    });
+
+    it('should reject updated empty password with updateAttribute', function(done) {
+      StubUser.create({email: 'b@example.com', password: 'abc123'}, function(err, createdUser) {
+        if (err) return done(err);
+        createdUser.updateAttribute('password', '', function(err, updatedUser) {
+          (err.message).should.match(/password cannot be empty/);
+          done();
+        });
+      });
+    });
+
     it('should update one attribute', function(done) {
       person.updateAttribute('name', 'Paul Graham', function(err, p) {
         if (err) return done(err);