verdnatura-mirror
/
loopback-datasource-juggler
mirror of https://github.com/loopbackio/loopback-datasource-juggler
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Optimize related model queries 

No longer query for the related/included model when no results are
obtained in the first query.

fix:
https://github.com/strongloop/loopback-datasource-juggler/issues/1006
This commit is contained in:
Horia Radu 2016-07-21 14:26:24 +03:00
parent 799d803fa0
commit c3f62991c3
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/include.js
View File

@ -212,6 +212,9 @@ Inclusion.include = function(objects, include, options, cb) {
} }
} }
} }
if (!foreignKeys.length) {
return cb(null, []);
}
if (filter.limit || filter.skip || filter.offset) { if (filter.limit || filter.skip || filter.offset) {
// Force the find to be performed per FK to honor the pagination // Force the find to be performed per FK to honor the pagination
pageSize = 1; pageSize = 1;
@ -235,6 +238,10 @@ Inclusion.include = function(objects, include, options, cb) {
} }
var items = []; var items = [];
// Optimization: no need to resolve keys that are an empty array
listOfFKs = listOfFKs.filter(function(keys) {
return keys.length > 0;
});
async.each(listOfFKs, function(foreignKeys, done) { async.each(listOfFKs, function(foreignKeys, done) {
var newFilter = {}; var newFilter = {};
for (var f in filter) { for (var f in filter) {