verdnatura-mirror
/
loopback-datasource-juggler
mirror of https://github.com/loopbackio/loopback-datasource-juggler
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #548 from strongloop/fix/persistUndefinedAsNull-tests-and-SQL 

Fix persistUndefinedAsNull tests w/ SQL connectors
This commit is contained in:
Miroslav Bajtoš 2015-03-30 19:28:40 +02:00
parent 7c7f04955d b66d9fbc54
commit d18fa04ee9
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
test/datatype.test.js
View File

@ -150,7 +150,7 @@ describe('datatypes', function () {
}); });
describe('model option persistUndefinedAsNull', function() { describe('model option persistUndefinedAsNull', function() {
var TestModel; var TestModel, isStrict;
before(function(done) { before(function(done) {
TestModel = db.define( TestModel = db.define(
'TestModel', 'TestModel',
@ -162,6 +162,8 @@ describe('datatypes', function () {
persistUndefinedAsNull: true persistUndefinedAsNull: true
}); });
isStrict = TestModel.definition.settings.strict;
db.automigrate(done); db.automigrate(done);
}); });
@ -181,9 +183,15 @@ describe('datatypes', function () {
it('should convert property value undefined to null', function(done) { it('should convert property value undefined to null', function(done) {
var EXPECTED = { desc: null, extra: null }; var EXPECTED = { desc: null, extra: null };
if (isStrict) {
// SQL-based connectors don't support dynamic properties
delete EXPECTED.extra;
}
var data ={ desc: undefined, extra: undefined }; var data ={ desc: undefined, extra: undefined };
TestModel.create(data, function(err, created) { TestModel.create(data, function(err, created) {
if (err) return done(err); if (err) return done(err);
created.should.have.properties(EXPECTED); created.should.have.properties(EXPECTED);
TestModel.findById(created.id, function(err, found) { TestModel.findById(created.id, function(err, found) {
@ -209,7 +217,13 @@ describe('datatypes', function () {
}); });
it('should convert undefined to null on save', function(done) { it('should convert undefined to null on save', function(done) {
var EXPECTED = { desc: null, stars: null, extra: null }; var EXPECTED = { desc: null, stars: null, extra: null, dx: null };
if (isStrict) {
// SQL-based connectors don't support dynamic properties
delete EXPECTED.extra;
delete EXPECTED.dx;
}
TestModel.create({}, function(err, created) { TestModel.create({}, function(err, created) {
if (err) return done(err); if (err) return done(err);
created.desc = undefined; // Note: this is may be a no-op created.desc = undefined; // Note: this is may be a no-op
@ -219,7 +233,9 @@ describe('datatypes', function () {
created.save(function(err, saved) { created.save(function(err, saved) {
if (err) return done(err); if (err) return done(err);
created.should.have.properties(EXPECTED); created.should.have.properties(EXPECTED);
saved.should.have.properties(EXPECTED);
TestModel.dataSource.connector.all( TestModel.dataSource.connector.all(
TestModel.modelName, TestModel.modelName,