verdnatura-mirror
/
loopback-datasource-juggler
mirror of https://github.com/loopbackio/loopback-datasource-juggler
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix the test cases to avoid hard-coded ids

This commit is contained in:
Raymond Feng 2014-08-15 13:48:38 -07:00
parent 572dac06cb
commit f37941dfd6
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
test/relations.test.js
View File

@ -1763,11 +1763,14 @@ describe('relations', function () {
}); });
}); });
var productId;
it('should create items on scope', function(done) { it('should create items on scope', function(done) {
Category.create({ name: 'Category B' }, function(err, cat) { Category.create({ name: 'Category B' }, function(err, cat) {
category = cat; category = cat;
var link = cat.items.build({ notes: 'Some notes...' }); var link = cat.items.build({ notes: 'Some notes...' });
link.product.create({ name: 'Product 1' }, function(err, p) { link.product.create({ name: 'Product 1' }, function(err, p) {
productId = p.id;
cat.links[0].id.should.eql(p.id); cat.links[0].id.should.eql(p.id);
cat.links[0].name.should.equal('Product 1'); // denormalized cat.links[0].name.should.equal('Product 1'); // denormalized
cat.links[0].notes.should.equal('Some notes...'); cat.links[0].notes.should.equal('Some notes...');
@ -1781,7 +1784,7 @@ describe('relations', function () {
Category.findById(category.id, function(err, cat) { Category.findById(category.id, function(err, cat) {
cat.name.should.equal('Category B'); cat.name.should.equal('Category B');
cat.links.toObject().should.eql([ cat.links.toObject().should.eql([
{id: 5, name: 'Product 1', notes: 'Some notes...'} {id: productId, name: 'Product 1', notes: 'Some notes...'}
]); ]);
cat.items.at(0).should.equal(cat.links[0]); cat.items.at(0).should.equal(cat.links[0]);
cat.items(function(err, items) { // alternative access cat.items(function(err, items) { // alternative access
@ -1809,7 +1812,7 @@ describe('relations', function () {
Category.findById(category.id, function(err, cat) { Category.findById(category.id, function(err, cat) {
cat.name.should.equal('Category B'); cat.name.should.equal('Category B');
cat.links.toObject().should.eql([ cat.links.toObject().should.eql([
{id: 5, name: 'Product 1', notes: 'Updated notes...'} {id: productId, name: 'Product 1', notes: 'Updated notes...'}
]); ]);
done(); done();
}); });
@ -2239,6 +2242,7 @@ describe('relations', function () {
}); });
describe('custom relation/scope methods', function () { describe('custom relation/scope methods', function () {
var categoryId;
before(function (done) { before(function (done) {
db = getSchema(); db = getSchema();
@ -2282,6 +2286,7 @@ describe('relations', function () {
it('should setup test records', function (done) { it('should setup test records', function (done) {
Category.create({ name: 'Category A' }, function(err, cat) { Category.create({ name: 'Category A' }, function(err, cat) {
categoryId = cat.id;
cat.products.create({ name: 'Product 1' }, function(err, p) { cat.products.create({ name: 'Product 1' }, function(err, p) {
cat.products.create({ name: 'Product 2' }, function(err, p) { cat.products.create({ name: 'Product 2' }, function(err, p) {
done(); done();
@ -2292,8 +2297,8 @@ describe('relations', function () {
it('should allow custom scope methods - summarize', function(done) { it('should allow custom scope methods - summarize', function(done) {
var expected = [ var expected = [
{ name: 'Product 1', categoryId: 1, categoryName: 'Category A' }, { name: 'Product 1', categoryId: categoryId, categoryName: 'Category A' },
{ name: 'Product 2', categoryId: 1, categoryName: 'Category A' } { name: 'Product 2', categoryId: categoryId, categoryName: 'Category A' }
]; ];
Category.findOne(function(err, cat) { Category.findOne(function(err, cat) {