code review, better asserts

test/exclude-base-props.test.js

@@ -20,28 +20,18 @@ describe('exclude properties ', function() {
       {idInjection: false, excludeBaseProperties: ['id']});
     // User will have these properties: name, password
     var properties = User.definition.properties;
-
+    assert(('name', 'password' in properties));
-    var notFound = true;
+    // id should not be found in the properties list
-    for (var p in properties) {
+    assert(!('id' in properties));
-      if (p == 'id') {
-        notFound = false; // id should not be found in the properties list
-      }
-    }
-    assert.equal(notFound, true);
-
     // this excludes id property from the base model and and password property coming from base 'User' model since customer is
     // extended from User.
     var Customer = User.extend('Customer', {vip: {type: String}},
       {idInjection: false, excludeBaseProperties: ['password']});
-    // Customer will have these properties: name, vip
+    // Customer will have these properties: name(from UserModel) & vip
     properties = Customer.definition.properties;
-    notFound = true;
+    assert(('name', 'vip' in properties));
-    for (p in properties) {
+    // id and password properties should not be found in the properties list
-      if (p == 'id' || p == 'password') {
+    assert(!('id', 'password' in properties));
-        notFound = false; // id and password properties should not be found in the properties list
-      }
-    }
-    assert.equal(notFound, true);
     done();
   });
 });