Miroslav Bajtoš
7d50f6130b
Upgrade eslint-config-loopback + fix formatting
...
The new version of our config enabled function-paren-newline rule,
this commit fixes the codebase to use more consistent handling
of newlines when calling functions.
2018-07-16 08:46:25 +02:00
virkt25
9bd7f8d02f
fix: regression on Operation Hooks
...
Fix the regression introduced by 9af79cf51a
where updateAttributes
and replaceAttributes was incorrectly handling the response returned
by the database.
This commit restores the old behaviour where `context.data` is updated
only by a connector-provided function and reverts an incorrect change
of a test file made as part of the faulty fix.
Besides the fixes, this patch also renames `data` to `dbResponse` and
add comments explaining the structure of the response object for more
clarity.
2018-07-09 16:41:56 +02:00
Miroslav Bajtoš
9af79cf51a
Fix Operation Hooks to propagate data changes
...
Before this change, many Operation Hooks were not correctly propagating
changes made to `ctx.data` via reassigning ctx.data to a new object.
This change modifies existing tests to account for this different
scenario, adds few more tests for scenarios that were not covered by
tests before and finally fixes the problem discovered.
2018-06-28 12:22:16 +02:00
Miroslav Bajtoš
d2ee73b9d3
Update eslint + config to latest
2018-06-12 09:13:32 +02:00
Kevin Scroggins
07f0310d34
Added error handling for persist operation hook ( #1531 )
...
Unrelated CI failures. -.-
2018-01-24 11:37:30 -05:00
biniam
59b3ac22a8
use connector flag throughout tests
2017-07-26 16:18:30 -04:00
Kevin Delisle
828a71e576
test/helpers: annotate skipped tests
...
Differentiate between tests skipped by feature flags, and those
manually marked as skipped.
Tests that use the bdd.describe and bdd.it helper functions
will be marked as [UNSUPPORTED] if they are conditionally disabled.
2017-06-07 14:05:48 -04:00
Joshua Chaitin-Pollak
bb3812fbfb
Allow `after save` hook to see count of records changed ( #1231 )
...
* `after save` hook allows count of records changed
* Fix PR linter
2017-04-06 12:02:34 -04:00
Jonathan Sheely
21b08af7a3
Added notify flag for create and upsert ( #1277 )
...
* Added notify flag for create and upsert
* Code styling
* More code styling
* Added unit test for notify
* Fix PR linter
2017-04-05 13:23:26 -04:00
Miroslav Bajtoš
d809260799
Upgrade eslint-config, fix new violations
2017-02-01 12:45:56 +01:00
Siddhi Pai
3baa61590e
Fix block padding
...
* Remove test/.eslintrc
* run eslint . --fix
2016-12-13 16:05:50 -08:00
Miroslav Bajtoš
80d2264bc9
Merge pull request #1179 from strongloop/update/eslint
...
Upgrade eslint & config to latest
2016-12-06 10:12:11 +01:00
Loay
e14c48719e
Fix MySql CI server Failure
2016-12-05 11:42:08 -05:00
Miroslav Bajtoš
0f7a567f18
Upgrade eslint & config to latest
...
- eslint ^3.11.1
- eslint-config-loopback: ^6.0.0
- fix linter errors (mostly no-undef)
2016-12-05 15:14:09 +01:00
Amir Jafarian
d908a52753
Fix a test
...
* Fix location for an instance in a test
2016-10-30 20:50:06 -04:00
Amir Jafarian
756e936c4b
Add more robust OH tests for find method
2016-10-28 16:56:38 -04:00
Amir Jafarian
54d0f5b53d
Add support for `loaded` hook
...
* Add support for loaded hook for DAO.find with near filter
2016-10-28 11:46:46 -04:00
Amir Jafarian
f5e9b53289
Add test for operation hooks
...
* Add test for operation hook when near filter is used
2016-10-14 09:23:26 -04:00
Amir Jafarian
fec7742a69
Add 'isNewInstance' for updateAttributes
...
* Add 'isNewInstance' to loaded hook for updateAttributes
2016-09-19 16:56:15 -04:00
Amir Jafarian
581b8c61bf
Fix failures of upsertWithWhere
...
Forwardport of #1052
2016-09-02 15:46:36 -04:00
Amir Jafarian
aec678d252
Fix manually
2016-08-22 19:20:12 -04:00
Amir Jafarian
aa6d28268b
Auto-update by eslint --fix
2016-08-22 15:12:25 -04:00
Sonali Samantaray
37541dd178
upsertWithWhere feature support in juggler DAO
2016-08-16 18:06:01 +05:30
Amir Jafarian
2b6ced06a1
Add test's description
2016-05-31 11:13:28 -04:00
Miroslav Bajtoš
b86615e2b7
Implement operation hooks for EmbedsOne methods
...
create() triggers
- before save
- after save
udpate() triggers
- before save
- after save
destroy() triggers
- before delete
- after delete
The implementation here is intentionally left with less features
than the regular DAO methods provide, the goal is to get a partial
(but still useful!) version released soon.
2016-04-20 09:36:12 +02:00
Miroslav Bajtoš
c7f34c3452
eslint config 2.0 + remove extra empty lines
...
Upgrade eslint-config-loopback to ^2.0.0.
Remove extra empty lines to make `npm run lint` pass again.
2016-04-19 16:11:43 +02:00
Amir Jafarian
e9afb46eda
Fix `notify` bugs for `find`
2016-04-13 13:34:51 -04:00
Miroslav Bajtoš
09f4c7d026
test: extract hook-monitor helper
2016-04-13 13:54:17 +02:00
Miroslav Bajtoš
616a81b496
test: extract uid-generator helper
2016-04-13 13:53:31 +02:00
Miroslav Bajtoš
3435b43a5c
test: extract context-test-helpers
2016-04-13 13:52:54 +02:00
Miroslav Bajtoš
27c6279d6c
fix remaining eslint issues
2016-04-05 15:25:34 +02:00
Miroslav Bajtoš
39e04a1756
eslint --fix
2016-04-05 15:25:34 +02:00
Ryan Graham
c467b43c38
Insert copyright headers
2016-04-04 18:14:03 -07:00
Amir Jafarian
5b6bffb5b3
Fix Mongo compatibility issue
...
*Fix Mongo compatibility issue for replaceOrCreate
2016-03-29 14:42:13 -04:00
Amir Jafarian
2281e95940
Implementtaion of replace
...
This includes:
*implementation of replaceAttributes
*implementtaion of replaceOrCreate
2016-02-03 16:06:35 -05:00
Miroslav Bajtoš
e9899a93cf
Enhance "persist" hook in DAO.updateOrCreate
...
Report `ctx.isNewInstance` when the connector provides this info.
2015-12-18 16:08:38 +01:00
Miroslav Bajtoš
fd9bef4aa7
Enhance "persisted" hook in DAO.updateAttributes
...
Add `isNewInstance:false` to the context reported by
DAO.updateAttributes()
2015-12-18 16:08:01 +01:00
Miroslav Bajtoš
3028329126
"loaded" hook in DAO.find: ctx.data, not instance
...
Fix the implementation od DAO.find to provide "ctx.data" to the
"loaded" hook.
2015-12-18 15:54:35 +01:00
Raymond Feng
6513d9658f
Fix the test case with automigrate
2015-07-30 11:24:47 -07:00
Pradnya Baviskar
de0ca3c61f
Async 'loaded' hook for find
2015-07-27 18:58:29 +05:30
Pradnya Baviskar
8a20e07b3d
Fix 'persist' hook for updateAttributes()
2015-07-23 15:25:50 +05:30
Raymond Feng
c969e48d0c
Make sure done() is called within the callback
2015-07-21 08:07:09 -07:00
Raymond Feng
bcd477358f
Assert the existence of instance
2015-07-02 14:56:46 -07:00
Miroslav Bajtoš
e55469693d
test: fix persistence-hooks failures in MySQL
2015-06-24 18:31:30 +02:00
Pradnya Baviskar
20cf67d798
Add new hook 'loaded'
2015-06-23 12:04:46 +05:30
Raymond Feng
97f905ff1f
Fix the test case
2015-06-16 13:35:35 -07:00
Raymond Feng
b0f1aae533
Fix the test case as updateAll takes `where` directly
2015-06-15 15:17:47 -07:00
Pradnya Baviskar
3b0e77cb0a
Add new hook 'persist'
2015-06-10 16:19:13 +05:30
Miroslav Bajtoš
a00b91db79
Fix test for "after save" called on save/CREATE
...
Fix the test to correctly trigger the code path where the connector
decides whether a new record is created or an existing one is updated.
2015-04-01 18:25:45 +02:00
Fabien Franzen
1ab3d74ab5
Pass options in operation hooks context.
2015-03-30 18:03:42 +02:00