8ad53a4c0e
DAO.create: don't return the instance
...
Simplify DataAccessObject.create() and stop returning the
instance/array of instances. Users should always use callback (or
returned promise) to get the instance(s) created.
2016-04-29 14:16:06 +02:00
9bde8f859b
Implement operation hooks for EmbedsMany methods
...
create() triggers
- before save
- after save
updateById() triggers
- before save
- after save
destroy() triggers
- before delete
- after delete
The implementation here is intentionally left with less features
than the regular DAO methods provide, the goal is to get a partial
(but still useful!) version released soon.
Limitations:
- `before save` & `after save` hooks don't provide `ctx.isNewInstance`
- async validations are not supported yet
- `persist` and `loaded` hooks are not triggered at all
- `before delete` hook does not provide `ctx.where` property and
it's not possible to change the outcome of `destroy()` using this
hook. Note that regular DAO does support this.
- updating embedded instances triggers update of the parent (owning)
model, which is correct and expected. However, the context provided
by `before save` and `after save` hooks on the parent model is sort of
arbitrary and may include wrong/extra data. The same probably applies
to the scenario when deleting embedded instances triggers update of
the parent model.
2016-04-27 11:04:15 +02:00
b86615e2b7
Implement operation hooks for EmbedsOne methods
...
create() triggers
- before save
- after save
udpate() triggers
- before save
- after save
destroy() triggers
- before delete
- after delete
The implementation here is intentionally left with less features
than the regular DAO methods provide, the goal is to get a partial
(but still useful!) version released soon.
2016-04-20 09:36:12 +02:00
c7f34c3452
eslint config 2.0 + remove extra empty lines
...
Upgrade eslint-config-loopback to ^2.0.0.
Remove extra empty lines to make `npm run lint` pass again.
2016-04-19 16:11:43 +02:00
4e6351b856
Fix `forceId` check for `replaceById`
2016-04-14 15:05:56 -04:00
e9afb46eda
Fix `notify` bugs for `find`
2016-04-13 13:34:51 -04:00
4bb284bb60
Define `patch` aliases
...
*Define `patchOrCreate` as an alias for `updateOrCreate`
*Define `PatchAttributes` as an alias for `updateAttributes`
2016-04-12 13:40:01 -04:00
85ed753609
Merge pull request #786 from strongloop/feature/fix-610
...
Partition by foreign key for pagination
2016-04-06 14:01:08 -07:00
84da11f98e
Partition by foreign key for pagination
...
See https://github.com/strongloop/loopback-datasource-juggler/issues/610
2016-04-05 17:21:48 -07:00
daaf5e381a
Merge branch 'discover-hang' of https://github.com/TorchlightSoftware/loopback-datasource-juggler into TorchlightSoftware-discover-hang
...
# Conflicts:
# lib/datasource.js
# test/discovery.test.js
2016-04-05 16:18:25 -07:00
e321bafdf9
Fix style errors
2016-04-05 16:11:25 -07:00
b7543e9402
Merge pull request #860 from horiaradu/master
...
fix nin support for in memory datasource
2016-04-05 15:42:07 -07:00
27c6279d6c
fix remaining eslint issues
2016-04-05 15:25:34 +02:00
39e04a1756
eslint --fix
2016-04-05 15:25:34 +02:00
c467b43c38
Insert copyright headers
2016-04-04 18:14:03 -07:00
57afba8c51
support custom field settings under the connector's namespace
2016-03-16 09:17:55 -07:00
6db59cba6f
Update error message for missing connector
2016-03-15 17:01:37 -04:00
a3ae44aca0
fix nin support for in memory datasource
2016-02-27 10:27:09 +02:00
9dcf30efe9
Improve error message on connector init error
2016-02-26 14:00:24 +01:00
686ce5bae3
Fix missing connector error msg for db2, cloudant
2016-02-09 16:19:57 -05:00
2281e95940
Implementtaion of replace
...
This includes:
*implementation of replaceAttributes
*implementtaion of replaceOrCreate
2016-02-03 16:06:35 -05:00
ef232eae0a
Fix conversion for `updateAttributes`
2016-02-03 12:04:51 -05:00
0d9eebe3bb
Prevent constructor to be property name
2016-02-02 11:51:05 -05:00
550cfa2a86
Refactor `updateAttributes`
2016-01-25 10:56:27 +01:00
b556d96148
discoverSchemas returns an error when modelName is not found,
...
discoverSchema forwards that error and does not hang when no columns,
no errors are returned
2016-01-22 10:41:06 -07:00
ba7161b39e
Implement `findOrCreate` for memory connector
2016-01-16 18:46:53 -05:00
a5150265ec
Fix a bug when validation is off for findOrCreate
2016-01-08 16:47:38 -05:00
853ca03491
Use bluebird in utils.js
...
Replace `global.Promise` with `bluebird`
2016-01-07 15:27:33 -05:00
b509c759c4
Merge pull request #796 from strongloop/fix/various
...
Various fixes in operation hooks
2016-01-05 11:08:35 +01:00
93c9f63b0d
Fix broken code fencings in the docs
2015-12-28 23:03:37 +08:00
e9899a93cf
Enhance "persist" hook in DAO.updateOrCreate
...
Report `ctx.isNewInstance` when the connector provides this info.
2015-12-18 16:08:38 +01:00
fd9bef4aa7
Enhance "persisted" hook in DAO.updateAttributes
...
Add `isNewInstance:false` to the context reported by
DAO.updateAttributes()
2015-12-18 16:08:01 +01:00
3028329126
"loaded" hook in DAO.find: ctx.data, not instance
...
Fix the implementation od DAO.find to provide "ctx.data" to the
"loaded" hook.
2015-12-18 15:54:35 +01:00
80c3bd9d41
Merge pull request #752 from ernie58/optionalValidation
...
make automatic validation optional
2015-12-04 17:03:28 +01:00
0f3f27af51
Make automatic validation optional
...
Make automatic validation optional on all CRUD methods in a loopback
model. This can be done in 2 ways
- set `automaticValidation` in the model settings
- set `validate` on the options passed when calling the crud methods
The options take precedence on the model setting.
By default the automatic validation remains true to be backwards
compatible
2015-12-03 16:34:25 +01:00
bc825fafc4
Merge pull request #755 from zmijevik/zmijevik-feature/include-if-contains-results
...
fixes #753
2015-11-26 09:33:47 -08:00
3a3cb5b7cb
Merge pull request #764 from eugene-frb/master
...
Capture includeHasMany() as a find()'s caller by findCaller option
2015-11-26 09:29:14 -08:00
e1f20ee3ea
Merge pull request #772 from Abebw/master
...
Ignored Error
2015-11-26 09:28:50 -08:00
486c1de1ba
Merge pull request #715 from nennad/master
...
foreignKey dataLength fix
2015-11-26 09:28:08 -08:00
ba4600e564
Explicitly initialize column of partition by clause and pass it in find()'s options argument
2015-11-25 13:56:59 -08:00
0ac70766eb
silence a warning that introduced in bluebird 3.0
...
see http://bluebirdjs.com/docs/warning-explanations.html#warning-a-promise-was-created-in-a-handler-but-none-were-returned-from-it
Signed-off-by: Clark Wang <clark.wangs@gmail.com>
2015-11-24 17:15:53 +08:00
bd314e6a87
Merge branch 'with-simpe-and-fast-hasmany' of https://github.com/wertlex/loopback-datasource-juggler into wertlex-with-simpe-and-fast-hasmany
2015-11-23 15:21:18 -08:00
0334766490
fixed a bug where an error was sent to the updateAttributesCallback and then ignored
2015-11-23 14:07:35 -05:00
d8678a1f03
Correction of a regression introduced by commit 632898b: when querying an empty array ([]) with a 'neq' filter, there were no matching.
2015-11-23 17:09:24 +01:00
96020c7e7e
Capture includeHasMany() as a find()'s caller by findCaller option
...
To replace incorrect location of capturing this condition in find() in
loopback-connector/lib/sql.js proposed earlier in
https://github.com/strongloop/loopback-connector/pull/34 .
Being set to 'includeHasMany', findCaller option triggers injection of
PARTITION BY clause in buildColumnNames() in
loopback-connector-mssql/lib/mssql.js only when find() function is
called to process include filter with 'has many' relation.
2015-11-19 11:10:52 -08:00
5ddb50aca4
fixes #753
2015-11-04 20:13:12 -05:00
b1b36ed44e
fix typo
2015-11-04 14:58:28 +08:00
b993fb9466
fix global leak that mocha complains
...
Signed-off-by: Clark Wang <clark.wangs@gmail.com>
2015-11-04 14:19:47 +08:00
d9918d526a
dropped unused functions and tests fixed
2015-10-30 21:36:50 +06:00
2f31701655
One more comment
2015-10-30 21:19:37 +06:00
638002bc59
Looks better now
2015-10-30 21:15:48 +06:00
d0072b68a1
Merge pull request #739 from mdartic/master
...
Fix filtering relations of a model with an order specified
2015-10-28 08:38:03 -07:00
2de499ccb0
Added missing callback when a model is not found
2015-10-28 09:15:32 +00:00
7c22db6ea7
Filtering relations of a model with an order specified
2015-10-16 18:21:04 +02:00
1cab0164c2
home-written map extended with proper .set() method
2015-10-10 21:00:00 +05:00
a5dd9c181a
on the halfway to keeping original keys
2015-10-10 19:37:39 +05:00
0864bf7154
with updated map which stores original key and tests for them
2015-10-10 19:21:06 +05:00
94c3f9a432
Ability to define normalization of undefined query
...
Add datasource and model setting `normalizeUndefinedInQuery`
to determine how it will handle undefined values. Options:
- nullify : converts undefined to null
- throw : throw an error on undefined value
- ignore : strip the key where undefined value is found
The default operation is to strip the key.
2015-10-07 09:26:09 -07:00
6dac956cf8
findByIds would fail when an array of 0 length was passed as its first argument
2015-09-23 16:27:41 +01:00
207edd5eec
Merge pull request #687 from sklyukin/master
...
primaryKey to hasOne relation
2015-09-08 09:20:42 -07:00
0e2d2c162e
Update validations.js
...
Fix small mistake in doc comment.
2015-09-04 16:31:54 -07:00
e679deb376
typo fix
2015-09-03 17:02:21 +01:00
f3b0cb062e
Fix foreignKey length issue
...
If the PK has a definition like
```
"mysql": {
"dataType": "CHAR",
"dataLength":36,
"nullable":"N"
}
```
dataLength is ignored when the PK is used as a foreignKey in other models
2015-09-03 17:00:38 +01:00
fb11c78be0
Add support for using UUID V4 as defaultFn
2015-09-02 16:39:00 +02:00
d0f9b760f5
primaryKey for hasMany and belongsTo relations
2015-09-01 19:03:02 +05:00
483cd873e7
primaryKey to hasOne relation
2015-09-01 01:31:28 +05:00
febfe2362a
Merge pull request #699 from satyadeepk/master
...
Fixed ReferencesMany .findById to check the given id in the modelInstance[fk]
2015-08-31 10:08:38 -07:00
632898b022
Add support for matching array values à la mongo.
2015-08-27 23:32:53 -04:00
57a9c40e16
Fix primary key checks
2015-08-27 13:59:43 -07:00
7b497eb58f
Moved inst initialization to place where it used
2015-08-25 15:46:50 +03:00
84dc39dfe2
All tests passed
2015-08-24 20:45:41 +03:00
fb56915371
Dirty merge. Tests are broken
2015-08-24 16:07:43 +03:00
e585021586
include utils add. Tests ported to should.js
2015-08-24 15:41:04 +03:00
cd71a37bfa
Relax id requirement for basic query operations
2015-08-20 02:57:53 -07:00
ad83c82ebc
Fixed ReferencesMany .findById to check the given id in the ids array of the model instance
2015-08-19 22:34:16 +05:30
0381f6d7e7
Support embedded query in memory connector. Fix memory connector bug
...
Adds support for the ability to query embedsMany models from the parent.
Fix a memory connector bug that could occur when having an "or" or "and"
clause combined with another property. In that case, the and would revert
true for 'Paul McCartney'
```
{name:'John Lennon',and: [{role:'lead'}, {vip:true}]}}
```
2015-08-18 15:56:36 -04:00
bdf703fb45
Use idEquals when comparing ids in relation definitions
2015-08-18 10:22:36 -04:00
94ff275bbc
Handle possible undefined id
2015-08-18 09:40:52 -04:00
9363354e0f
Fix id copmarison by using strings
2015-08-18 09:40:52 -04:00
f5270c39c5
Refactor idEquals to utils
2015-08-17 12:49:38 -07:00
d14721656f
Merge pull request #691 from strongloop/do-not-coerce-regexp-to-string
...
Do not coerce RegExp objects to strings
2015-08-14 09:14:05 -07:00
e7e074f97b
Do not coerce RegExp objects to strings
...
Queries like `{where: {name: /John.*/i}}` should work. Notice there is no
`regexp` operator (ie. `{where: {name: {regexp: /John.*/i}}}`).
2015-08-13 16:16:48 -07:00
2120e53f7f
Indicate result of destroyById/protototype.destroy
...
Return `info.count` to the callback to indicate whether the model
instance was deleted or not. When Model's `settings.strictDelete`
is true, return 404 error when the model instance was not found.
2015-08-10 17:38:46 +02:00
62624203d1
Merge pull request #683 from thefinnomenon/master
...
Fixed typo & added the filter units
2015-08-06 08:50:21 -07:00
42805fd326
Removed extra ")"
2015-08-05 15:39:33 -04:00
21c0067462
Report deferred exceptions via callback
2015-08-05 11:18:38 -07:00
f35bd39e60
Fixed typo & added the filter units
...
Fixed typo in nearby sort function & added the ability to specify units when filtering for nearby points.
2015-08-05 14:18:28 -04:00
90ee9a1af3
fixes issue 673: Include hasMany of relation does not return empty array
2015-07-31 14:47:22 -07:00
4cd428a726
Fix regexp error for the memory connector
...
- Check for undefined/null values when accessing `regexp` key
2015-07-30 08:46:50 -07:00
4d7bfc94cd
Fix error handling
2015-07-29 10:21:47 -07:00
c45bde7ccf
Merge pull request #647 from PradnyaBaviskar/issue-418-discover
...
Promisify all 'discover' methods
2015-07-29 07:43:39 -07:00
ce57234d5e
Merge branch 'issue656-findLoadedAsync' of https://github.com/PradnyaBaviskar/loopback-datasource-juggler into PradnyaBaviskar-issue656-findLoadedAsync
2015-07-29 07:33:21 -07:00
68dc1d821f
Remove try/catch from find function
2015-07-28 17:40:14 -07:00
b2b5a0d920
Merge pull request #665 from strongloop/add-regex-support
...
Add support for RegExp operator
2015-07-28 15:22:02 -07:00
b8f1598723
Add support for regex operator
2015-07-27 15:11:53 -07:00
de0ca3c61f
Async 'loaded' hook for find
2015-07-27 18:58:29 +05:30
c63f3fb6cb
Promisify all 'discover' methods
2015-07-24 12:07:22 +05:30
b08b6dd954
Merge pull request #650 from PradnyaBaviskar/issue-649
...
Fix 'persist' hook for updateAttributes()
2015-07-23 08:27:07 -07:00
8a20e07b3d
Fix 'persist' hook for updateAttributes()
2015-07-23 15:25:50 +05:30
a94993c097
Don't enforce strictness if allowExtendedOperators: true (MongoDB)
2015-07-22 17:09:04 +02:00
c7caa0a7c1
Take strict: validate and throw settings into account
2015-07-21 13:33:42 +02:00
8b06a9d39d
Filter attributes when strict: true
2015-07-20 11:59:07 +02:00
342bc2f782
prevent upsert overwriting default values with applyDefaultValues option
...
Creates a new applyDefaultValues option on the Model constructor
defaulting to true, the current behaviour.
Updates the dao module to pass `{ applyDefaultValues: false }` to the
Model constructor during the updateOrCreate method when we assume an
update is happening.
2015-07-14 09:08:10 -07:00
1066313f3f
use fromDb to deserialize data after save in Memory connector
...
Changes the after `save` callback in the memory connector to use the
`fromDb` method to deserialize the data passed back to upsert and
updateAttributes methods.
2015-07-14 09:08:09 -07:00
6ce47f71b4
Correctly handle validatesUniquenessOf(idName)
2015-07-13 12:56:49 +02:00
5dc4042300
Fix object merge
2015-07-10 13:54:29 -07:00
6eb18cb2f6
Make sure base property definitions are cloned
...
Sub models sometimes need to customize the properties from the base model.
This change allows each sub model has its own copy of the base property
definition to avoid potential conflicts across multiple sub models of the
same base.
2015-07-10 10:03:51 -07:00
eb20eebe95
Fix the regression for date conversion
2015-07-03 09:29:26 -07:00
5290559a42
Don't cache static scope method results #575
2015-07-03 10:35:26 +02:00
4206088fbc
Fix the regexp value for like/nlike
2015-07-02 23:22:36 -07:00
542afefb1d
Make sure operator/options are honored
2015-07-02 11:27:33 -07:00
50ac143cea
Merge pull request #652 from strongloop/feature/fix-objectid-coercion
...
Fix coercion from ObjectID to String
2015-07-02 10:21:03 -07:00
506abf134e
Merge pull request #642 from rus0000/rus0000-patch-1-fix-updateOrCreate-transaction
...
Fix updateOrCreate transaction propagation
2015-07-02 10:17:12 -07:00
e72a3cac2f
Merge pull request #643 from rus0000/includes-with-transaction-support
...
Includes with transaction support
2015-07-02 10:13:49 -07:00
eb6fa410fe
Fix coercion from ObjectID to String
2015-07-01 14:58:14 -07:00
ef2555ce4e
Fix #623 - use actual id order
2015-06-30 20:48:09 +02:00
293240d752
Merge pull request #599 from PradnyaBaviskar/issue-441
...
Add new hook 'loaded'
2015-06-24 16:35:50 +02:00
13b9e47e87
Includes with transaction support
2015-06-24 02:08:07 +03:00
17cac79b09
Fix updateOrCreate transaction propagation
2015-06-23 19:14:36 +03:00
ca8012ba0a
Fix promise chaining in case of error
2015-06-23 19:08:46 +03:00
e7430184a9
Promisify 'autoupdate'
2015-06-23 18:02:08 +05:30
20cf67d798
Add new hook 'loaded'
2015-06-23 12:04:46 +05:30
ef50be563f
Merge pull request #618 from strongloop/feature/fix-lb-967
...
Allow 0 as the FK
2015-06-16 08:55:54 -07:00
bbe9cb350c
Merge pull request #626 from walkonsocial/include-issues
...
Fix for issues #622 & #623
2015-06-16 08:55:29 -07:00
f4f13a6626
Promisify 'automigrate'
2015-06-16 12:58:21 +05:30
0d7dcdd043
check object exists before setting __cachedRelations
2015-06-16 11:10:00 +05:30
052e22ab43
Fix for issues #622 & #623
...
polymorphic hasOne needs separate handling and hasMany->referencesMany has a unique case which is fixed for MongoDB as suggested by @fabien.
2015-06-12 01:55:25 +05:30
3b0e77cb0a
Add new hook 'persist'
2015-06-10 16:19:13 +05:30
3ee3ba3dcf
Allow 0 as the FK
...
See https://github.com/strongloop/loopback/issues/967
2015-06-08 13:01:16 -07:00
a283922c28
fix typo
...
Signed-off-by: Clark Wang <clark.wangs@gmail.com>
2015-06-01 11:28:58 +08:00
493d98f66b
Dedupe ids args of inq for include
2015-05-29 10:50:37 -07:00
e0e6a0cdbb
Merge pull request #588 from mamboer/master
...
fix issue #587
2015-05-28 14:44:11 -07:00
f789e2abfc
Merge pull request #604 from atomic-labs/master
...
addressing #603
2015-05-28 14:35:58 -07:00
b73f9f1bd4
Don't silently swallow db errors on validation.
2015-05-28 11:54:01 -05:00
46e6ad2fd6
Merge pull request #602 from strongloop/feature/more-tests-for-observers
...
Enhance the apis and add more tests
2015-05-27 11:08:00 -07:00
621adf5435
Enhance the apis and add more tests
2015-05-26 10:15:39 -07:00
018022e84b
adapt coding style @bajtos
2015-05-26 12:33:56 +08:00
69bd7c1233
Merge remote-tracking branch 'upstream/master'
2015-05-26 12:28:11 +08:00
e63d15aeb5
addressing #603
2015-05-22 13:42:34 -07:00
5977c1f872
Merge pull request #600 from strongloop/feature/fix-lb-1401
...
Fix for https://github.com/strongloop/loopback/issues/1401
2015-05-22 11:40:20 -07:00
a028b2644c
Fix for https://github.com/strongloop/loopback/issues/1401
2015-05-22 11:39:37 -07:00
91b04655cd
Fix ReferenceError: definition is not defined
...
occure when try to delete object in has one relation, but object not created yet
2015-05-22 00:37:27 +03:00
12dea6e1cb
Merge pull request #598 from strongloop/feature/add-connector-hooks
...
Mix in observer apis to the connector
2015-05-21 10:43:32 -07:00
506223885d
Mix in observer apis to the connector
2015-05-20 15:02:44 -07:00
966bb56c31
Enhance fieldsToArray to consider strict mode
2015-05-19 22:32:03 -07:00
0e04f78637
Make sure promise is returned
2015-05-18 12:02:07 -07:00
be38cb3a6f
Fix comments
2015-05-18 09:34:25 -07:00
1bd5e74a13
Enable docs
2015-05-18 09:00:49 -07:00
93a0342099
Add an optional `options` argument to relation methods
2015-05-16 11:52:17 -07:00
9177e07209
Add transaction apis
2015-05-16 11:52:17 -07:00
Miroslav Bajtoš
Amir Jafarian
Simon Ho
Raymond Feng
Raymond Feng
Raymond Feng
Ryan Graham
bitmage
gunjpan
Horia Radu
Candy
Amir Jafarian
Jue Hou
Miroslav Bajtoš
Farid Nouri Neshat
Bert Casier
eugene-frb
Clark Wang
Abe BW
Michael Diguet
Joseph M. Persie
Wert_Lex
Federico Rampazzo
mdartic
Ryan Schumacher
James Cooke
Rand McKinney
nennad
Bram Borggreve
sklyukin
Laurent Villeneuve
Satyadeep
Fabien Franzen
Chris Finn
Kenta Fried
Simon Ho
Pradnya Baviskar
Bryan Clark
Miroslav Bajtoš
Rus1
ningsuhen
Samuel Reed
mamboer
Patrick Perini
Dmitry Manannikov