a6c5802940
dao: catch sync errors on setAttributes
...
Wrap inst.setAttributes in try-catch to prevent synchronous errors
from crashing the application.
2017-03-16 17:26:53 -04:00
46318d2094
Update error message
2017-03-16 11:02:08 -04:00
9afaa9a66e
Fix id update error message formatting
...
Error is raised when trying to update an id property while forceId
is set to true
2017-02-15 18:26:32 +01:00
d809260799
Upgrade eslint-config, fix new violations
2017-02-01 12:45:56 +01:00
733ad1a024
Refactor logic of options.allowExtendedOperators
...
Implement logic to allowExtendedOperators options
per request, per Model and Datasource.
2017-01-30 00:05:56 +01:00
44a5a7ad81
Fix forceId validation error
2017-01-26 16:52:19 -05:00
2377792c22
Coerce array-like objects into arrays
...
The query-string parser used by express
https://github.com/ljharb/qs#parsing-arrays
limits the size of arrays that are created from query strings to 20
items. Arrays larger than that are converted to objects using numeric
indices.
This commit fixes the coercion algorithm used by queries to
treat number-indexed objects as arrays. We still maintain a strict
understanding of an "array-like object" to limit the opportunity for
subtle bugs. In particular, the presence of non-index keys is an
indication that the object was not intended to be interpreted as
an array.
2017-01-10 14:46:41 +01:00
454bf93aaf
Upgrade eslint-config to 7.x
...
Also upgrade eslint itself to 3.x.
2017-01-06 13:33:54 +01:00
779cf6a370
Honour allowExtendedOperators in "DAO.find"
...
Modify the coercion of filter.where to hounour "allowExtendedOperators"
and don't coerce property values of type object (extended operators).
2016-12-06 10:28:40 +01:00
54d0f5b53d
Add support for `loaded` hook
...
* Add support for loaded hook for DAO.find with near filter
2016-10-28 11:46:46 -04:00
266e9f5a9a
Continue _coerce after logical operators
2016-10-25 23:09:46 +03:00
a23076d3a8
Add ilike and nilike operators
...
Closes #633
2016-10-12 18:31:31 -06:00
e42b1327aa
Fix JSDoc issue
2016-10-11 12:15:35 -04:00
66f27b9b83
Merge pull request #1094 from strongloop/newInstance_loade_updateAttributes
...
Add 'isNewInstance' for updateAttributes
2016-09-21 09:23:57 -04:00
fec7742a69
Add 'isNewInstance' for updateAttributes
...
* Add 'isNewInstance' to loaded hook for updateAttributes
2016-09-19 16:56:15 -04:00
805db78e19
Strict mode now always return validationError
...
- Deprecation of strict:validate and strict:throw
- When strict mode is enabled, it will now always
return validation error (previous strict:validate)
2016-09-19 10:27:24 -04:00
2830062259
Disable `strict` for a few files
...
*Disable `strict` for a few files to disappear warnings
2016-08-26 09:54:31 -04:00
aa6d28268b
Auto-update by eslint --fix
2016-08-22 15:12:25 -04:00
37541dd178
upsertWithWhere feature support in juggler DAO
2016-08-16 18:06:01 +05:30
1e57d4f316
Merge pull request #1034 from strongloop/err_connector_not_implements_replaceById
...
Return error if the connector does not implement
2016-08-09 14:01:58 -04:00
327c785347
Return error if the connector does not implement
...
* Return error if the connector does not implement `replaceById`
2016-08-09 10:37:15 -04:00
d181fd0671
Fixup globalization
2016-08-08 15:34:41 -04:00
0b62dd94ea
Disallow bulk updateOrCreate.
2016-08-05 11:54:06 +02:00
f2f9b4a6f8
Use g.f instead of utils.format
2016-08-03 10:47:40 -04:00
4ce5b5d3a0
Support for globalization
2016-07-28 15:20:18 -04:00
699e0587d1
Ensure stable order of items in DAO.find()
...
When post-processing result of find operation, use "async.map"
instead of "async.each + array.push" to ensure the order of items
is preserved.
2016-07-13 14:55:49 +02:00
fbe58f7cf8
give options to validators #984
2016-06-24 14:44:43 -07:00
7a8803cb38
Give warning if PK is changed in hooks
...
* Give warning if PK is changed in `before save` and `loaded`
operation hooks for replaceById
2016-06-08 11:56:19 -04:00
3daca1e960
Remove model events
2016-06-08 10:27:05 -04:00
cae44f0458
Fix error message
...
*Fix error message when PK is changed in `replaceById`
2016-06-01 16:16:35 -04:00
82546fdf47
Retun err for UPSERT if the connector returns err
2016-05-31 22:17:23 -04:00
d9a3f6226a
Fix incompatibility between different connectors
...
* Fix incompatibility for replace methods between different connectors.
2016-05-27 13:45:24 -04:00
ae7a5df47b
Document promise support for DAO::find
...
It was previously completely undocumented. There are additional methods that add promises but I figure accurately documenting some is better than none. :)
2016-05-11 09:58:22 -04:00
8ad53a4c0e
DAO.create: don't return the instance
...
Simplify DataAccessObject.create() and stop returning the
instance/array of instances. Users should always use callback (or
returned promise) to get the instance(s) created.
2016-04-29 14:16:06 +02:00
c7f34c3452
eslint config 2.0 + remove extra empty lines
...
Upgrade eslint-config-loopback to ^2.0.0.
Remove extra empty lines to make `npm run lint` pass again.
2016-04-19 16:11:43 +02:00
4e6351b856
Fix `forceId` check for `replaceById`
2016-04-14 15:05:56 -04:00
e9afb46eda
Fix `notify` bugs for `find`
2016-04-13 13:34:51 -04:00
4bb284bb60
Define `patch` aliases
...
*Define `patchOrCreate` as an alias for `updateOrCreate`
*Define `PatchAttributes` as an alias for `updateAttributes`
2016-04-12 13:40:01 -04:00
27c6279d6c
fix remaining eslint issues
2016-04-05 15:25:34 +02:00
39e04a1756
eslint --fix
2016-04-05 15:25:34 +02:00
c467b43c38
Insert copyright headers
2016-04-04 18:14:03 -07:00
2281e95940
Implementtaion of replace
...
This includes:
*implementation of replaceAttributes
*implementtaion of replaceOrCreate
2016-02-03 16:06:35 -05:00
ef232eae0a
Fix conversion for `updateAttributes`
2016-02-03 12:04:51 -05:00
550cfa2a86
Refactor `updateAttributes`
2016-01-25 10:56:27 +01:00
a5150265ec
Fix a bug when validation is off for findOrCreate
2016-01-08 16:47:38 -05:00
e9899a93cf
Enhance "persist" hook in DAO.updateOrCreate
...
Report `ctx.isNewInstance` when the connector provides this info.
2015-12-18 16:08:38 +01:00
fd9bef4aa7
Enhance "persisted" hook in DAO.updateAttributes
...
Add `isNewInstance:false` to the context reported by
DAO.updateAttributes()
2015-12-18 16:08:01 +01:00
3028329126
"loaded" hook in DAO.find: ctx.data, not instance
...
Fix the implementation od DAO.find to provide "ctx.data" to the
"loaded" hook.
2015-12-18 15:54:35 +01:00
80c3bd9d41
Merge pull request #752 from ernie58/optionalValidation
...
make automatic validation optional
2015-12-04 17:03:28 +01:00
0f3f27af51
Make automatic validation optional
...
Make automatic validation optional on all CRUD methods in a loopback
model. This can be done in 2 ways
- set `automaticValidation` in the model settings
- set `validate` on the options passed when calling the crud methods
The options take precedence on the model setting.
By default the automatic validation remains true to be backwards
compatible
2015-12-03 16:34:25 +01:00
0334766490
fixed a bug where an error was sent to the updateAttributesCallback and then ignored
2015-11-23 14:07:35 -05:00
b1b36ed44e
fix typo
2015-11-04 14:58:28 +08:00
b993fb9466
fix global leak that mocha complains
...
Signed-off-by: Clark Wang <clark.wangs@gmail.com>
2015-11-04 14:19:47 +08:00
d0072b68a1
Merge pull request #739 from mdartic/master
...
Fix filtering relations of a model with an order specified
2015-10-28 08:38:03 -07:00
2de499ccb0
Added missing callback when a model is not found
2015-10-28 09:15:32 +00:00
7c22db6ea7
Filtering relations of a model with an order specified
2015-10-16 18:21:04 +02:00
94c3f9a432
Ability to define normalization of undefined query
...
Add datasource and model setting `normalizeUndefinedInQuery`
to determine how it will handle undefined values. Options:
- nullify : converts undefined to null
- throw : throw an error on undefined value
- ignore : strip the key where undefined value is found
The default operation is to strip the key.
2015-10-07 09:26:09 -07:00
6dac956cf8
findByIds would fail when an array of 0 length was passed as its first argument
2015-09-23 16:27:41 +01:00
57a9c40e16
Fix primary key checks
2015-08-27 13:59:43 -07:00
cd71a37bfa
Relax id requirement for basic query operations
2015-08-20 02:57:53 -07:00
f5270c39c5
Refactor idEquals to utils
2015-08-17 12:49:38 -07:00
d14721656f
Merge pull request #691 from strongloop/do-not-coerce-regexp-to-string
...
Do not coerce RegExp objects to strings
2015-08-14 09:14:05 -07:00
e7e074f97b
Do not coerce RegExp objects to strings
...
Queries like `{where: {name: /John.*/i}}` should work. Notice there is no
`regexp` operator (ie. `{where: {name: {regexp: /John.*/i}}}`).
2015-08-13 16:16:48 -07:00
2120e53f7f
Indicate result of destroyById/protototype.destroy
...
Return `info.count` to the callback to indicate whether the model
instance was deleted or not. When Model's `settings.strictDelete`
is true, return 404 error when the model instance was not found.
2015-08-10 17:38:46 +02:00
4d7bfc94cd
Fix error handling
2015-07-29 10:21:47 -07:00
ce57234d5e
Merge branch 'issue656-findLoadedAsync' of https://github.com/PradnyaBaviskar/loopback-datasource-juggler into PradnyaBaviskar-issue656-findLoadedAsync
2015-07-29 07:33:21 -07:00
68dc1d821f
Remove try/catch from find function
2015-07-28 17:40:14 -07:00
b2b5a0d920
Merge pull request #665 from strongloop/add-regex-support
...
Add support for RegExp operator
2015-07-28 15:22:02 -07:00
b8f1598723
Add support for regex operator
2015-07-27 15:11:53 -07:00
de0ca3c61f
Async 'loaded' hook for find
2015-07-27 18:58:29 +05:30
b08b6dd954
Merge pull request #650 from PradnyaBaviskar/issue-649
...
Fix 'persist' hook for updateAttributes()
2015-07-23 08:27:07 -07:00
8a20e07b3d
Fix 'persist' hook for updateAttributes()
2015-07-23 15:25:50 +05:30
a94993c097
Don't enforce strictness if allowExtendedOperators: true (MongoDB)
2015-07-22 17:09:04 +02:00
c7caa0a7c1
Take strict: validate and throw settings into account
2015-07-21 13:33:42 +02:00
8b06a9d39d
Filter attributes when strict: true
2015-07-20 11:59:07 +02:00
342bc2f782
prevent upsert overwriting default values with applyDefaultValues option
...
Creates a new applyDefaultValues option on the Model constructor
defaulting to true, the current behaviour.
Updates the dao module to pass `{ applyDefaultValues: false }` to the
Model constructor during the updateOrCreate method when we assume an
update is happening.
2015-07-14 09:08:10 -07:00
eb20eebe95
Fix the regression for date conversion
2015-07-03 09:29:26 -07:00
4206088fbc
Fix the regexp value for like/nlike
2015-07-02 23:22:36 -07:00
542afefb1d
Make sure operator/options are honored
2015-07-02 11:27:33 -07:00
50ac143cea
Merge pull request #652 from strongloop/feature/fix-objectid-coercion
...
Fix coercion from ObjectID to String
2015-07-02 10:21:03 -07:00
506abf134e
Merge pull request #642 from rus0000/rus0000-patch-1-fix-updateOrCreate-transaction
...
Fix updateOrCreate transaction propagation
2015-07-02 10:17:12 -07:00
eb6fa410fe
Fix coercion from ObjectID to String
2015-07-01 14:58:14 -07:00
293240d752
Merge pull request #599 from PradnyaBaviskar/issue-441
...
Add new hook 'loaded'
2015-06-24 16:35:50 +02:00
17cac79b09
Fix updateOrCreate transaction propagation
2015-06-23 19:14:36 +03:00
ca8012ba0a
Fix promise chaining in case of error
2015-06-23 19:08:46 +03:00
20cf67d798
Add new hook 'loaded'
2015-06-23 12:04:46 +05:30
3b0e77cb0a
Add new hook 'persist'
2015-06-10 16:19:13 +05:30
966bb56c31
Enhance fieldsToArray to consider strict mode
2015-05-19 22:32:03 -07:00
93a0342099
Add an optional `options` argument to relation methods
2015-05-16 11:52:17 -07:00
670a6e740d
Add transaction
2015-05-16 11:52:17 -07:00
5ef444e45d
Conditionally pass options to connector CRUD methods
2015-05-13 09:36:45 -07:00
df7d221f31
Pass-through options from save to create
2015-05-10 10:44:22 +02:00
9bc79d2366
dao: support validateUpsert:false
...
- validateUpsert:true reports validation errors back to the callback
- validateUpsert:false does not call `isValid()` at all
- any other value report validation errors via `console.warn`
2015-05-05 08:24:08 +02:00
b642d52fbe
Merge pull request #565 from strongloop/feature/validate-upsert
...
Validate model on updateOrCreate (upsert).
2015-04-17 17:20:55 +02:00
988a929577
Extend findById to accept an optional filter object
2015-04-16 09:06:53 -07:00
3df62444d6
Validate model on updateOrCreate (upsert).
...
Fix the implementation of updateOrCreate (a.k.a. upsert) to validate
the model before calling the connector.
In order to preserve backwards compatibility, validation errors are
only logged via console.warn by default.
The correct behaviour, where validation errors fail the updateOrCreate
operation, can be enabled via new model setting "validateUpsert".
2015-04-16 09:09:54 +02:00
3a51510119
Code cleanup in lib/dao.js
...
Rename callback argument "result" to "info" to make it consistent
with other places where we use "info" too.
Remove traling whitespace.
2015-04-01 18:25:04 +02:00
44e5ad1fef
Merge pull request #549 from fabien/feature/hookstate-from-options
...
Allow passing in hookState from options
2015-03-30 14:35:34 -07:00
1ab3d74ab5
Pass options in operation hooks context.
2015-03-30 18:03:42 +02:00
2891b5e5b3
check if id does not exist a bit more explicitly
...
if left as-is, ids with value of zero were treated as non-existent
2015-03-30 09:52:08 -05:00
Kevin Delisle
Loay
Rémi Bèges
Miroslav Bajtoš
Matteo Padovano
Heath Morrison
Amir Jafarian
Nick Duffy
David Cheung
Sonali Samantaray
Richard Pringle
RobinBiondi
Candy
Sequoia McDowell
Ryan Graham
Amir Jafarian
Miroslav Bajtoš
Bert Casier
Abe BW
Clark Wang
Raymond Feng
Federico Rampazzo
mdartic
Ryan Schumacher
James Cooke
Simon Ho
Raymond Feng
Fabien Franzen
Simon Ho
Pradnya Baviskar
Bryan Clark
Miroslav Bajtoš
Rus1
Miroslav Bajtoš
Pulkit Singhal