662458dc2c
Fix validateNumericality, nullCheck & add tests
...
validateNumericality didn't test if attributes value is a number
only if it's type is number.
Further nullCheck had a wrong testing order. It first checked if
value is null, later if blank. Also null check only used two equals,
not three. We don't use blank() anymore, testing if variable is
undefined should be fine too.
Added tests covering validateNumericality.
2016-10-15 10:59:22 +02:00
f5e9b53289
Add test for operation hooks
...
* Add test for operation hook when near filter is used
2016-10-14 09:23:26 -04:00
a23076d3a8
Add ilike and nilike operators
...
Closes #633
2016-10-12 18:31:31 -06:00
2cb0d042e4
Fix CI Failures in MySQL
2016-09-26 20:27:33 -04:00
06d4b90071
Add code review fixups
2016-09-22 16:15:32 -07:00
5636c15903
More descriptive name for model with shortid
2016-09-22 16:07:34 -07:00
419a464d06
Polish PR
2016-09-22 16:07:34 -07:00
be1d71f626
Support {defaultFn: 'shortid'}
2016-09-22 16:07:34 -07:00
66f27b9b83
Merge pull request #1094 from strongloop/newInstance_loade_updateAttributes
...
Add 'isNewInstance' for updateAttributes
2016-09-21 09:23:57 -04:00
fec7742a69
Add 'isNewInstance' for updateAttributes
...
* Add 'isNewInstance' to loaded hook for updateAttributes
2016-09-19 16:56:15 -04:00
805db78e19
Strict mode now always return validationError
...
- Deprecation of strict:validate and strict:throw
- When strict mode is enabled, it will now always
return validation error (previous strict:validate)
2016-09-19 10:27:24 -04:00
32a6b68f1d
Skip test temporarily
2016-09-09 14:48:41 -04:00
11ce971ad0
Fix BSON Object ID errors for CI
2016-09-08 13:16:55 -07:00
a438c72cc5
Add missing "done" arg in test/kvao/ttl.suite
2016-09-08 10:22:27 +02:00
a39c0236bb
Support nested queries for arrays
...
Enhance the built-in memory connector to correctly support nested
queries for arrays in addition to objects.
E.g. if "friends" is an array of objects containing "name", then
{ where: { "friends.name": "Jane" } } should match records containing
a friend called "Jane".
2016-09-07 13:33:57 +02:00
095745c93b
Refactor TTL tests for KV memory connector
...
Reduce the complixity in the TTL test suite for the kv-memory connector
to get CI to pass.
2016-09-04 12:27:33 -07:00
f102f6302b
Merge pull request #1075 from strongloop/forwardport/test-fix-for-expire
...
Fix test case for expire
2016-09-02 16:03:54 -07:00
d888d758c0
Merge pull request #1073 from strongloop/fix_upsertWithWhere_failures
...
Fix failures of upsertWithWhere
2016-09-02 17:01:43 -04:00
b884138923
Fix test case for expire
...
Forwardport of #1074 . #1072 was missing Promise.resolve before using
delay(20) and causing Travis to fail on 2.x. This PR makes the test code
consistent on both master and 2.x.
2016-09-02 13:59:44 -07:00
581b8c61bf
Fix failures of upsertWithWhere
...
Forwardport of #1052
2016-09-02 15:46:36 -04:00
96cd8ff56b
Remove expired item before executing expire
...
The expire feature is falsely returning 204 instead of 404 because it is
not removing expired items before execution.
2016-09-01 21:18:40 -07:00
6d3ea21c16
test/memory: remove dummy findOrCreate impl
...
Let the operation-hook tests use the real implementation,
now that we have it in place.
2016-08-26 09:46:59 +02:00
aec678d252
Fix manually
2016-08-22 19:20:12 -04:00
aa6d28268b
Auto-update by eslint --fix
2016-08-22 15:12:25 -04:00
3b653a192b
kvao: implement key filter
2016-08-18 09:59:56 +02:00
01ce7df60f
kvao: add iterateKeys() and keys()
...
Add a core implementation of KVAO.iterateKeys() which returns an
AsyncIterator, inspired by
- https://github.com/tc39/proposal-async-iteration
- https://www.npmjs.com/package/async-iterators
This way we can safely iterate even large sets of data.
Also add KVAO.keys(), a sugar API converting the result of iterateKeys()
into a single array.
2016-08-18 09:59:56 +02:00
37541dd178
upsertWithWhere feature support in juggler DAO
2016-08-16 18:06:01 +05:30
e1a649ed58
Rename get test suite to match other test suites
2016-08-15 11:13:07 -07:00
1c20cc83aa
Add TTL for KeyValue related features
2016-08-11 17:12:36 -07:00
b01df10eae
Merge pull request #1039 from strongloop/fix/kv-memory-reference-error
...
kv-memory: fix crash in regular cleanup
2016-08-10 14:18:11 +02:00
c4b2921977
Merge pull request #982 from strongloop/fix/auto-increment-db
...
forceId=true with auto-increment db
2016-08-09 10:02:36 -04:00
4978cd8089
kv-memory: fix crash in regular cleanup
...
Fix bug in "_setupRegularCleanup()" where the interval callback
was trying to access an object that has been garbage-collected
in the meantime.
2016-08-09 15:35:23 +02:00
baec1b5b77
test/relation: add missing error handlers
2016-08-08 16:26:26 -04:00
8935b978f3
forceId=true with auto-increment db
2016-08-08 16:26:26 -04:00
9ced20fdcc
kvao: return 404 when expiring unknown key
2016-08-08 17:22:33 +02:00
f15b4e2c86
Implement KeyValue API and memory connector
...
Models attached to a KeyValue connector get the following *static*
methods:
Color.set(key, value);
Color.set(key, value, ttl);
Color.set(key, value, { ttl: ttl });
Color.get(key);
Color.expire(key, ttl);
2016-08-08 10:15:34 +02:00
0b62dd94ea
Disallow bulk updateOrCreate.
2016-08-05 11:54:06 +02:00
f967773b2a
Fix test case typo
...
Signed-off-by: Supasate Choochaisri <supasate.c@gmail.com>
2016-07-24 19:38:37 +07:00
94c5c18541
Add test to catch invalid date property
...
Signed-off-by: Supasate Choochaisri <supasate.c@gmail.com>
2016-07-14 17:27:02 +07:00
699e0587d1
Ensure stable order of items in DAO.find()
...
When post-processing result of find operation, use "async.map"
instead of "async.each + array.push" to ensure the order of items
is preserved.
2016-07-13 14:55:49 +02:00
9f0c10fdff
Add test for updateOrCreate
...
* Add test for updateOrCreate when id is not autogenerated Id
2016-07-07 12:55:22 -04:00
fbe58f7cf8
give options to validators #984
2016-06-24 14:44:43 -07:00
8117b0403f
Throw Error for property names with dots
...
Result of Compat Flags Clenup.
Throws an error for property names with dots, instead
of a deprecation warning.
2016-06-09 17:50:59 -04:00
7a8803cb38
Give warning if PK is changed in hooks
...
* Give warning if PK is changed in `before save` and `loaded`
operation hooks for replaceById
2016-06-08 11:56:19 -04:00
3daca1e960
Remove model events
2016-06-08 10:27:05 -04:00
ea2266e453
Persist changes on parent for embedsOne
...
Allow direct save of changes on embedded model to be persisted on
parent document.
Person.embedsOne(Address);
Person.findById(someId)
.then(function(p){
var address = p.addressItem();
address.street = 'new street'
// This will now persist changes on parent document
return address.save();
})
[forward-port of #949 ]
2016-06-07 17:24:59 +02:00
8f2077e344
Fix
2016-06-03 18:00:21 -04:00
cae44f0458
Fix error message
...
*Fix error message when PK is changed in `replaceById`
2016-06-01 16:16:35 -04:00
b7ba73f1b1
ModelBuilder: add new setting strictEmbeddedModels
...
The setting controls the strict mode used for embedded property types,
for example the type of "address" property in this model definition:
modelBuilder.define('TestEmbedded', {
name: 'string',
address: {
street: 'string',
},
});
2016-06-01 13:12:50 +02:00
6ec66a7e4a
Merge pull request #950 from strongloop/add_test_description
...
Add test's description
2016-06-01 09:57:53 +02:00
423db34bf3
fix error handling when applying undefined mixins
2016-05-31 12:24:04 -04:00
2b6ced06a1
Add test's description
2016-05-31 11:13:28 -04:00
d9a3f6226a
Fix incompatibility between different connectors
...
* Fix incompatibility for replace methods between different connectors.
2016-05-27 13:45:24 -04:00
0e89a9c837
fix avoid duplicate record on scope with promise
2016-05-19 15:47:31 -04:00
8ad53a4c0e
DAO.create: don't return the instance
...
Simplify DataAccessObject.create() and stop returning the
instance/array of instances. Users should always use callback (or
returned promise) to get the instance(s) created.
2016-04-29 14:16:06 +02:00
9bde8f859b
Implement operation hooks for EmbedsMany methods
...
create() triggers
- before save
- after save
updateById() triggers
- before save
- after save
destroy() triggers
- before delete
- after delete
The implementation here is intentionally left with less features
than the regular DAO methods provide, the goal is to get a partial
(but still useful!) version released soon.
Limitations:
- `before save` & `after save` hooks don't provide `ctx.isNewInstance`
- async validations are not supported yet
- `persist` and `loaded` hooks are not triggered at all
- `before delete` hook does not provide `ctx.where` property and
it's not possible to change the outcome of `destroy()` using this
hook. Note that regular DAO does support this.
- updating embedded instances triggers update of the parent (owning)
model, which is correct and expected. However, the context provided
by `before save` and `after save` hooks on the parent model is sort of
arbitrary and may include wrong/extra data. The same probably applies
to the scenario when deleting embedded instances triggers update of
the parent model.
2016-04-27 11:04:15 +02:00
b86615e2b7
Implement operation hooks for EmbedsOne methods
...
create() triggers
- before save
- after save
udpate() triggers
- before save
- after save
destroy() triggers
- before delete
- after delete
The implementation here is intentionally left with less features
than the regular DAO methods provide, the goal is to get a partial
(but still useful!) version released soon.
2016-04-20 09:36:12 +02:00
c7f34c3452
eslint config 2.0 + remove extra empty lines
...
Upgrade eslint-config-loopback to ^2.0.0.
Remove extra empty lines to make `npm run lint` pass again.
2016-04-19 16:11:43 +02:00
11ef948854
Test coverages for hashed password
...
* Test coverages for hashed password for replaceAttributes
* Test coverages for hashed password for updateAttribute
2016-04-14 18:27:19 -04:00
4e6351b856
Fix `forceId` check for `replaceById`
2016-04-14 15:05:56 -04:00
e9afb46eda
Fix `notify` bugs for `find`
2016-04-13 13:34:51 -04:00
09f4c7d026
test: extract hook-monitor helper
2016-04-13 13:54:17 +02:00
616a81b496
test: extract uid-generator helper
2016-04-13 13:53:31 +02:00
3435b43a5c
test: extract context-test-helpers
2016-04-13 13:52:54 +02:00
4bb284bb60
Define `patch` aliases
...
*Define `patchOrCreate` as an alias for `updateOrCreate`
*Define `PatchAttributes` as an alias for `updateAttributes`
2016-04-12 13:40:01 -04:00
85ed753609
Merge pull request #786 from strongloop/feature/fix-610
...
Partition by foreign key for pagination
2016-04-06 14:01:08 -07:00
84da11f98e
Partition by foreign key for pagination
...
See https://github.com/strongloop/loopback-datasource-juggler/issues/610
2016-04-05 17:21:48 -07:00
daaf5e381a
Merge branch 'discover-hang' of https://github.com/TorchlightSoftware/loopback-datasource-juggler into TorchlightSoftware-discover-hang
...
# Conflicts:
# lib/datasource.js
# test/discovery.test.js
2016-04-05 16:18:25 -07:00
e321bafdf9
Fix style errors
2016-04-05 16:11:25 -07:00
b7543e9402
Merge pull request #860 from horiaradu/master
...
fix nin support for in memory datasource
2016-04-05 15:42:07 -07:00
27c6279d6c
fix remaining eslint issues
2016-04-05 15:25:34 +02:00
39e04a1756
eslint --fix
2016-04-05 15:25:34 +02:00
fc1aefb8d4
Add eslint as "npm run lint" and "posttest" hook
2016-04-05 15:25:34 +02:00
c467b43c38
Insert copyright headers
2016-04-04 18:14:03 -07:00
5b6bffb5b3
Fix Mongo compatibility issue
...
*Fix Mongo compatibility issue for replaceOrCreate
2016-03-29 14:42:13 -04:00
8b8d474b92
Add automigrate to setup tables for replace test cases
2016-03-29 12:21:10 -04:00
fc27aa9561
Merge pull request #868 from strongloop/mySQL-fix-tests
...
Fix tests for mysql
2016-03-28 15:57:27 -04:00
57afba8c51
support custom field settings under the connector's namespace
2016-03-16 09:17:55 -07:00
024bff6a91
Fix tests for mysql
2016-03-08 20:39:25 -05:00
28e07d9df3
Add forgotten unit test
...
The test should have been added as part of #859
2016-03-02 12:32:11 +01:00
a3ae44aca0
fix nin support for in memory datasource
2016-02-27 10:27:09 +02:00
2281e95940
Implementtaion of replace
...
This includes:
*implementation of replaceAttributes
*implementtaion of replaceOrCreate
2016-02-03 16:06:35 -05:00
0d9eebe3bb
Prevent constructor to be property name
2016-02-02 11:51:05 -05:00
b556d96148
discoverSchemas returns an error when modelName is not found,
...
discoverSchema forwards that error and does not hang when no columns,
no errors are returned
2016-01-22 10:41:06 -07:00
61047a028d
Add unit test to verify fix for #754
2016-01-21 18:00:45 -08:00
ba7161b39e
Implement `findOrCreate` for memory connector
2016-01-16 18:46:53 -05:00
853ca03491
Use bluebird in utils.js
...
Replace `global.Promise` with `bluebird`
2016-01-07 15:27:33 -05:00
b509c759c4
Merge pull request #796 from strongloop/fix/various
...
Various fixes in operation hooks
2016-01-05 11:08:35 +01:00
5d453b5038
Revert "Correct syntax for should and more"
...
This reverts commit 62de2ed69e
2015-12-23 15:41:16 -08:00
b63133d1d6
Fix test for shouldjs 8.0.2 upgrade
2015-12-22 15:03:50 -08:00
e9899a93cf
Enhance "persist" hook in DAO.updateOrCreate
...
Report `ctx.isNewInstance` when the connector provides this info.
2015-12-18 16:08:38 +01:00
fd9bef4aa7
Enhance "persisted" hook in DAO.updateAttributes
...
Add `isNewInstance:false` to the context reported by
DAO.updateAttributes()
2015-12-18 16:08:01 +01:00
3028329126
"loaded" hook in DAO.find: ctx.data, not instance
...
Fix the implementation od DAO.find to provide "ctx.data" to the
"loaded" hook.
2015-12-18 15:54:35 +01:00
62de2ed69e
Correct syntax for should and more
...
This fixes lots of failures in connectors
2015-12-16 16:24:48 -05:00
9cfda16194
Fix failing test for MongoDB connector
2015-12-09 12:58:21 -08:00
80c3bd9d41
Merge pull request #752 from ernie58/optionalValidation
...
make automatic validation optional
2015-12-04 17:03:28 +01:00
0f3f27af51
Make automatic validation optional
...
Make automatic validation optional on all CRUD methods in a loopback
model. This can be done in 2 ways
- set `automaticValidation` in the model settings
- set `validate` on the options passed when calling the crud methods
The options take precedence on the model setting.
By default the automatic validation remains true to be backwards
compatible
2015-12-03 16:34:25 +01:00
6f7fc5030a
Merge branch 'fix_update_attributes_error' of https://github.com/wpjunior/loopback-datasource-juggler into wpjunior-fix_update_attributes_error
2015-11-26 09:31:40 -08:00
bd314e6a87
Merge branch 'with-simpe-and-fast-hasmany' of https://github.com/wertlex/loopback-datasource-juggler into wertlex-with-simpe-and-fast-hasmany
2015-11-23 15:21:18 -08:00
d8678a1f03
Correction of a regression introduced by commit 632898b: when querying an empty array ([]) with a 'neq' filter, there were no matching.
2015-11-23 17:09:24 +01:00
d7bbd7e215
Fix the typo
2015-11-17 13:27:41 -08:00
c26b857a87
UpdateAttributes: Raises an error if database fails
...
Signed-off-by: Wilson Júnior <wilsonpjunior@gmail.com>
2015-11-17 17:10:11 -02:00
d9918d526a
dropped unused functions and tests fixed
2015-10-30 21:36:50 +06:00
638002bc59
Looks better now
2015-10-30 21:15:48 +06:00
ef7fe45d9c
Rewrite of variable
2015-10-16 18:25:23 +02:00
7c22db6ea7
Filtering relations of a model with an order specified
2015-10-16 18:21:04 +02:00
0864bf7154
with updated map which stores original key and tests for them
2015-10-10 19:21:06 +05:00
94c3f9a432
Ability to define normalization of undefined query
...
Add datasource and model setting `normalizeUndefinedInQuery`
to determine how it will handle undefined values. Options:
- nullify : converts undefined to null
- throw : throw an error on undefined value
- ignore : strip the key where undefined value is found
The default operation is to strip the key.
2015-10-07 09:26:09 -07:00
1e035c657e
Fix the test so that it works across DBs
2015-09-11 11:15:00 -07:00
a6519bb2ca
Fix id comparision in tests so that they work with mongodb object id
2015-09-08 09:53:02 -07:00
207edd5eec
Merge pull request #687 from sklyukin/master
...
primaryKey to hasOne relation
2015-09-08 09:20:42 -07:00
fb11c78be0
Add support for using UUID V4 as defaultFn
2015-09-02 16:39:00 +02:00
d0f9b760f5
primaryKey for hasMany and belongsTo relations
2015-09-01 19:03:02 +05:00
483cd873e7
primaryKey to hasOne relation
2015-09-01 01:31:28 +05:00
cb78c8ef96
Add direct copmarison value for array matching
2015-08-27 23:56:49 -04:00
632898b022
Add support for matching array values à la mongo.
2015-08-27 23:32:53 -04:00
682f6340d3
Optimze automigrate() to cut the test time signicantly
2015-08-27 15:59:58 -07:00
57a9c40e16
Fix primary key checks
2015-08-27 13:59:43 -07:00
fb56915371
Dirty merge. Tests are broken
2015-08-24 16:07:43 +03:00
e585021586
include utils add. Tests ported to should.js
2015-08-24 15:41:04 +03:00
cd71a37bfa
Relax id requirement for basic query operations
2015-08-20 02:57:53 -07:00
0381f6d7e7
Support embedded query in memory connector. Fix memory connector bug
...
Adds support for the ability to query embedsMany models from the parent.
Fix a memory connector bug that could occur when having an "or" or "and"
clause combined with another property. In that case, the and would revert
true for 'Paul McCartney'
```
{name:'John Lennon',and: [{role:'lead'}, {vip:true}]}}
```
2015-08-18 15:56:36 -04:00
d14721656f
Merge pull request #691 from strongloop/do-not-coerce-regexp-to-string
...
Do not coerce RegExp objects to strings
2015-08-14 09:14:05 -07:00
e7e074f97b
Do not coerce RegExp objects to strings
...
Queries like `{where: {name: /John.*/i}}` should work. Notice there is no
`regexp` operator (ie. `{where: {name: {regexp: /John.*/i}}}`).
2015-08-13 16:16:48 -07:00
2120e53f7f
Indicate result of destroyById/protototype.destroy
...
Return `info.count` to the callback to indicate whether the model
instance was deleted or not. When Model's `settings.strictDelete`
is true, return 404 error when the model instance was not found.
2015-08-10 17:38:46 +02:00
90ee9a1af3
fixes issue 673: Include hasMany of relation does not return empty array
2015-07-31 14:47:22 -07:00
6513d9658f
Fix the test case with automigrate
2015-07-30 11:24:47 -07:00
c45bde7ccf
Merge pull request #647 from PradnyaBaviskar/issue-418-discover
...
Promisify all 'discover' methods
2015-07-29 07:43:39 -07:00
ce57234d5e
Merge branch 'issue656-findLoadedAsync' of https://github.com/PradnyaBaviskar/loopback-datasource-juggler into PradnyaBaviskar-issue656-findLoadedAsync
2015-07-29 07:33:21 -07:00
fee103d9d7
Remove test for unused utility function
2015-07-28 17:45:38 -07:00
b2b5a0d920
Merge pull request #665 from strongloop/add-regex-support
...
Add support for RegExp operator
2015-07-28 15:22:02 -07:00
b8f1598723
Add support for regex operator
2015-07-27 15:11:53 -07:00
de0ca3c61f
Async 'loaded' hook for find
2015-07-27 18:58:29 +05:30
c63f3fb6cb
Promisify all 'discover' methods
2015-07-24 12:07:22 +05:30
b08b6dd954
Merge pull request #650 from PradnyaBaviskar/issue-649
...
Fix 'persist' hook for updateAttributes()
2015-07-23 08:27:07 -07:00
8a20e07b3d
Fix 'persist' hook for updateAttributes()
2015-07-23 15:25:50 +05:30
ef97a9037a
Merge pull request #666 from fabien/fix/update-strict
...
Filter attributes when strict: true
2015-07-22 08:18:29 -07:00
c969e48d0c
Make sure done() is called within the callback
2015-07-21 08:07:09 -07:00
c7caa0a7c1
Take strict: validate and throw settings into account
2015-07-21 13:33:42 +02:00
8b06a9d39d
Filter attributes when strict: true
2015-07-20 11:59:07 +02:00
342bc2f782
prevent upsert overwriting default values with applyDefaultValues option
...
Creates a new applyDefaultValues option on the Model constructor
defaulting to true, the current behaviour.
Updates the dao module to pass `{ applyDefaultValues: false }` to the
Model constructor during the updateOrCreate method when we assume an
update is happening.
2015-07-14 09:08:10 -07:00
1066313f3f
use fromDb to deserialize data after save in Memory connector
...
Changes the after `save` callback in the memory connector to use the
`fromDb` method to deserialize the data passed back to upsert and
updateAttributes methods.
2015-07-14 09:08:09 -07:00
6ce47f71b4
Correctly handle validatesUniquenessOf(idName)
2015-07-13 12:56:49 +02:00
6eb18cb2f6
Make sure base property definitions are cloned
...
Sub models sometimes need to customize the properties from the base model.
This change allows each sub model has its own copy of the base property
definition to avoid potential conflicts across multiple sub models of the
same base.
2015-07-10 10:03:51 -07:00
eb20eebe95
Fix the regression for date conversion
2015-07-03 09:29:26 -07:00
5290559a42
Don't cache static scope method results #575
2015-07-03 10:35:26 +02:00
4206088fbc
Fix the regexp value for like/nlike
2015-07-02 23:22:36 -07:00
bcd477358f
Assert the existence of instance
2015-07-02 14:56:46 -07:00
eb6fa410fe
Fix coercion from ObjectID to String
2015-07-01 14:58:14 -07:00
e55469693d
test: fix persistence-hooks failures in MySQL
2015-06-24 18:31:30 +02:00
CerealGuy
Amir Jafarian
Nick Duffy
Loay
Simon Ho
Tim De Pauw
David Cheung
Miroslav Bajtoš
pponugo
Simon Ho
Sonali Samantaray
Miroslav Bajtoš
Janny
jannyHou
Richard Pringle
Supasate Choochaisri
RobinBiondi
gunjpan
Candy
Dimitris Halatsis
Alex Pitigoi
Raymond Feng
Raymond Feng
Raymond Feng
Ryan Graham
bitmage
Horia Radu
Amir Jafarian
Tom Kirkpatrick
Simon Ho
Bert Casier
Michael Diguet
Wilson Júnior
Wert_Lex
mdartic
Ryan Schumacher
Bram Borggreve
sklyukin
Laurent Villeneuve
Fabien Franzen
Kenta Fried
Simon Ho
Pradnya Baviskar
Bryan Clark
Miroslav Bajtoš