Merge pull request #3511 from strongloop/empty-password-lb3

Add unit test for empty password

.travis.yml

@@ -12,6 +12,7 @@ cache:
   directories:
     - travis_phantomjs
 before_install:
+  - npm config set registry http://ci.strongloop.com:4873/
   # Upgrade PhantomJS to v2.1.1.
   - "export PHANTOMJS_VERSION=2.1.1"
   - "export PATH=$PWD/travis_phantomjs/phantomjs-$PHANTOMJS_VERSION-linux-x86_64/bin:$PATH"

test/user.test.js

@@ -398,16 +398,31 @@ describe('User', function() {
     var pass73Char = pass72Char + '3';
     var passTooLong = pass72Char + 'WXYZ1234';
 
-    it('rejects passwords longer than 72 characters', function(done) {
+    it('rejects empty passwords creation', function(done) {
-      try {
+      User.create({email: 'b@c.com', password: ''}, function(err) {
-        User.create({email: 'b@c.com', password: pass73Char}, function(err) {
+        expect(err.code).to.equal('INVALID_PASSWORD');
-          if (err) return done(err);
+        expect(err.statusCode).to.equal(422);
-          done(new Error('User.create() should have thrown an error.'));
-        });
-      } catch (e) {
-        expect(e).to.match(/Password too long/);
         done();
-      }
+      });
+    });
+
+    it('rejects updating with empty password', function(done) {
+      User.create({email: 'blank@c.com', password: pass72Char}, function(err, userCreated) {
+        if (err) return done(err);
+        userCreated.updateAttribute('password', '', function(err, userUpdated) {
+          expect(err.code).to.equal('INVALID_PASSWORD');
+          expect(err.statusCode).to.equal(422);
+          done();
+        });
+      });
+    });
+
+    it('rejects passwords longer than 72 characters', function(done) {
+      User.create({email: 'b@c.com', password: pass73Char}, function(err) {
+        expect(err.code).to.equal('PASSWORD_TOO_LONG');
+        expect(err.statusCode).to.equal(422);
+        done();
+      });
     });
 
     it('rejects a new user with password longer than 72 characters', function(done) {