From 2e0f3d15f9d615fcf9099012d2e4f83d3c77b3be Mon Sep 17 00:00:00 2001
From: Samuel Reed <samuel.trace.reed@gmail.com>
Date: Tue, 5 Dec 2017 09:49:50 -0600
Subject: [PATCH] fix(id): replace with != null

Ref: #2356, #2374, #3130, #3693
---
 common/models/access-token.js | 2 +-
 lib/model.js                  | 4 ++--
 lib/persisted-model.js        | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/common/models/access-token.js b/common/models/access-token.js
index 707ba4ce..860ef53e 100644
--- a/common/models/access-token.js
+++ b/common/models/access-token.js
@@ -103,7 +103,7 @@ module.exports = function(AccessToken) {
 
     var id = tokenIdForRequest(req, options);
 
-    if (id) {
+    if (id != null) {
       this.findById(id, function(err, token) {
         if (err) {
           cb(err);
diff --git a/lib/model.js b/lib/model.js
index a37dd40a..89cd47c4 100644
--- a/lib/model.js
+++ b/lib/model.js
@@ -161,13 +161,13 @@ module.exports = function(registry) {
         }
       }
 
-      if (id && data) {
+      if (id != null && data) {
         var model = new ModelCtor(data);
         model.id = id;
         fn(null, model);
       } else if (data) {
         fn(null, new ModelCtor(data));
-      } else if (id) {
+      } else if (id != null) {
         var filter = {};
         ModelCtor.findById(id, filter, options, function(err, model) {
           if (err) {
diff --git a/lib/persisted-model.js b/lib/persisted-model.js
index 65e32d93..fd7d9db1 100644
--- a/lib/persisted-model.js
+++ b/lib/persisted-model.js
@@ -1683,7 +1683,7 @@ module.exports = function(registry) {
         ctx.instance, ctx.currentInstance, ctx.where, ctx.data);
     }
 
-    if (id) {
+    if (id != null) {
       ctx.Model.rectifyChange(id, reportErrorAndNext);
     } else {
       ctx.Model.rectifyAllChanges(reportErrorAndNext);
@@ -1707,7 +1707,7 @@ module.exports = function(registry) {
       debug('context instance:%j where:%j', ctx.instance, ctx.where);
     }
 
-    if (id) {
+    if (id != null) {
       ctx.Model.rectifyChange(id, reportErrorAndNext);
     } else {
       ctx.Model.rectifyAllChanges(reportErrorAndNext);