verdnatura-mirror
/
loopback
mirror of https://github.com/strongloop/loopback.git
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reorder PATCH Vs PUT endpoints 

* Reorder PATCH Vs PUT endpoints for update* methods
* Backport of #2670
This commit is contained in:
Amir Jafarian 2016-08-24 16:19:06 -04:00
parent f99e1a0242
commit 55eb8d72e6
2 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/persisted-model.js
View File

@ -633,7 +633,7 @@ module.exports = function(registry) {
}; };
if (!options.replaceOnPUT) { if (!options.replaceOnPUT) {
upsertOptions.http.push({ verb: 'put', path: '/' }); upsertOptions.http.unshift({ verb: 'put', path: '/' });
} }
setRemoting(PersistedModel, 'upsert', upsertOptions); setRemoting(PersistedModel, 'upsert', upsertOptions);
@ -797,7 +797,7 @@ module.exports = function(registry) {
setRemoting(PersistedModel.prototype, 'updateAttributes', updateAttributesOptions); setRemoting(PersistedModel.prototype, 'updateAttributes', updateAttributesOptions);
if (!options.replaceOnPUT) { if (!options.replaceOnPUT) {
updateAttributesOptions.http.push({ verb: 'put', path: '/' }); updateAttributesOptions.http.unshift({ verb: 'put', path: '/' });
} }
if (options.trackChanges || options.enableRemoteReplication) { if (options.trackChanges || options.enableRemoteReplication) {

18
test/remoting.integration.js
View File

@ -207,15 +207,25 @@ describe('With model.settings.replaceOnPUT false', function() {
var methods = getFormattedMethodsExcludingRelations(storeClass.methods); var methods = getFormattedMethodsExcludingRelations(storeClass.methods);
var expectedMethods = [ var expectedMethods = [
'upsert(data:object):storeWithReplaceOnPUTfalse PATCH /stores-updating', 'create(data:object):storeWithReplaceOnPUTfalse POST /stores-updating',
'upsert(data:object):storeWithReplaceOnPUTfalse PUT /stores-updating', 'upsert(data:object):storeWithReplaceOnPUTfalse PUT /stores-updating',
'upsert(data:object):storeWithReplaceOnPUTfalse PATCH /stores-updating',
'replaceOrCreate(data:object):storeWithReplaceOnPUTfalse POST /stores-updating/replaceOrCreate', 'replaceOrCreate(data:object):storeWithReplaceOnPUTfalse POST /stores-updating/replaceOrCreate',
'exists(id:any):boolean GET /stores-updating/:id/exists',
'exists(id:any):boolean HEAD /stores-updating/:id',
'findById(id:any,filter:object):storeWithReplaceOnPUTfalse GET /stores-updating/:id',
'replaceById(id:any,data:object):storeWithReplaceOnPUTfalse POST /stores-updating/:id/replace', 'replaceById(id:any,data:object):storeWithReplaceOnPUTfalse POST /stores-updating/:id/replace',
'prototype.updateAttributes(data:object):storeWithReplaceOnPUTfalse PATCH /stores-updating/:id', 'find(filter:object):storeWithReplaceOnPUTfalse GET /stores-updating',
'findOne(filter:object):storeWithReplaceOnPUTfalse GET /stores-updating/findOne',
'updateAll(where:object,data:object):object POST /stores-updating/update',
'deleteById(id:any):object DELETE /stores-updating/:id',
'count(where:object):number GET /stores-updating/count',
'prototype.updateAttributes(data:object):storeWithReplaceOnPUTfalse PUT /stores-updating/:id', 'prototype.updateAttributes(data:object):storeWithReplaceOnPUTfalse PUT /stores-updating/:id',
'prototype.updateAttributes(data:object):storeWithReplaceOnPUTfalse PATCH /stores-updating/:id',
'createChangeStream(options:object):ReadableStream POST /stores-updating/change-stream',
'createChangeStream(options:object):ReadableStream GET /stores-updating/change-stream',
]; ];
expect(methods).to.eql(expectedMethods);
expect(methods).to.include.members(expectedMethods);
}); });
}); });