verdnatura-mirror
/
loopback
mirror of https://github.com/strongloop/loopback.git
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2419 from strongloop/remove-legacyExplorer 

[SEMVER-MAJOR] Remove legacyExplorer
This commit is contained in:
Gunjan Pandya 2016-07-14 14:35:38 -04:00 committed by GitHub
parent 7117dbcf12 1b053d44fe
commit 7ed003e973
16 changed files with 14 additions and 93 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
server/middleware/rest.js
View File

@ -35,19 +35,6 @@ function rest() {
var app = req.app;
var registry = app.registry;
// added for https://github.com/strongloop/loopback/issues/1134
if (app.get('legacyExplorer') !== false) {
deprecate(
'Routes "/methods" and "/models" are considered dangerous and should not be used.\n' +
'Disable them by setting "legacyExplorer=false" in "server/config.json" or via "app.set()".'
);
if (req.url === '/routes') {
return res.send(app.handler('rest').adapter.allRoutes());
} else if (req.url === '/models') {
return res.send(app.remotes().toJSON());
}
}
if (!handlers) {
handlers = [];
var remotingOptions = app.get('remoting') || {};

3
test/fixtures/access-control/server/config.json vendored
View File

@ -1,11 +1,10 @@
{
"port": 3000,
"host": "0.0.0.0",
"legacyExplorer": false,
"remoting": {
"errorHandler": {
"debug": true,
"log": false
}
}
}
}

4
test/fixtures/shared-methods/both-configs-set/server/config.json vendored
View File

@ -27,7 +27,5 @@
"*": false,
"destroyAll": true
}
},
"legacyExplorer": false
}
}

4
test/fixtures/shared-methods/config-default-false/server/config.json vendored
View File

@ -26,7 +26,5 @@
"sharedMethods": {
"*": false
}
},
"legacyExplorer": false
}
}

4
test/fixtures/shared-methods/config-default-true/server/config.json vendored
View File

@ -26,7 +26,5 @@
"sharedMethods": {
"*": true
}
},
"legacyExplorer": false
}
}

4
test/fixtures/shared-methods/config-defined-false/server/config.json vendored
View File

@ -26,7 +26,5 @@
"sharedMethods": {
"find": false
}
},
"legacyExplorer": false
}
}

4
test/fixtures/shared-methods/config-defined-true/server/config.json vendored
View File

@ -26,7 +26,5 @@
"sharedMethods": {
"find": true
}
},
"legacyExplorer": false
}
}

4
test/fixtures/shared-methods/model-config-default-false/server/config.json vendored
View File

@ -23,7 +23,5 @@
"debug": true,
"log": false
}
},
"legacyExplorer": false
}
}

4
test/fixtures/shared-methods/model-config-default-true/server/config.json vendored
View File

@ -23,7 +23,5 @@
"debug": true,
"log": false
}
},
"legacyExplorer": false
}
}

4
test/fixtures/shared-methods/model-config-defined-false/server/config.json vendored
View File

@ -23,7 +23,5 @@
"debug": true,
"log": false
}
},
"legacyExplorer": false
}
}

4
test/fixtures/shared-methods/model-config-defined-true/server/config.json vendored
View File

@ -23,7 +23,5 @@
"debug": true,
"log": false
}
},
"legacyExplorer": false
}
}

1
test/fixtures/simple-app/server/config.json vendored
View File

@ -1,7 +1,6 @@
{
"port": 3000,
"host": "127.0.0.1",
"legacyExplorer": false,
"remoting": {
"errorHandler": {
"debug": true,

5
test/fixtures/simple-integration-app/server/config.json vendored
View File

@ -14,6 +14,5 @@
"debug": true,
"log": false
}
},
"legacyExplorer": false
}
}
}

5
test/fixtures/user-integration-app/server/config.json vendored
View File

@ -14,6 +14,5 @@
"debug": true,
"log": false
}
},
"legacyExplorer": false
}
}
}

1
test/replication.rest.test.js
View File

@ -502,7 +502,6 @@ describe('Replication over REST', function() {
serverApp.use(loopback.token({ model: ServerToken }));
serverApp.use(loopback.rest());
serverApp.set('legacyExplorer', false);
serverApp.set('port', 0);
serverApp.set('host', '127.0.0.1');
serverApp.listen(function() {

43
test/rest.middleware.test.js
View File

@ -27,7 +27,6 @@ describe('loopback.rest', function() {
});
it('should report 200 for DELETE /:id found', function(done) {
app.set('legacyExplorer', false);
app.model(MyModel);
app.use(loopback.rest());
MyModel.create({ name: 'm1' }, function(err, inst) {
@ -197,48 +196,6 @@ describe('loopback.rest', function() {
}, done);
});
it('should report 200 for legacy explorer route /routes', function(done) {
app.use(loopback.rest());
request(app).get('/routes')
.expect(200)
.end(function(err, res) {
if (err) return done(err);
expect(res.body).to.eql([]);
done();
});
});
it('should report 200 for legacy explorer route /models', function(done) {
app.use(loopback.rest());
request(app).get('/models')
.expect(200)
.end(function(err, res) {
if (err) return done(err);
expect(res.body).to.eql({});
done();
});
});
it('should report 404 for disabled legacy explorer route /routes', function(done) {
app.set('legacyExplorer', false);
app.use(loopback.rest());
request(app).get('/routes')
.expect(404)
.end(done);
});
it('should report 404 for disabled legacy explorer route /models', function(done) {
app.set('legacyExplorer', false);
app.use(loopback.rest());
request(app).get('/models')
.expect(404)
.end(done);
});
describe('context propagation', function() {
var User;