From c925e669f7dd6a2f83d66f10b63cc55b8a6c04da Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miroslav=20Bajto=C5=A1?= Date: Fri, 20 Feb 2015 13:02:08 +0100 Subject: [PATCH] Fix test broken by recent juggler changes The patch strongloop/loopback-datasource-juggler#436 changed the way how `Model.extend` works, which broke one loopback test relying on the old behaviour. This commit fixes the failing test. The test is checking now that the model base was not changed, instead of checking that the base is undefined. --- package.json | 4 ++-- test/loopback.test.js | 6 +++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index f084ba61..2a92f9d7 100644 --- a/package.json +++ b/package.json @@ -52,7 +52,7 @@ "underscore.string": "~2.3.3" }, "peerDependencies": { - "loopback-datasource-juggler": "^2.8.0" + "loopback-datasource-juggler": "^2.17.0" }, "devDependencies": { "browserify": "~4.2.3", @@ -79,7 +79,7 @@ "karma-phantomjs-launcher": "~0.1.4", "karma-script-launcher": "~0.1.0", "loopback-boot": "^1.1.0", - "loopback-datasource-juggler": "^2.8.0", + "loopback-datasource-juggler": "^2.17.0", "loopback-testing": "~0.2.0", "mocha": "~1.21.4", "serve-favicon": "~2.1.3", diff --git a/test/loopback.test.js b/test/loopback.test.js index 26c4f22f..bb42763a 100644 --- a/test/loopback.test.js +++ b/test/loopback.test.js @@ -344,6 +344,8 @@ describe('loopback', function() { emailVerificationRequired: false }); + var baseName = model.settings.base.name; + loopback.configureModel(model, { dataSource: null, options: { @@ -357,7 +359,9 @@ describe('loopback', function() { expect(model.settings).to.have.property('emailVerificationRequired', false); expect(model.settings).to.have.property('realmRequired', true); - expect(model.settings).to.not.have.property('base'); + + // configureModel MUST NOT change Model's base class + expect(model.settings.base.name).to.equal(baseName); }); });