verdnatura-mirror
/
loopback
mirror of https://github.com/strongloop/loopback.git
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Delete remote hooks when model is deleted

This commit is contained in:
MohammedEssehemy 2018-06-20 01:45:05 +02:00
parent 44951a1032
commit fb1160e98a
2 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/application.js
View File

@ -189,6 +189,9 @@ app.deleteModelByName = function(modelName) {
const remotes = this.remotes();
remotes.deleteClassByName(modelName);
remotes.deleteTypeByName(modelName);
Object.keys(remotes.listenerTree).forEach(hooktype=>{
delete remotes.listenerTree[hooktype][modelName];
});
if (ModelCtor && ModelCtor.dataSource) {
ModelCtor.dataSource.deleteModelByName(modelName);

20
test/app.test.js
View File

@ -806,6 +806,23 @@ describe('app', function() {
.to.not.contain('test-model');
});
it('removes the model from remoting hooks', () => {
expect(Object.keys(app.remotes().listenerTree.before))
.to.contain('test-model');
expect(Object.keys(app.remotes().listenerTree.after))
.to.contain('test-model');
expect(Object.keys(app.remotes().listenerTree.afterError))
.to.contain('test-model');
app.deleteModelByName('test-model');
expect(Object.keys(app.remotes().listenerTree.before))
.to.not.contain('test-model');
expect(Object.keys(app.remotes().listenerTree.after))
.to.not.contain('test-model');
expect(Object.keys(app.remotes().listenerTree.afterError))
.to.not.contain('test-model');
});
it('emits "modelDeleted" event', () => {
const spy = sinon.spy();
app.on('modelDeleted', spy);
@ -820,6 +837,9 @@ describe('app', function() {
name: 'test-model',
base: 'Model',
});
TestModel.beforeRemote('find', (ctx, next) => { next(); });
TestModel.afterRemote('find', (ctx, next) => { next(); });
TestModel.afterRemoteError('find', (ctx, next) => { next(); });
app.model(TestModel, {dataSource: null});
}
});