ebarault
f0e70dd8a9
Fix Role.isOwner() for multiple user models
...
Fix `Role.isOwner()` to check both principalId and principalType.
This fixes a bug where users from different User model were treated
as owners as long as their user id was the same as owner's id.
2017-02-17 11:19:07 +01:00
ebarault
a63fad402e
Add promise support to built-in model ACL
2017-01-31 14:09:43 +01:00
David Hernandez
c072d0695d
Add missing type to Role properties definition
...
Fix "created" and "modified" to be defined with type "date".
2017-01-30 11:37:33 +01:00
Miroslav Bajtoš
0fd8f8af72
Promise-ify built-in Role model
2017-01-27 17:16:59 +01:00
Benjamin Kroeger
a6d511d8b4
Role model: resolves related models by name
...
Resolve models related to the `Role` model by name instead of class.
2017-01-16 15:48:24 +01:00
Eric
b0d6c4a7d2
Add "returnOnlyRoleNames" option to Role.getRoles
...
Currently the return type of Role.getRoles() method is inconsistent:
role names are returned for smart roles and role ids are returned for
static roles (configured through user-role mapping).
This commit adds a new option to Role.getRoles() allowing the caller
to request role names to be returned for all types of roles.
2016-11-30 16:46:59 +01:00
Miroslav Bajtoš
1ec7cf0a37
Turn on "no-unused-expressions" rule for eslint
...
Fix unit-tests relying on property-based assertions to use function
calls instead, using "dirty-chai" to modify chai's property checkers.
2016-11-22 15:30:04 +01:00
Loay
06cb481c3f
Update eslint to loopback config v5
...
Notable side-effects:
- loopback no longer exports "caller" and "arguments" properties
- kv-memory connector is now properly added to the connector registry
- the file "test/support.js" was finally removed
2016-11-22 14:08:02 +01:00
codyolsen
3f5e49c3d6
Fix context within listByPrincipalType role method
...
- Fix for current implimentation that returned all models that had any
assigned roles. Context was not carried into listByPrincipalType,
setting roleId as null.
2016-11-15 14:51:05 +01:00
Miroslav Bajtoš
a751230cd9
test: increase timeout to prevent CI failures
2016-08-08 15:45:53 +02:00
Miroslav Bajtoš
5d18d41b28
test: increate timeout in Role test
2016-08-04 13:32:47 +02:00
Miroslav Bajtoš
48205fb2bd
test: fix broken Role tests
...
Rework the test suite to always report errors and correctly signal
when async tests are done.
This should prevent spurious test failures on CI servers that are
difficult to troubleshoot, because the error is reported for different
test case.
2016-08-03 16:17:58 +02:00
Simon Ho
ca1baee0f9
Merge pull request #2297 from supasate/refactor/separate-error-checking-and-next-and-done-logic-from-others
...
Separate error-checking and next/done logic from other logic
2016-05-06 13:27:29 -07:00
Supasate Choochaisri
04e26fae5c
Separate error-checking and next/done logic from other logic in the test suite
...
Signed-off-by: Supasate Choochaisri <supasate.c@gmail.com>
2016-05-05 11:12:48 +07:00
Simon Ho
1559db2ca3
Merge pull request #2269 from supasate/feature/do-not-allow-duplicate-role-name
...
Add feature to not allow duplicate role name
2016-05-04 20:42:13 -07:00
Supasate Choochaisri
dd78b36a17
Clean up by removing unnecessary comments
...
Signed-off-by: Supasate Choochaisri <supasate.c@gmail.com>
2016-05-05 08:18:32 +07:00
Supasate Choochaisri
d4a869bddf
Add feature to not allow duplicate role name
...
Signed-off-by: Supasate Choochaisri <supasate.c@gmail.com>
2016-05-05 08:18:17 +07:00
Ryan Graham
6964914bab
update copyright statements
2016-05-03 15:50:21 -07:00
Miroslav Bajtoš
35d9fa4b54
Fix role.isOwner to support app-local registry
2016-05-03 14:01:39 +02:00
juehou
dcf88baf68
Resolver support return promise
2016-05-02 17:47:14 -04:00
Miroslav Bajtoš
f9702b0ace
Use eslint with loopback config
...
Drop jshint and jscs in favour of eslint.
Fix style violations.
While we are at this, reduce the max line length from 150 to 100.
2016-04-06 10:45:30 +02:00
Raymond Feng
3eb8dd55f6
Add util methods to ACL and clean up related model resolutions
2015-08-13 08:58:41 -07:00
Raymond Feng
77bcc09107
Merge branch 'master' of https://github.com/esco/loopback into esco-master
2015-05-29 16:44:18 -07:00
Esco Obong
551261ec16
fix linting errors
2015-03-13 18:30:53 -04:00
Esco Obong
8cc558a991
consolidate Role methods roles, applications, and users into one, add query param to allow for pagination and restricting fields
2015-03-13 11:50:30 -04:00
Esco Obong
74018019b4
fix implementation of Role methods: users,roles, and applications
2015-03-12 14:58:08 -04:00
Rob Halff
36e1f6840c
fix jscs errors
2014-11-21 03:35:36 +01:00
Rob Halff
918497c365
singlequote, semicolon & /*jshint -W030 */
2014-11-21 02:46:21 +01:00
Miroslav Bajtoš
1fe0110849
Dismantle `lib/models`.
...
- Move core models `Model` and `PersistedModel` to `lib/`.
- Move `AccessContext` class to `lib/`, since it is not a model.
- Move all other built-in models to `common/models`.
This is a preparation for extracting model definitions to JSON files.
By splitting the change into multiple commits, git is able to keep track
of file moves (renames).
2014-10-13 12:09:27 +02:00
Raymond Feng
e72ff61d99
Add a test case
2014-06-10 16:39:32 -07:00
Raymond Feng
46b579dc4a
Make sure User/AccessToken relations are set up by default
...
User.login assumes the relation User.accessTokens exists
2014-02-14 10:31:30 -08:00
Raymond Feng
bcc7e68e0e
Add lookback.getModelByType() and use it resolve model deps
2014-01-23 14:39:27 -08:00
Raymond Feng
178674ec9a
Enhance getRoles() to support smart roles
2013-12-11 09:06:21 -08:00
Raymond Feng
344c74297c
Add unauthenticated role
2013-11-20 13:43:02 -08:00
Raymond Feng
2c7c5fc7ec
Start to support smart roles such as owner
2013-11-20 13:43:01 -08:00
Ritchie Martori
178e5dab30
Remove .attachTo() from tests
2013-11-19 11:02:43 -08:00
Raymond Feng
0430cd2ae3
Add tests for isInRole and getRoles
2013-11-14 21:19:56 -08:00
Raymond Feng
c3a1a85159
Add constants and more tests
2013-11-14 21:19:56 -08:00
Raymond Feng
48a0242711
Define the models/relations for ACL
2013-11-14 21:19:56 -08:00
Raymond Feng
67b934357b
Start to build the ACL models
2013-11-14 21:19:56 -08:00