From 4318b28198bbd365a72fcf7b3b066ede164f926c Mon Sep 17 00:00:00 2001 From: Robert Kawecki Date: Tue, 21 Jul 2020 13:34:59 +0200 Subject: [PATCH] Integrate falsy check into isBerWriter to avoid long inline conditions For #629 --- lib/filters/filter.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/filters/filter.js b/lib/filters/filter.js index f2e311b..fc4d061 100644 --- a/lib/filters/filter.js +++ b/lib/filters/filter.js @@ -35,7 +35,8 @@ function isFilter (filter) { } function isBerWriter (ber) { - return ( + return Boolean( + ber && typeof (ber) === 'object' && typeof (ber.startSequence) === 'function' && typeof (ber.endSequence) === 'function' @@ -44,7 +45,7 @@ function isBerWriter (ber) { function mixin (target) { target.prototype.toBer = function toBer (ber) { - if (!ber || !isBerWriter(ber)) { throw new TypeError('ber (BerWriter) required') } + if (!isBerWriter(ber)) { throw new TypeError('ber (BerWriter) required') } ber.startSequence(TYPES[this.type]) ber = this._toBer(ber)