GH-22: Client should preserve attribute type casing

lib/attribute.js

@@ -69,7 +69,7 @@ Attribute.prototype.parse = function(ber) {
   assert.ok(ber);
 
   ber.readSequence();
-  this.type = ber.readString().toLowerCase();
+  this.type = ber.readString();
 
   if (ber.peek() === Protocol.LBER_SET) {
     if (ber.readSequence(Protocol.LBER_SET)) {

lib/messages/add_request.js

@@ -63,6 +63,7 @@ AddRequest.prototype._parse = function(ber) {
   while (ber.offset < end) {
     var a = new Attribute();
     a.parse(ber);
+    a.type = a.type.toLowerCase();
     if (a.type === 'objectclass') {
       for (var i = 0; i < a.vals.length; i++)
         a.vals[i] = a.vals[i].toLowerCase();
@@ -127,7 +128,7 @@ AddRequest.prototype.attributeNames = function() {
 
 AddRequest.prototype.getAttribute = function(name) {
   if (!name || typeof(name) !== 'string')
-    throw new TypeEroror('attribute name (string) required');
+    throw new TypeError('attribute name (string) required');
 
   name = name.toLowerCase();
 

lib/messages/compare_request.js

@@ -7,7 +7,6 @@ var LDAPMessage = require('./message');
 var LDAPResult = require('./result');
 
 var dn = require('../dn');
-var Attribute = require('../attribute');
 var Protocol = require('../protocol');
 
 

lib/messages/ext_request.js

@@ -9,7 +9,6 @@ var LDAPMessage = require('./message');
 var LDAPResult = require('./result');
 
 var dn = require('../dn');
-var Attribute = require('../attribute');
 var Protocol = require('../protocol');
 
 

lib/messages/moddn_request.js

@@ -9,7 +9,6 @@ var LDAPMessage = require('./message');
 var LDAPResult = require('./result');
 
 var dn = require('../dn');
-var Attribute = require('../attribute');
 var Protocol = require('../protocol');
 
 

lib/messages/modify_request.js

@@ -56,6 +56,7 @@ ModifyRequest.prototype._parse = function(ber) {
   while (ber.offset < end) {
     var c = new Change();
     c.parse(ber);
+    c.modification.type = c.modification.type.toLowerCase();
     this.changes.push(c);
   }
 

tst/client.test.js

@@ -82,7 +82,7 @@ test('setup', function(t) {
         objectName: req.dn,
         attributes: {
           cn: ['unit', 'test'],
-          sn: 'testy'
+          SN: 'testy'
         }
       });
       res.send(e);
@@ -345,6 +345,8 @@ test('search basic', function(t) {
       t.equal(entry.dn.toString(), 'cn=test, ' + SUFFIX);
       t.ok(entry.attributes);
       t.ok(entry.attributes.length);
+      t.equal(entry.attributes[0].type, 'cn');
+      t.equal(entry.attributes[1].type, 'SN');
       t.ok(entry.object);
       gotEntry++;
     });