From 7b869f4a9d3b187e26ee72300f32589342181d9c Mon Sep 17 00:00:00 2001 From: James Sumners Date: Tue, 15 Aug 2023 09:01:59 -0400 Subject: [PATCH] Resolve issue #924 --- .github/workflows/integration.yml | 2 +- docker-compose.yml | 2 +- test-integration/client/issues.test.js | 9 ++++++++- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index 90b77b8..2a3a14e 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -20,7 +20,7 @@ jobs: services: openldap: - image: ghcr.io/ldapjs/docker-test-openldap/openldap:2023-03-18 + image: ghcr.io/ldapjs/docker-test-openldap/openldap:2023-08-15 ports: - 389:389 - 636:636 diff --git a/docker-compose.yml b/docker-compose.yml index 056d338..0a7e335 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -1,6 +1,6 @@ services: openldap: - image: ghcr.io/ldapjs/docker-test-openldap/openldap:2023-03-18 + image: ghcr.io/ldapjs/docker-test-openldap/openldap:2023-08-15 ports: - 389:389 - 636:636 diff --git a/test-integration/client/issues.test.js b/test-integration/client/issues.test.js index 617549c..ab10d11 100644 --- a/test-integration/client/issues.test.js +++ b/test-integration/client/issues.test.js @@ -10,7 +10,14 @@ const PORT = process.env.PORT || 389 const baseURL = `${SCHEME}://${HOST}:${PORT}` tap.test('modifyDN with long name (issue #480)', t => { - const longStr = 'a292979f2c86d513d48bbb9786b564b3c5228146e5ba46f404724e322544a7304a2b1049168803a5485e2d57a544c6a0d860af91330acb77e5907a9e601ad1227e80e0dc50abe963b47a004f2c90f570450d0e920d15436fdc771e3bdac0487a9735473ed3a79361d1778d7e53a7fb0e5f01f97a75ef05837d1d5496fc86968ff47fcb64' + // 2023-08-15: disabling this 265 character string until a bug can be + // fixed in OpenLDAP. See https://github.com/ldapjs/docker-test-openldap/blob/d48bc2fb001b4ed9a152715ced4a2cb120439ec4/bootstrap/slapd-init.sh#L19-L31. + // const longStr = 'a292979f2c86d513d48bbb9786b564b3c5228146e5ba46f404724e322544a7304a2b1049168803a5485e2d57a544c6a0d860af91330acb77e5907a9e601ad1227e80e0dc50abe963b47a004f2c90f570450d0e920d15436fdc771e3bdac0487a9735473ed3a79361d1778d7e53a7fb0e5f01f97a75ef05837d1d5496fc86968ff47fcb64' + + // 2023-08-15: this 140 character string satisfies the original issue + // (https://github.com/ldapjs/node-ldapjs/issues/480) and avoids a bug + // in OpenLDAP 2.5. + const longStr = '292979f2c86d513d48bbb9786b564b3c5228146e5ba46f404724e322544a7304a2b1049168803a5485e2d57a544c6a0d860af91330acb77e5907a9e601ad1227e80e0dc50ab' const targetDN = 'cn=Turanga Leela,ou=people,dc=planetexpress,dc=com' const client = ldapjs.createClient({ url: baseURL }) client.bind('cn=admin,dc=planetexpress,dc=com', 'GoodNewsEveryone', bindHandler)