verdnatura-mirror
/
node-ldapjs
mirror of https://github.com/ldapjs/node-ldapjs.git
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #405 from pbatey/master 

destroy socket if auto-bind fails
This commit is contained in:
James Sumners 2019-08-26 07:52:22 -04:00 committed by GitHub
parent 95ee4f595d 5f21dbf4cd
commit ac55fba157
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/client/client.js
View File

@ -348,6 +348,9 @@ function Client(options) {
this.on('setup', function (clt, cb) { this.on('setup', function (clt, cb) {
clt.bind(options.bindDN, options.bindCredentials, function (err) { clt.bind(options.bindDN, options.bindCredentials, function (err) {
if (err) { if (err) {
if (self._socket) {
self._socket.destroy()
}
self.emit('error', err); self.emit('error', err);
} }
cb(err); cb(err);

1
test/client.test.js
View File

@ -334,6 +334,7 @@ test('auto-bind bad credentials', function (t) {
}); });
clt.once('error', function (err) { clt.once('error', function (err) {
t.equal(err.code, ldap.LDAP_INVALID_CREDENTIALS); t.equal(err.code, ldap.LDAP_INVALID_CREDENTIALS);
t.ok(clt._socket.destroyed, 'expect socket to be destroyed');
clt.destroy(); clt.destroy();
t.end(); t.end();
}); });