Apply suggestions from code review

This commit is contained in:
James Sumners 2021-05-21 08:04:41 -04:00 committed by GitHub
parent b860932b9b
commit c2494eca00
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions

View File

@ -555,7 +555,7 @@ $ ldapsearch -H ldap://localhost:389 -x -D cn=demo,dc=example,dc=com \
This example demonstrates multi-threading via the `cluster` module utilizing a `net` server for initial socket receipt. An alternate example demonstrating use of the `connectionRouter` `serverOptions` hook is available in the `examples` directory. This example demonstrates multi-threading via the `cluster` module utilizing a `net` server for initial socket receipt. An alternate example demonstrating use of the `connectionRouter` `serverOptions` hook is available in the `examples` directory.
``` ```js
const cluster = require('cluster'); const cluster = require('cluster');
const ldap = require('ldapjs'); const ldap = require('ldapjs');
const net = require('net'); const net = require('net');

View File

@ -314,6 +314,8 @@ function Server (options) {
} }
self.newConnection = function (conn) { self.newConnection = function (conn) {
// TODO: make `newConnection` available on the `Server` prototype
// https://github.com/ldapjs/node-ldapjs/pull/727/files#r636572294
setupConnection(conn) setupConnection(conn)
log.trace('new connection from %s', conn.ldap.id) log.trace('new connection from %s', conn.ldap.id)