Commit Graph

744 Commits

Author SHA1 Message Date
Robert Kawecki 4318b28198 Integrate falsy check into isBerWriter to avoid long inline conditions
For #629
2020-07-21 13:34:59 +02:00
Robert Kawecki b0b5e935c7 Add duck-type check for BerWriter in filter#toBer mixin
For #629
2020-07-17 09:19:10 +02:00
Robert Kawecki 3c5138de26 Remove instanceof check in filter#toBer mixin
For #629
2020-07-17 09:19:10 +02:00
James Sumners 8b70279c57
Merge pull request #631 from ldapjs/jsumners-patch-1
Update main CI
2020-07-16 19:28:13 -04:00
James Sumners 09b128b79e
Update main CI
Trying to resolve https://github.com/coverallsapp/github-action/issues/26

Also a couple other updates.
2020-07-16 19:24:50 -04:00
James Stenhouse 6efc5e0c43 fix spaces in returned ObjectName 2020-07-04 19:05:59 +10:00
James Sumners e54555ae0a
Merge pull request #620 from ldapjs/next
Release v2!
2020-05-31 09:10:01 -04:00
James Sumners d773365909
Merge pull request #619 from ldapjs/release-v2
Prep v2 release
2020-05-31 09:04:45 -04:00
James Sumners 2a6d2be047
v2.0.0 2020-05-31 08:59:56 -04:00
James Sumners 3db991ba9f
Update changelog 2020-05-31 08:58:50 -04:00
James Sumners d8c428f1d5
Merge pull request #615 from rkaw92/612-tests-unused-tcp-port 2020-05-21 08:05:42 -04:00
Robert Kawecki c9be815d4f Use a random TCP port for testing timeouts/rejects
This fixes a test failure when the host has something listening
on the LDAP TCP port. Previously, the test cases would assume
that the port was free and they would not connect.

For #612
2020-05-20 23:20:06 +02:00
James Sumners e14cf696a0
Merge pull request #613 from greatcare/611-search-request-space-in-dn
Remove spaces from DNs in SearchRequest
2020-05-15 17:41:04 -04:00
Robert Kawecki a9a2d5396f
Merge branch 'next' into 611-search-request-space-in-dn 2020-05-13 17:07:10 +02:00
Robert Kawecki 6b092cf70f Remove spaces from DNs in SearchRequest
This change fixes how DNs are serialized into BER for SearchRequest messages.
It drops spaces around commas, since it breaks some LDAP servers that expect
the DN to be separated by comma only as per RFC 4514. The old format of
spaced separators from LDAPv2 is thus no longer used.

For #611
2020-05-13 17:01:00 +02:00
James Sumners c114fc3112
Merge pull request #610 from greatcare/next 2020-05-13 08:05:58 -04:00
Robert Kawecki 5204bb7ac0 Implement queueing events until a listener appears
This resolves an issue arising from using both a callback and an EventEmitter
together in the Client.search() API. Since the emitter would only be available
through the callback, some events could be emitted before the callback
is triggered, resulting in missed events.

This change incorporates a test case originally by László Szűcs (@ifroz).

For GH-602
2020-05-12 16:51:28 +02:00
James Sumners a67303e7a4
Merge pull request #598 from jonekdahl/issue-415
Add server.getConnections (fix #415)
2020-02-20 07:51:28 -05:00
Jon Ekdahl 7c00ca8188 Add server.getConnections (fix #415)
Add LDAP server method that delegates to node server.getConnection.
2020-02-19 20:02:57 +01:00
James Sumners 8384a4736f
Merge pull request #587 from ldapjs/bump-v2.0.0-pre.5
v2.0.0-pre.5
2019-12-15 08:35:44 -05:00
James Sumners fee197ed43
v2.0.0-pre.5 2019-12-15 08:31:22 -05:00
James Sumners f690493768
Merge pull request #574 from TPXP/fix-bind-crash
Handle connection refused and connection timeouts gracefully
2019-12-15 08:29:54 -05:00
James Sumners 2901e48cb4
Merge branch 'next' into fix-bind-crash 2019-12-15 08:25:23 -05:00
James Sumners 68301be4cb
Merge pull request #586 from ldapjs/bump-v2.0.0-pre.4
v2.0.0-pre.4
2019-12-07 10:50:49 -05:00
James Sumners 5ed1a32cd7
v2.0.0-pre.4 2019-12-07 10:44:06 -05:00
James Sumners f4b14ec305
Merge pull request #584 from luddd3/next
refactor: resultError always emitted on errors
2019-12-07 10:42:20 -05:00
James Sumners f93234e751
Merge branch 'next' into next 2019-12-07 10:38:35 -05:00
James Sumners 1395ce801d
Merge pull request #585 from ldapjs/update-integration-suite
Update image reference
2019-12-07 10:36:54 -05:00
James Sumners cd9a9fe37f
Add integration test for issue #582 2019-12-07 10:33:02 -05:00
James Sumners abef455323
Lock tap version until bug is resolved 2019-12-07 10:01:03 -05:00
James Sumners c4fc432a80
Disable useless tap features 2019-12-07 09:54:29 -05:00
James Sumners 76469c80a4
Update image reference 2019-12-07 09:48:41 -05:00
Mathias Lundell d7d2e99275 refactor: resultError always emitted on error 2019-12-03 17:14:05 +01:00
Thomas P 9a3c7bab61
Merge branch 'next' into fix-bind-crash 2019-11-24 16:33:37 +01:00
James Sumners 5354e9cda6
Merge pull request #580 from ldapjs/jsumners-patch-1
Fix coveralls config
2019-11-18 07:22:07 -05:00
James Sumners 7d39706294
Fix coveralls config 2019-11-18 07:17:36 -05:00
James Sumners 4fa7ca061b
Merge pull request #579 from ldapjs/bump-v2.0.0-pre.3
v2.0.0-pre.3
2019-11-16 10:54:02 -05:00
James Sumners 6d44d409e4
v2.0.0-pre.3 2019-11-16 10:49:11 -05:00
James Sumners 1f12eca334
Add integration tests (#571)
* Initial integration test, um, test

* Hack in service

* Add integration test for issue #480

* Add fix for issue #418

* Add fix for issue #370
2019-11-16 10:48:00 -05:00
Thomas P 5afa677209
Also test timeout cases 2019-10-12 00:36:37 +02:00
Thomas P c27e14960e
Avoid handling all errors now that blocking errors are handled properly 2019-10-12 00:35:19 +02:00
Thomas P eda98986f2
FIX: Refused connections are now handled gracefully 2019-10-12 00:34:27 +02:00
Thomas P d702c455bd
Refactor the patch to limit its scope to bind actions
This way, other tests keep passing
2019-10-11 23:23:46 +02:00
Thomas P 53d6b36bb2
Add test for connection refused issue 2019-10-11 23:23:05 +02:00
Thomas P bc61f67b12
Lint fixes 2019-10-11 22:54:53 +02:00
Thomas P ce243d5318
Update the patch to use the logger interface 2019-10-11 22:42:44 +02:00
Matthew Nakama 79f3625f61
handle Client.emit('error') events
This prevents node crashes from Client.bind() and etc.
We set a callback handler in the instance during bind()
and send errors to it.
2019-10-11 22:41:17 +02:00
James Sumners 0ccbec6adb
Merge pull request #569 from ldapjs/client-options-tweaks
Clean up options checking and add some tests
2019-09-29 09:15:20 -04:00
James Sumners 5a31abaed0
Clean up options checking and add some tests 2019-09-29 09:09:18 -04:00
James Sumners eb4f665983
Merge pull request #553 from Worteks/next-vls-controls
Added support for Virtual List View (vlv) control for browsing directory using paged search
2019-09-29 09:08:53 -04:00