9b1a10fff0
Merge branch 'master' into master
2021-05-27 14:13:56 -05:00
79c1b4ccf3
Merge branch 'master' into master
2021-05-27 14:08:37 -05:00
e74ba91238
feat: now search callback response will emit SearchRequest after every search request is sent
2021-05-24 12:34:32 +08:00
c2494eca00
Apply suggestions from code review
2021-05-21 08:04:41 -04:00
992be5a557
adding connectionRouter hook
...
adding connectionRouter hook back in
2021-05-20 10:35:13 -04:00
6cce4f60cc
removing hook while keeping newConnection change
...
removal of hook while keeping `newConnection` change from private to public for use in multithreaded applications
2021-05-20 07:21:52 -04:00
bca931a4cd
connection router to accomodate multithreading
...
connection router hook added to accommodate multithreaded servers
2021-05-19 14:36:51 -04:00
e07656b233
SearchPager: Implement queueing events until a listener appears
...
This fixes the same problems for paged searches as does
https://github.com/ldapjs/node-ldapjs/pull/610 for unpaged searches.
By passing an EventEmitter via callback there exist cases when events
are emitted before listeners are registered, resulting in missed
events.
The Change turns SearchPager into a CorkedEmitter which is already
used as a solution for non paged searches. Doing so requires the
internal 'search' event to be dropped.
This change adapts a test case originally by László Szűcs (@ifroz).
Signed-off-by: Philippe Seewer <philippe.seewer@bfh.ch>
2021-05-07 14:04:37 +02:00
bb475ab00f
fix: emit error event if other error events are not listened to
2021-02-23 17:23:56 -06:00
de9926a329
chore(lint): fix no-unused-vars errors
2020-12-06 19:26:27 -06:00
2489d87079
chore(lint): lint lib/
2020-12-06 11:10:58 -06:00
217b984839
Fix crash in res.send()
...
In commit c6fa25985b
2020-12-02 14:44:33 -08:00
95b4ebd618
Remove use of logging methods in conditional tests
2020-11-12 12:38:56 -05:00
c6fa25985b
update devdependency standard to v16
2020-10-31 16:07:32 -05:00
07555253ac
chore(lint): fix linting errors
2020-10-24 16:22:11 +00:00
cf29972990
fix
2020-09-18 15:36:12 +02:00
c861135f80
Don't randomize first server
2020-09-18 15:32:22 +02:00
f3804bbca6
cr
2020-09-18 06:15:25 +02:00
d32a765ee9
cr
2020-09-17 17:49:58 +02:00
f0c864ca85
Revert redundant changes
2020-09-17 16:58:16 +02:00
23e44b2959
cr
2020-09-17 16:46:34 +02:00
f9ae5c12d8
Add test
2020-09-17 07:05:21 +02:00
3ca2c265da
Support for arrays in url parameter
2020-09-17 06:28:03 +02:00
7d52f867a0
Client support multiple servers
2020-09-16 14:06:26 +02:00
53c6275610
Merge branch 'master' into 645-search-response-spaces-dn
2020-07-28 08:53:58 +10:00
d2c5464bc2
no need to create instance
2020-07-21 20:28:15 -05:00
1a09e62eda
Make false check explicit in isBerWriter comparison
...
Co-authored-by: James Sumners <james@sumners.email>
2020-07-21 13:51:49 +02:00
4318b28198
Integrate falsy check into isBerWriter to avoid long inline conditions
...
For #629
2020-07-21 13:34:59 +02:00
b0b5e935c7
Add duck-type check for BerWriter in filter#toBer mixin
...
For #629
2020-07-17 09:19:10 +02:00
3c5138de26
Remove instanceof check in filter#toBer mixin
...
For #629
2020-07-17 09:19:10 +02:00
6efc5e0c43
fix spaces in returned ObjectName
2020-07-04 19:05:59 +10:00
6b092cf70f
Remove spaces from DNs in SearchRequest
...
This change fixes how DNs are serialized into BER for SearchRequest messages.
It drops spaces around commas, since it breaks some LDAP servers that expect
the DN to be separated by comma only as per RFC 4514. The old format of
spaced separators from LDAPv2 is thus no longer used.
For #611
2020-05-13 17:01:00 +02:00
5204bb7ac0
Implement queueing events until a listener appears
...
This resolves an issue arising from using both a callback and an EventEmitter
together in the Client.search() API. Since the emitter would only be available
through the callback, some events could be emitted before the callback
is triggered, resulting in missed events.
This change incorporates a test case originally by László Szűcs (@ifroz).
For GH-602
2020-05-12 16:51:28 +02:00
7c00ca8188
Add server.getConnections ( fix #415 )
...
Add LDAP server method that delegates to node server.getConnection.
2020-02-19 20:02:57 +01:00
2901e48cb4
Merge branch 'next' into fix-bind-crash
2019-12-15 08:25:23 -05:00
d7d2e99275
refactor: resultError always emitted on error
2019-12-03 17:14:05 +01:00
9a3c7bab61
Merge branch 'next' into fix-bind-crash
2019-11-24 16:33:37 +01:00
1f12eca334
Add integration tests ( #571 )
...
* Initial integration test, um, test
* Hack in service
* Add integration test for issue #480
* Add fix for issue #418
* Add fix for issue #370
2019-11-16 10:48:00 -05:00
c27e14960e
Avoid handling all errors now that blocking errors are handled properly
2019-10-12 00:35:19 +02:00
eda98986f2
FIX: Refused connections are now handled gracefully
2019-10-12 00:34:27 +02:00
d702c455bd
Refactor the patch to limit its scope to bind actions
...
This way, other tests keep passing
2019-10-11 23:23:46 +02:00
bc61f67b12
Lint fixes
2019-10-11 22:54:53 +02:00
ce243d5318
Update the patch to use the logger interface
2019-10-11 22:42:44 +02:00
79f3625f61
handle Client.emit('error') events
...
This prevents node crashes from Client.bind() and etc.
We set a callback handler in the instance during bind()
and send errors to it.
2019-10-11 22:41:17 +02:00
5a31abaed0
Clean up options checking and add some tests
2019-09-29 09:09:18 -04:00
fa6ffb4504
Merge branch 'next' into next-vls-controls
2019-09-21 17:55:30 +02:00
ecfefa7ff0
fix escapedToHex capturing \
2019-09-18 14:35:10 -05:00
db8d5f5ccb
Merge branch 'next' into next-vls-controls
2019-09-08 07:34:14 -04:00
06b1804d32
Ensure toString is not called on buffers
2019-09-06 11:27:37 +01:00
311c94ef15
Virtual List View control support
2019-09-04 12:13:51 +02:00
Tony Brix
zhaoyunfeng
James Sumners
CoryGH
Philippe Seewer
Girish Ramakrishnan
Telepsis
Martin Cizek
spookiej
Robert Kawecki
Robert Kawecki
James Stenhouse
Jon Ekdahl
Mathias Lundell
Thomas P
Thomas P
Matthew Nakama
Soisik Froger
sinistersig