verdnatura-chat/ios/Pods/Flipper-Folly/folly/Subprocess.h

1013 lines
35 KiB
C
Raw Normal View History

Merge beta into master (#2143) * [FIX] Messages being sent but showing as temp status (#1469) * [FIX] Missing messages after reconnect (#1470) * [FIX] Few fixes on themes (#1477) * [I18N] Missing German translations (#1465) * Missing German translation * adding a missing space behind colon * added a missing space after colon * and another attempt to finally fix this – got confused by all the branches * some smaller fixes for the translation * better wording * fixed another typo * [FIX] Crash while displaying the attached image with http on file name (#1401) * [IMPROVEMENT] Tap app and server version to copy to clipboard (#1425) * [NEW] Reply notification (#1448) * [FIX] Incorrect background color login on iPad (#1480) * [FIX] Prevent multiple tap on send (Share Extension) (#1481) * [NEW] Image Viewer (#1479) * [DOCS] Update Readme (#1485) * [FIX] Jitsi with Hermes Enabled (#1523) * [FIX] Draft messages not working with themed Messagebox (#1525) * [FIX] Go to direct message from members list (#1519) * [FIX] Make SAML wait for idp token instead of creating it on client (#1527) * [FIX] Server Test Push Notification (#1508) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [CHORE] Update to new server response (#1509) * [FIX] Insert messages with blank users (#1529) * Bump version to 4.2.1 (#1530) * [FIX] Error when normalizing empty messages (#1532) * [REGRESSION] CAS (#1570) * Bump version to 4.2.2 (#1571) * [FIX] Add username block condition to prevent error (#1585) * Bump version to 4.2.3 * Bump version to 4.2.4 * Bump version to 4.3.0 (#1630) * [FIX] Channels doesn't load (#1586) * [FIX] Channels doesn't load * [FIX] Update roomsUpdatedAt when subscriptions.length is 0 * [FIX] Remove unnecessary changes * [FIX] Improve the code Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Make SAML to work on Rocket.Chat < 2.3.0 (#1629) * [NEW] Invite links (#1534) * [FIX] Set the http-agent to the form that Rocket.Chat requires for logging (#1482) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] "Following thread" and "Unfollowed Thread" is hardcoded and not translated (#1625) * [FIX] Disable reset button if form didn't changed (#1569) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Header title of RoomInfoView (#1553) * [I18N] Gallery Permissions DE (#1542) * [FIX] Not allow to send messages to archived room (#1623) * [FIX] Profile fields automatically reset (#1502) * [FIX] Show attachment on ThreadMessagesView (#1493) * [NEW] Wordpress auth (#1633) * [CHORE] Add Start Packager script (#1639) * [CHORE] Update RN to 0.61.5 (#1638) * [CHORE] Update RN to 0.61.5 * [CHORE] Update react-native patch Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> * Bump version to 4.3.1 (#1641) * [FIX] Change force logout rule (#1640) * Bump version to 4.4.0 (#1643) * [IMPROVEMENT] Use MessagingStyle on Android Notification (#1575) * [NEW] Request review (#1627) * [NEW] Pull to refresh RoomView (#1657) * [FIX] Unsubscribe from room (#1655) * [FIX] Server with subdirs (#1646) * [NEW] Clear cache (#1660) * [IMPROVEMENT] Memoize and batch subscriptions updates (#1642) * [FIX] Disallow empty sharing (#1664) * [REGRESSION] Use HTTPS links for sharing and markets protocol for review (#1663) * [FIX] In some cases, share extension doesn't load images (#1649) * [i18n] DE translations for new invite function and some minor fixes (#1631) * [FIX] Remove duplicate jetify step (#1628) minor: also remove 'cd' calls Co-authored-by: Diego Mello <diegolmello@gmail.com> * [REGRESSION] Read messages (#1666) * [i18n] German translations missing (#1670) * [FIX] Notifications crash on older Android Versions (#1672) * [i18n] Added Dutch translation (#1676) * [NEW] Omnichannel Beta (#1674) * [NEW] Confirm logout/clear cache (#1688) * [I18N] Add es-ES language (#1495) * [NEW] UiKit Beta (#1497) * [IMPROVEMENT] Use reselect (#1696) * [FIX] Notification in Android API level less than 24 (#1692) * [IMPROVEMENT] Send tmid on slash commands and media (#1698) * [FIX] Unhandled action on UIKit (#1703) * [NEW] Pull to refresh RoomsList (#1701) * [IMPROVEMENT] Reset app when language is changed (#1702) * [FIX] Small fixes on UIKit (#1709) * [FIX] Spotlight (#1719) * [CHORE] Update react-native-image-crop-picker (#1712) * [FIX] Messages Overlapping (Android) and MessageBox Scroll (iOS) (#1720) * [REGRESSION] Remove @ and # from mention (#1721) * [NEW] Direct message from user info (#1516) * [FIX] Delete slash commands (#1723) * [IMPROVEMENT] Hold URL to copy (#1684) * [FIX] Different sourcemaps generation for Hermes (#1724) * [FIX] Different sourcemaps generation for Hermes * Upload sourcemaps after build * [REVERT] Show emoji keyboard on Android (#1738) * [FIX] Stop logging react-native-image-crop-picker (#1745) * [FIX] Prevent toast ref error (#1744) * [FIX] Prevent reaction map error (#1743) * [FIX] Add missing calls to user info (#1741) * [FIX] Catch room unsubscribe error (#1739) * [i18n] Missing German keys (#1735) * [FIX] Missing i18n on MessagesView title (#1733) * [FIX] UIKit Modal: Weird behavior on Android Tablet (#1742) * [i18n] Missing key on German (#1747) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [i18n] Add Italian (#1736) * [CHORE] Memory leaks investigation (#1675) * [IMPROVEMENT] Alert verify email when enabled (#1725) * [NEW] Jitsi JWT added to URL (#1746) * [FIX] UIKit submit when connection lost (#1748) * Bump version to 4.5.0 (#1761) * [NEW] Default browser (#1752) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] HTTP Basic Auth (#1753) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [IMPROVEMENT] Honor profile fields edit settings (#1687) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [IMPROVEMENT] Room announcements (#1726) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [IMPROVEMENT] Honor Register/Login settings (#1727) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [IMPROVEMENT] Make links clickable on Room Info (#1730) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [NEW] Hide system messages (#1755) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [IMPROVEMENT] Honor "Message_AudioRecorderEnabled" (#1764) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [i18n] Missing de keys (#1765) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Redirect user to SetUsernameView (#1728) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Join Room (#1769) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Accept all media types using * (#1770) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Use RealName when necessary (#1758) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Markdown Line Break (#1783) * [IMPROVEMENT] Remove useMarkdown (#1774) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [IMPROVEMENT] Open browser rather than webview on Create Workspace (#1788) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [IMPROVEMENT] Markdown perf (#1796) * [FIX] Stop video when modal is closed (#1787) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Hide reply notification action when there are missing data (#1771) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [i18n] Added Japanese translation (#1781) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Reset password error message (#1772) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Close tablet modal (#1773) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Setting not present (#1775) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Thread header (#1776) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Keyboard tracking loses input ref (#1784) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [NEW] Mark message as unread (#1785) Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> * [IMPROVEMENT] Log server version (#1786) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [IMPROVEMENT] Add loading message on long running tasks (#1798) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [CHORE] Switch Apple account on Fastlane (#1810) * [FIX] Watermelon throwing "Cannot update a record with pending updates" (#1754) * [FIX] Detox tests (#1790) * [CHORE] Use markdown preview on RoomView Header (#1807) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] LoginSignup blink services (#1809) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [IMPROVEMENT] Request user presence on demand (#1813) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Remove all invited users when create a channel (#1814) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Pop from room which you have been removed (#1819) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Room Info styles (#1820) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [i18n] Add missing German keys (#1800) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Empty mentions for @all and @here when real name is enabled (#1822) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [TESTS] Markdown added to Storybook (#1812) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [REGRESSION] Room View header title (#1827) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Storybook snapshots (#1831) Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> * [FIX] Mentions (#1829) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Thread message not found (#1830) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Separate delete and remove channel (#1832) * Rename to delete room * Separate delete and remove channel * handleRemoved -> handleRoomRemoved * [FIX] Navigate to RoomsList & Handle tablet case Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> * [NEW] Filter system messages per room (#1815) Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] e2e tests (#1838) * [FIX] Consecutive clear cache calls freezing app (#1851) * Bump version to 4.5.1 (#1853) * [FIX][iOS] Ignore silent mode on audio player (#1862) * [IMPROVEMENT] Create App Group property on Info.plist (#1858) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [IMPROVEMENT] Make username clickable on message (#1618) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Show proper error message on profile (#1768) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [IMPROVEMENT] Show toast when a message is starred/unstarred (#1616) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Incorrect size params to avatar endpoint (#1875) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Remove unrecognized emoji flags on android (#1887) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Remove react-native global installs (#1886) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Emojis transparent on android (#1881) Co-authored-by: Diego Mello <diegolmello@gmail.com> * Bump acorn from 5.7.3 to 5.7.4 (#1876) Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](https://github.com/acornjs/acorn/compare/5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Diego Mello <diegolmello@gmail.com> * Bump version to 4.6.0 (#1911) * [FIX] Encode Image URI (#1909) * [FIX] Encode Image URI * [FIX] Check if Image is Valid Co-authored-by: Diego Mello <diegolmello@gmail.com> * [NEW] Adaptive Icons (#1904) * Remove unnecessary stuff from debug build * Adaptive icon for experimental app * [FIX] Stop showing message on leave channel (#1896) * [FIX] Leave room don't show 'was removed' message * [FIX] Remove duplicated code Co-authored-by: Diego Mello <diegolmello@gmail.com> * [i18n] Added missing German translations(#1900) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Linkedin OAuth login (#1913) * [CHORE] Fix typo in CreateChannel View (#1930) * [FIX] Respect protocol in HTTP Auth IPs (#1933) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Use new LinkedIn OAuth url (#1935) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [CHORE] Use storyboard on splash screen (#1939) * Update react-native-bootsplash * iOS * Fix android * [FIX] Check if avatar exists before create Icon (#1927) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Ignore self typing event (#1950) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Change default directory listing to Users (#1948) * fix: change default directory listing to Users * follow server settings * Fix state to props Co-authored-by: Diego Mello <diegolmello@gmail.com> * [NEW] Onboarding layout (#1954) * Onboarding texts * OnboardingView * FormContainer * Minor fixes * NewServerView * Remove code * Refactor * WorkspaceView * Stash * Login with email working * Login with * Join open * Revert "Login with" This reverts commit d05dc507d2e9a2db76d433b9b1f62192eba35dbd. * Fix create account styles * Register * Refactor * LoginServices component * Refactor * Multiple servers * Remove native images * Refactor styles * Fix testid * Fix add server on tablet * i18n * Fix close modal * Fix TOTP * [FIX] Registration disabled * [FIX] Login Services separator * Fix logos * Fix AppVersion name * I18n * Minor fixes * [FIX] Custom Fields Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> * [NEW] Create discussions (#1942) * [WIP][NEW] Create Discussion * [FIX] Clear multiselect & Translations * [NEW] Create Discussion at MessageActions * [NEW] Disabled Multiselect * [FIX] Initial channel * [NEW] Create discussion on MessageBox Actions * [FIX] Crashing on edit name * [IMPROVEMENT] New message layout * [CHORE] Update README * [NEW] Avatars on MultiSelect * [FIX] Select Users * [FIX] Add redirect and Handle tablet * [IMPROVEMENT] Split CreateDiscussionView * [FIX] Create a discussion inner discussion * [FIX] Create a discussion * [I18N] Add pt-br * Change icons * [FIX] Nav to discussion & header title * Fix header Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Load messages (#1910) * Create updateLastOpen param on readMessages * Remove InteractionManager from load messages * [NEW] Custom Status (#1811) * [NEW] Custom Status * [FIX] Subscribe to changes * [FIX] Improve code using Banner component * [IMPROVEMENT] Toggle modal * [NEW] Edit custom status from Sidebar * [FIX] Modal when tablet * [FIX] Styles * [FIX] Switch to react-native-promp-android * [FIX] Custom Status UI * [TESTS] E2E Custom Status * Fix banner * Fix banner * Fix subtitle * status text * Fix topic header * Fix RoomActionsView topic * Fix header alignment on Android * [FIX] RoomInfo crashes when without statusText * [FIX] Use users.setStatus * [FIX] Remove customStatus of ProfileView * [FIX] Room View Thread Header Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] UI issues of Create Discussion View (#1965) * [NEW] Direct Message between multiple users (#1958) * [WIP] DM between multiple users * [WIP][NEW] Create new DM between multiple users * [IMPROVEMENT] Improve createChannel Sagas * [IMPROVEMENT] Selected Users view * [IMPROVEMENT] Room Actions of Group DM * [NEW] Create new DM between multiple users * [NEW] Group DM avatar * [FIX] Directory border * [IMPROVEMENT] Use isGroupChat * [CHORE] Remove legacy getRoomMemberId * [NEW] RoomTypeIcon * [FIX] No use legacy method on RoomInfoView * [FIX] Blink header when create new DM * [FIX] Only show create direct message option when allowed * [FIX] RoomInfoView * pt-BR * Few fixes * Create button name * Show create button only after a user is selected * Fix max users issues Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Add server and hide login (#1968) * Navigate to new server workspace from ServerDropdown if there's no token * Hide login button based on login services and Accounts_ShowFormLogin setting * [FIX] Lint Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> * [FIX] MultiSelect Keyboard behavior (Android) (#1969) * fixed-modal-position * made-changes Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> * [FIX] Bottom border style on DirectoryView (#1963) * [FIX] Border style * [FIX] Refactoring * [FIX] fix color of border * Undo Co-authored-by: Aroo <azhaubassar@gmail.com> Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Clear settings on server change (#1967) * [FIX] Deeplinking without RoomId (#1925) * [FIX] Deeplinking without rid * [FIX] Join channel * [FIX] Deep linking without rid * Update app/lib/methods/canOpenRoom.js Co-authored-by: Diego Mello <diegolmello@gmail.com> * [NEW] Two Factor authentication via email (#1961) * First api call working * [NEW] REST API Post wrapper 2FA * [NEW] Send 2FA on Email * [I18n] Add translations * [NEW] Translations & Cancel totp * [CHORE] Totp -> TwoFactor * [NEW] Two Factor by email * [NEW] Tablet Support * [FIX] Text colors * [NEW] Password 2fa * [FIX] Encrypt password on 2FA * [NEW] MethodCall2FA * [FIX] Password fallback * [FIX] Wrap all post/methodCall with 2fa * [FIX] Wrap missed function * few fixes * [FIX] Use new TOTP on Login * [improvement] 2fa methodCall Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> * [FIX] Correct message for manual approval user Registration (#1906) * [FIX] Correct message for manual approval from admin shown on Registeration * lint fix - added semicolon * Updated the translations * [FIX] Translations * i18n to match server Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Direct Message between multiple users REST (#1974) * [FIX] Investigate app losing connection issues (#1890) * [WIP] Reopen without timeOut & ping with 5 sec & Fix Unsubscribe * [FIX] Remove duplicated close * [FIX] Use no-dist lib * [FIX] Try minor fix * [FIX] Try reopen connection when app was put on foreground * [FIX] Remove timeout * [FIX] Build * [FIX] Patch * [FIX] Snapshot * [IMPROVEMENT] Decrease time to reopen * [FIX] Some fixes * [FIX] Update sdk version * [FIX] Subscribe Room Once * [CHORE] Update sdk * [FIX] Subscribe Room * [FIX] Try to resend missed subs * [FIX] Users never show status when start app without network * [FIX] Subscribe to room * [FIX] Multiple servers * [CHORE] Update SDK * [FIX] Don't duplicate streams on subscribeAll * [FIX] Server version when start the app offline * [FIX] Server version cached * [CHORE] Remove unnecessary code * [FIX] Offline server version * [FIX] Subscribe before connect * [FIX] Remove unncessary props * [FIX] Update sdk * [FIX] User status & Unsubscribe Typing * [FIX] Typing at incorrect room * [FIX] Multiple Servers * [CHORE] Update SDK * [REVERT] Undo some changes on SDK * [CHORE] Update sdk to prevent incorrect subscribes * [FIX] Prevent no reconnect * [FIX] Remove close on open * [FIX] Clear typing when disconnect/connect to SDK * [CHORE] Update SDK * [CHORE] Update SDK * Update SDK * fix merge develop Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Single message thread inserting thread without rid (#1999) * [FIX] ThreadMessagesView crashing on load (#1997) * [FIX] Saml (#1996) * [FIX] SAML incorrect close * [FIX] Pathname Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Change user own status (#1995) * [FIX] Change user own status * [IMPROVEMENT] Set activeUsers Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Loading all updated rooms after app resume (#1998) * [FIX] Loading all updated rooms after app resume * Fix room date on RoomItem Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Change notifications preferences (#2000) * [FIX] Change notifications preferences * [IMPROVEMENT] Picker View * [I18N] Translations * [FIX] Picker Selection * [FIX] List border * [FIX] Prevent crash * [FIX] Not-Pref tablet * [FIX] Use same style of LanguageView * [IMPROVEMENT] Send listItem title Co-authored-by: Diego Mello <diegolmello@gmail.com> * Bump version to 4.6.1 (#2001) * [FIX] DM header blink (#2011) * [FIX] Split get settings into two requests (#2017) * [FIX] Split get settings into two requests * [FIX] Clear settings only when change server * [IMPROVEMENT] Move the way to clear settings * [REVERT] Revert some changes * [FIX] Server Icon Co-authored-by: Diego Mello <diegolmello@gmail.com> * [REGRESSION] Invite Links (#2007) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Read only channel/broadcast (#1951) * [FIX] Read only channel/broadcast * [FIX] Roles missing * [FIX] Check roles to readOnly * [FIX] Can post * [FIX] Respect post-readonly permission * [FIX] Search a room readOnly Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Cas auth (#2024) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Login TOTP Compatibility to older servers (#2018) * [FIX] Login TOTP Compatibility to older servers * [FIX] Android crashes if use double negation Co-authored-by: Diego Mello <diegolmello@gmail.com> * Bump version to 4.6.4 (#2029) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Lint (#2030) * [FIX] UIKit with only one block (#2022) * [FIX] Message with only one block * [FIX] Update headers Co-authored-by: Diego Mello <diegolmello@gmail.com> * Bump version to 4.7.0 (#2035) * [FIX] Action Tint Color on Black theme (#2081) * [FIX] Prevent crash when thread is not found (#2080) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Prevent double click (#2079) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Show slash commands when disconnected (#2078) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Backhandler onboarding (#2077) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Respect UI_Allow_room_names_with_special_chars setting (#2076) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] RoomsList update sometimes isn't fired (#2071) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [IMPROVEMENT] Stop inserting last message as message object from rooms stream if room is focused (#2069) * [IMPROVEMENT] No insert last message if the room is focused * fix discussion/threads Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Hide system messages (#2067) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Pending update (#2066) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Prevent crash when room.uids was not inserted yet (#2055) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FEATURE] Save video (#2063) * added-feature-save-video * fix sha256 Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Send totp-code to meteor call (#2050) * fixed-issue * removed-variable-name-errors * reverted-last-commit Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] MessageBox mention shouldn't show group DMs (#2049) * fixed-issue * [FIX] Filter users only if it's not a group chat Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] AttachmentView (Android)(Tablet) (#2047) * [fix]Tablet attachment View and Room Navigation * fix weird navigation and margin bottom Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Allow special chars in Filename (#2020) * fixed-filename-issue * improve Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Recorded audio on Android doesn't play on iOS (#2073) * react-native-video -> expo-av * remove react-native-video * Add audio mode * update mocks * [FIX] Loading bigger than play/pause Co-authored-by: Diego Mello <diegolmello@gmail.com> * [IMPROVEMENT] Message Touchable (#2082) * [FIX] Avatar touchable * [IMPROVEMENT] onLongPress on all Message Touchables * [IMPROVEMENT] User & baseUrl on MessageContext * [FIX] Context Access * [FIX] BaseURL * Fix User Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] ReactionsModal (#2085) * [NEW] Delete Server (#1975) * [NEW] Delete server Co-authored-by: Bruno Dantas <oliveiradantas96@gmail.com> Co-authored-by: Calebe Rios <calebersmendes@gmail.com> * [FIX] Revert removed function Co-authored-by: Bruno Dantas <oliveiradantas96@gmail.com> Co-authored-by: Calebe Rios <calebersmendes@gmail.com> * pods * i18n * Revert "pods" This reverts commit 2854a1650538159aeeafe90fdb2118d12b76a82f. Co-authored-by: Bruno Dantas <oliveiradantas96@gmail.com> Co-authored-by: Calebe Rios <calebersmendes@gmail.com> Co-authored-by: Diego Mello <diegolmello@gmail.com> * [IMPROVEMENT] Change server while connecting/updating (#1981) * [IMPROVEMENT] Change server while connecting * [FIX] Not login/reconnect to previous server * [FIX] Abort all fetch while connecting * [FIX] Abort sdk fetch * [FIX] Patch-package * Add comments Co-authored-by: Diego Mello <diegolmello@gmail.com> * [IMPROVEMENT] Keep screen awake while recording/playing some audio (#2089) * [IMPROVEMENT] Keep screen awake while recording/playing some audio * [FIX] Add expo-keep-awake mock * [FIX] UIKit crashing when UIKitModal receive update event (#2088) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [IMPROVEMENT] Close announcement banner (#2064) * [NEW] Created new field in subscription table Signed-off-by: Ezequiel De Oliveira <ezequiel1de1oliveira@gmail.com> * [NEW] New field added to obeserver in room view Signed-off-by: Ezequiel De Oliveira <ezequiel1de1oliveira@gmail.com> * [NEW] Added icon and new design to banner Signed-off-by: Ezequiel De Oliveira <ezequiel1de1oliveira@gmail.com> * [NEW] Close banner function works Signed-off-by: Ezequiel De Oliveira <ezequiel1de1oliveira@gmail.com> * [IMPROVEMENT] closed banner status now update correctly Signed-off-by: Ezequiel De Oliveira <ezequiel1de1oliveira@gmail.com> * improve banner style Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> Co-authored-by: Diego Mello <diegolmello@gmail.com> * Update all dependencies (#2008) * Android RN 62 * First steps iOS * Second step iOS * iOS compiling * "New" build system * Finish iOS * Flipper * Update to RN 0.62.1 * expo libs * Hermes working * Fix lint * Fix android build * Patches * Dev patches * Patch WatermelonDB: https://github.com/Nozbe/WatermelonDB/pull/660 * Fix jitsi * Update several minors * Update dev minors and lint * react-native-keyboard-input * Few updates * device info * react-native-fast-image * Navigation bar color * react-native-picker-select * webview * reactotron-react-native * Watermelondb * RN 0.62.2 * Few updates * Fix selection * update gems * remove lib * finishing * tests * Use node 10 * Re-enable app bundle * iOS build * Update jitsi ios * [NEW] Passcode and biometric unlock (#2059) * Update expo libs * Configure expo-local-authentication * ScreenLockedView * Authenticate server change * Auth on app resume * localAuthentication util * Add servers.lastLocalAuthenticatedSession column * Save last session date on background * Use our own version of app state redux * Fix libs * Remove inactive * ScreenLockConfigView * Apply on saved data * Auto lock option label * Starting passcode * Basic passcode flow working * Change passcode * Check if biometry is enrolled * Use fork * Migration * Patch expo-local-authentication * Use async storage * Styling * Timer * Refactor * Lock orientation portrait when not on tablet * share extension * Deep linking * Share extension * Refactoring passcode * use state * Stash * Refactor * Change passcode * Animate dots on error * Matching passcodes * Shake * Remove lib * Delete button * Fade animation on modal * Refactoring * ItemInfo * I18n * I18n * Remove unnecessary prop * Save biometry column * Raise time to lock to 30 seconds * Vibrate on wrong confirmation passcode * Reset attempts and save last authentication on local passcode confirmation * Remove inline style * Save last auth * Fix header blink * Change function name * Fix android modal * Fix vibration permission * PasscodeEnter calls biometry * Passcode on the state * Biometry button on PasscodeEnter * Show whole passcode * Secure passcode * Save passcode with promise to prevent empty passcodes and immediately lock * Patch expo-local-authentication * I18n * Fix biometry being called every time * Blur screen on app inactive * Revert "Blur screen on app inactive" This reverts commit a4ce812934adcf6cf87eb1a92aec9283e2f26753. * Remove immediately because of how Activities work on Android * Pods * New layout * stash * Layout refactored * Fix icons * Force set passcode from server * Lint * Improve permission message * Forced passcode subtitle * Disable based on admin's choice * Require local authentication on login success * Refactor * Update tests * Update react-native-device-info to fix notch * Lint * Fix modal * Fix icons * Fix min auto lock time * Review * keep enabled on mobile * fix forced by admin when enable unlock with passcode * use DEFAULT_AUTO_LOCK when manual enable screenLock * fix check has passcode * request biometry on first password * reset auto time lock when disabled on server Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> * [FIX] Messages View (#2090) * [FIX] Messages View * [FIX] Opening PDF from Files View * [FIX] Audio * [FIX] SearchMessagesView Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Big names overflow (#2072) * [FIX] Big names overflow * [FIX] Message time Co-authored-by: devyaniChoubey <devyanichoubey16@gmail.com> * [FIX] Some alignments * fix user item overflow * some adjustments Co-authored-by: devyaniChoubey <devyanichoubey16@gmail.com> Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Avatar of message as an emoji (#2038) * fixed-issue * removed-hardcoded-emoji * Merge develop * replaced markdown with emoji componenent * made-changes * use avatar onPress Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> Co-authored-by: Diego Mello <diegolmello@gmail.com> * [NEW] Livechat (#2004) * [WIP][NEW] Livechat info/actions * [IMPROVEMENT] RoomActionsView * [NEW] Visitor Navigation * [NEW] Get Department REST * [FIX] Borders * [IMPROVEMENT] Refactor RoomInfo View * [FIX] Error while navigate from mention -> roomInfo * [NEW] Livechat Fields * [NEW] Close Livechat * [WIP] Forward livechat * [NEW] Return inquiry * [WIP] Comment when close livechat * [WIP] Improve roomInfo * [IMPROVEMENT] Forward room * [FIX] Department picker * [FIX] Picker without results * [FIX] Superfluous argument * [FIX] Check permissions on RoomActionsView * [FIX] Livechat permissions * [WIP] Show edit to livechat * [I18N] Add pt-br translations * [WIP] Livechat Info * [IMPROVEMENT] Livechat info * [WIP] Livechat Edit * [WIP] Livechat edit * [WIP] Livechat Edit * [WIP] Livechat edit scroll * [FIX] Edit customFields * [FIX] Clean livechat customField * [FIX] Visitor Navigation * [NEW] Next input logic LivechatEdit * [FIX] Add livechat data to subscription * [FIX] Revert change * [NEW] Livechat user Status * [WIP] Livechat tags * [NEW] Edit livechat tags * [FIX] Prevent some crashes * [FIX] Forward * [FIX] Return Livechat error * [FIX] Prevent livechat info crash * [IMPROVEMENT] Use input style on forward chat * OnboardingSeparator -> OrSeparator * [FIX] Go to next input * [NEW] Added some icons * [NEW] Livechat close * [NEW] Forward Room Action * [FIX] Livechat edit style * [FIX] Change status logic * [CHORE] Remove unnecessary logic * [CHORE] Remove unnecessary code * [CHORE] Remove unecessary case * [FIX] Superfluous argument * [IMPROVEMENT] Submit livechat edit * [CHORE] Remove textInput type * [FIX] Livechat edit * [FIX] Livechat Edit * [FIX] Use same effect * [IMPROVEMENT] Tags input * [FIX] Add empty tag * Fix minor issues * Fix typo * insert livechat room data to our room object * review * add method calls server version Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Delete Subs (#2091) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Android build (#2094) * [FIX] Blink header DM (#2093) * [FIX] Blink header DM * Remove query * [FIX] Push RoomInfoView * remove unnecessary try/catch * [FIX] RoomInfo > Message (Tablet) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Default biometry enabled (#2095) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [IMPROVEMENT] Enable navigating to a room from auth deep linking (#2115) * Wait for login success to navigate * Enable auth and room deep linking at the same time * [FIX] NewMessageView Press Item should open DM (#2116) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Roles throwing error (#2110) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Wait attach activity before changeNavigationBarColor (#2111) * [FIX] Wait attach activity before changeNavigationBarColor * Remove timeout and add try/catch Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] UIKit crash when some app send a list (#2117) * [FIX] StoryBook * [FIX] UIKit crash when some app send a list * [CHORE] Update snapshot * [CHORE] Remove token & id * [FIX] Change bar color while no activity attached (#2130) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Screen Lock options i18n (#2120) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [i18n] Added missing German translation strings (#2105) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Sometimes SDK is null when try to connect (#2131) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [FIX] Autocomplete position on Android (#2106) * [FIX] Autocomplete position on Android * [FIX] Set selection to 0 when needed Co-authored-by: Diego Mello <diegolmello@gmail.com> * Revert "[FIX] Autocomplete position on Android (#2106)" (#2136) This reverts commit e8c38d6f6f69ae396a4aae6e37336617da739a6d. * [FIX] Here and all mentions shouldn't refer to users (#2137) * [FIX] No send data to bugsnag if it's an aborted request (#2133) Co-authored-by: Diego Mello <diegolmello@gmail.com> * [TESTS] Update and separate E2E tests (#2126) * Tests passing until roomslist * create room * roominfo * change server * broadcast * profile * custom status * forgot password * working * room and onboarding * Tests separated * config.yml refactor * Revert "config.yml refactor" This reverts commit 0e984d3029e47612726bf199553f7abdf24843e5. * CI * lint * CI refactor * Onboarding tests * npx detox * Add all tests * Save brew cache * mac-env executor * detox-test command * Update readme * Remove folder * [FIX] Screen Lock Time respect local value (#2141) * [FIX] Screen Lock Time respect local value * [FIX] Enable biometry at the first passcode change Co-authored-by: phriedrich <info@phriedrich.de> Co-authored-by: Guilherme Siqueira <guilhersiqueira@gmail.com> Co-authored-by: Prateek Jain <44807945+Prateek93a@users.noreply.github.com> Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> Co-authored-by: Prateek Jain <prateek93a@gmail.com> Co-authored-by: devyaniChoubey <52153085+devyaniChoubey@users.noreply.github.com> Co-authored-by: Bernard Seow <ssbing99@gmail.com> Co-authored-by: Hiroki Ishiura <ishiura@ja2.so-net.ne.jp> Co-authored-by: Exordian <jakob.englisch@gmail.com> Co-authored-by: Daanchaam <daanhendriks97@gmail.com> Co-authored-by: Youssef Muhamad <emaildeyoussefmuhamad@gmail.com> Co-authored-by: Iván Álvarez <ialvarezpereira@gmail.com> Co-authored-by: Sarthak Pranesh <41206172+sarthakpranesh@users.noreply.github.com> Co-authored-by: Michele Pellegrini <pellettiero@users.noreply.github.com> Co-authored-by: Tanmoy Bhowmik <tanmoy.openroot@gmail.com> Co-authored-by: Hibikine Kage <14365761+hibikine@users.noreply.github.com> Co-authored-by: Ezequiel de Oliveira <ezequiel1de1oliveira@gmail.com> Co-authored-by: Neil Agarwal <neil@neilagarwal.me> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Govind Dixit <GOVINDDIXIT93@GMAIL.COM> Co-authored-by: Zhaubassarova Aruzhan <49000079+azhaubassar@users.noreply.github.com> Co-authored-by: Aroo <azhaubassar@gmail.com> Co-authored-by: Sarthak Pranesh <sarthak.pranesh2018@vitstudent.ac.in> Co-authored-by: Siddharth Padhi <padhisiddharth31@gmail.com> Co-authored-by: Bruno Dantas <oliveiradantas96@gmail.com> Co-authored-by: Calebe Rios <calebersmendes@gmail.com> Co-authored-by: devyaniChoubey <devyanichoubey16@gmail.com>
2020-05-25 20:54:27 +00:00
/*
* Copyright (c) Facebook, Inc. and its affiliates.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
/**
* Subprocess library, modeled after Python's subprocess module
* (http://docs.python.org/2/library/subprocess.html)
*
* This library defines one class (Subprocess) which represents a child
* process. Subprocess has two constructors: one that takes a vector<string>
* and executes the given executable without using the shell, and one
* that takes a string and executes the given command using the shell.
* Subprocess allows you to redirect the child's standard input, standard
* output, and standard error to/from child descriptors in the parent,
* or to create communication pipes between the child and the parent.
*
* The simplest example is a thread-safe [1] version of the system() library
* function:
* Subprocess(cmd).wait();
* which executes the command using the default shell and waits for it
* to complete, returning the exit status.
*
* A thread-safe [1] version of popen() (type="r", to read from the child):
* Subprocess proc(cmd, Subprocess::Options().pipeStdout());
* // read from proc.stdoutFd()
* proc.wait();
*
* A thread-safe [1] version of popen() (type="w", to write to the child):
* Subprocess proc(cmd, Subprocess::Options().pipeStdin());
* // write to proc.stdinFd()
* proc.wait();
*
* If you want to redirect both stdin and stdout to pipes, you can, but note
* that you're subject to a variety of deadlocks. You'll want to use
* nonblocking I/O, like the callback version of communicate().
*
* The string or IOBuf-based variants of communicate() are the simplest way
* to communicate with a child via its standard input, standard output, and
* standard error. They buffer everything in memory, so they are not great
* for large amounts of data (or long-running processes), but they are much
* simpler than the callback version.
*
* == A note on thread-safety ==
*
* [1] "thread-safe" refers ONLY to the fact that Subprocess is very careful
* to fork in a way that does not cause grief in multithreaded programs.
*
* Caveat: If your system does not have the atomic pipe2 system call, it is
* not safe to concurrently call Subprocess from different threads.
* Therefore, it is best to have a single thread be responsible for spawning
* subprocesses.
*
* A particular instances of Subprocess is emphatically **not** thread-safe.
* If you need to simultaneously communicate via the pipes, and interact
* with the Subprocess state, your best bet is to:
* - takeOwnershipOfPipes() to separate the pipe I/O from the subprocess.
* - Only interact with the Subprocess from one thread at a time.
*
* The current implementation of communicate() cannot be safely interrupted.
* To do so correctly, one would need to use EventFD, or open a dedicated
* pipe to be messaged from a different thread -- in particular, kill() will
* not do, since a descendant may keep the pipes open indefinitely.
*
* So, once you call communicate(), you must wait for it to return, and not
* touch the pipes from other threads. closeParentFd() is emphatically
* unsafe to call concurrently, and even sendSignal() is not a good idea.
* You can perhaps give the Subprocess's PID to a different thread before
* starting communicate(), and use that PID to send a signal without
* accessing the Subprocess object. In that case, you will need a mutex
* that ensures you don't wait() before you sent said signal. In a
* nutshell, don't do this.
*
* In fact, signals are inherently concurrency-unsafe on Unix: if you signal
* a PID, while another thread is in waitpid(), the signal may fire either
* before or after the process is reaped. This means that your signal can,
* in pathological circumstances, be delivered to the wrong process (ouch!).
* To avoid this, you should only use non-blocking waits (i.e. poll()), and
* make sure to serialize your signals (i.e. kill()) with the waits --
* either wait & signal from the same thread, or use a mutex.
*/
#pragma once
#include <signal.h>
#include <sys/types.h>
#include <sys/wait.h>
#include <chrono>
#include <exception>
#include <string>
#include <vector>
#include <boost/container/flat_map.hpp>
#include <boost/operators.hpp>
#include <folly/Exception.h>
#include <folly/File.h>
#include <folly/FileUtil.h>
#include <folly/Function.h>
#include <folly/MapUtil.h>
#include <folly/Optional.h>
#include <folly/Portability.h>
#include <folly/Range.h>
#include <folly/gen/String.h>
#include <folly/io/IOBufQueue.h>
#include <folly/portability/SysResource.h>
namespace folly {
/**
* Class to wrap a process return code.
*/
class Subprocess;
class ProcessReturnCode {
public:
enum State {
// Subprocess starts in the constructor, so this state designates only
// default-initialized or moved-out ProcessReturnCodes.
NOT_STARTED,
RUNNING,
EXITED,
KILLED,
};
static ProcessReturnCode makeNotStarted() {
return ProcessReturnCode(RV_NOT_STARTED);
}
static ProcessReturnCode makeRunning() {
return ProcessReturnCode(RV_RUNNING);
}
static ProcessReturnCode make(int status);
// Default-initialized for convenience. Subprocess::returnCode() will
// never produce this value.
ProcessReturnCode() : rawStatus_(RV_NOT_STARTED) {}
// Trivially copyable
ProcessReturnCode(const ProcessReturnCode& p) = default;
ProcessReturnCode& operator=(const ProcessReturnCode& p) = default;
// Non-default move: In order for Subprocess to be movable, the "moved
// out" state must not be "running", or ~Subprocess() will abort.
ProcessReturnCode(ProcessReturnCode&& p) noexcept;
ProcessReturnCode& operator=(ProcessReturnCode&& p) noexcept;
/**
* Process state. One of:
* NOT_STARTED: process hasn't been started successfully
* RUNNING: process is currently running
* EXITED: process exited (successfully or not)
* KILLED: process was killed by a signal.
*/
State state() const;
/**
* Helper wrappers around state().
*/
bool notStarted() const {
return state() == NOT_STARTED;
}
bool running() const {
return state() == RUNNING;
}
bool exited() const {
return state() == EXITED;
}
bool killed() const {
return state() == KILLED;
}
/**
* Exit status. Only valid if state() == EXITED; throws otherwise.
*/
int exitStatus() const;
/**
* Signal that caused the process's termination. Only valid if
* state() == KILLED; throws otherwise.
*/
int killSignal() const;
/**
* Was a core file generated? Only valid if state() == KILLED; throws
* otherwise.
*/
bool coreDumped() const;
/**
* String representation; one of
* "not started"
* "running"
* "exited with status <status>"
* "killed by signal <signal>"
* "killed by signal <signal> (core dumped)"
*/
std::string str() const;
/**
* Helper function to enforce a precondition based on this.
* Throws std::logic_error if in an unexpected state.
*/
void enforce(State expected) const;
private:
explicit ProcessReturnCode(int rv) : rawStatus_(rv) {}
static constexpr int RV_NOT_STARTED = -2;
static constexpr int RV_RUNNING = -1;
int rawStatus_;
};
/**
* Base exception thrown by the Subprocess methods.
*/
class FOLLY_EXPORT SubprocessError : public std::runtime_error {
public:
using std::runtime_error::runtime_error;
};
/**
* Exception thrown by *Checked methods of Subprocess.
*/
class FOLLY_EXPORT CalledProcessError : public SubprocessError {
public:
explicit CalledProcessError(ProcessReturnCode rc);
~CalledProcessError() throw() override = default;
ProcessReturnCode returnCode() const {
return returnCode_;
}
private:
ProcessReturnCode returnCode_;
};
/**
* Exception thrown if the subprocess cannot be started.
*/
class FOLLY_EXPORT SubprocessSpawnError : public SubprocessError {
public:
SubprocessSpawnError(const char* executable, int errCode, int errnoValue);
~SubprocessSpawnError() throw() override = default;
int errnoValue() const {
return errnoValue_;
}
private:
int errnoValue_;
};
/**
* Subprocess.
*/
class Subprocess {
public:
static const int CLOSE = -1;
static const int PIPE = -2;
static const int PIPE_IN = -3;
static const int PIPE_OUT = -4;
/**
* See Subprocess::Options::dangerousPostForkPreExecCallback() for usage.
* Every derived class should include the following warning:
*
* DANGER: This class runs after fork in a child processes. Be fast, the
* parent thread is waiting, but remember that other parent threads are
* running and may mutate your state. Avoid mutating any data belonging to
* the parent. Avoid interacting with non-POD data that originated in the
* parent. Avoid any libraries that may internally reference non-POD data.
* Especially beware parent mutexes -- for example, glog's LOG() uses one.
*/
struct DangerousPostForkPreExecCallback {
virtual ~DangerousPostForkPreExecCallback() {}
// This must return 0 on success, or an `errno` error code.
virtual int operator()() = 0;
};
/**
* Class representing various options: file descriptor behavior, and
* whether to use $PATH for searching for the executable,
*
* By default, we don't use $PATH, file descriptors are closed if
* the close-on-exec flag is set (fcntl FD_CLOEXEC) and inherited
* otherwise.
*/
class Options {
friend class Subprocess;
public:
Options() {} // E.g. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58328
/**
* Change action for file descriptor fd.
*
* "action" may be another file descriptor number (dup2()ed before the
* child execs), or one of CLOSE, PIPE_IN, and PIPE_OUT.
*
* CLOSE: close the file descriptor in the child
* PIPE_IN: open a pipe *from* the child
* PIPE_OUT: open a pipe *to* the child
*
* PIPE is a shortcut; same as PIPE_IN for stdin (fd 0), same as
* PIPE_OUT for stdout (fd 1) or stderr (fd 2), and an error for
* other file descriptors.
*/
Options& fd(int fd, int action);
/**
* Shortcut to change the action for standard input.
*/
Options& stdinFd(int action) {
return fd(STDIN_FILENO, action);
}
/**
* Shortcut to change the action for standard output.
*/
Options& stdoutFd(int action) {
return fd(STDOUT_FILENO, action);
}
/**
* Shortcut to change the action for standard error.
* Note that stderr(1) will redirect the standard error to the same
* file descriptor as standard output; the equivalent of bash's "2>&1"
*/
Options& stderrFd(int action) {
return fd(STDERR_FILENO, action);
}
Options& pipeStdin() {
return fd(STDIN_FILENO, PIPE_IN);
}
Options& pipeStdout() {
return fd(STDOUT_FILENO, PIPE_OUT);
}
Options& pipeStderr() {
return fd(STDERR_FILENO, PIPE_OUT);
}
/**
* Close all other fds (other than standard input, output, error,
* and file descriptors explicitly specified with fd()).
*
* This is potentially slow; it's generally a better idea to
* set the close-on-exec flag on all file descriptors that shouldn't
* be inherited by the child.
*
* Even with this option set, standard input, output, and error are
* not closed; use stdin(CLOSE), stdout(CLOSE), stderr(CLOSE) if you
* desire this.
*/
Options& closeOtherFds() {
closeOtherFds_ = true;
return *this;
}
/**
* Use the search path ($PATH) when searching for the executable.
*/
Options& usePath() {
usePath_ = true;
return *this;
}
/**
* Change the child's working directory, after the vfork.
*/
Options& chdir(const std::string& dir) {
childDir_ = dir;
return *this;
}
#if defined(__linux__)
/**
* Child will receive a signal when the parent *thread* exits.
*
* This is especially important when this option is used but the calling
* thread does not block for the duration of the subprocess. If the original
* thread that created the subprocess ends then the subprocess will
* terminate. For example, thread pool executors which can reap unused
* threads may trigger this behavior.
*/
Options& parentDeathSignal(int sig) {
parentDeathSignal_ = sig;
return *this;
}
#endif
/**
* Child will be made a process group leader when it starts. Upside: one
* can reliably kill all its non-daemonizing descendants. Downside: the
* child will not receive Ctrl-C etc during interactive use.
*/
Options& processGroupLeader() {
processGroupLeader_ = true;
return *this;
}
/**
* Detach the spawned process, to allow destroying the Subprocess object
* without waiting for the child process to finish.
*
* This causes the code to fork twice before executing the command.
* The intermediate child process will exit immediately, causing the process
* running the executable to be reparented to init (pid 1).
*
* Subprocess objects created with detach() enabled will already be in an
* "EXITED" state when the constructor returns. The caller should not call
* wait() or poll() on the Subprocess, and pid() will return -1.
*/
Options& detach() {
detach_ = true;
return *this;
}
/**
* *** READ THIS WHOLE DOCBLOCK BEFORE USING ***
*
* Run this callback in the child after the fork, just before the
* exec(), and after the child's state has been completely set up:
* - signal handlers have been reset to default handling and unblocked
* - the working directory was set
* - closed any file descriptors specified via Options()
* - set child process flags (see code)
*
* This is EXTREMELY DANGEROUS. For example, this innocuous-looking code
* can cause a fraction of your Subprocess launches to hang forever:
*
* LOG(INFO) << "Hello from the child";
*
* The reason is that glog has an internal mutex. If your fork() happens
* when the parent has the mutex locked, the child will wait forever.
*
* == GUIDELINES ==
*
* - Be quick -- the parent thread is blocked until you exit.
* - Remember that other parent threads are running, and may mutate your
* state.
* - Avoid mutating any data belonging to the parent.
* - Avoid interacting with non-POD data that came from the parent.
* - Avoid any libraries that may internally reference non-POD state.
* - Especially beware parent mutexes, e.g. LOG() uses a global mutex.
* - Avoid invoking the parent's destructors (you can accidentally
* delete files, terminate network connections, etc).
* - Read http://ewontfix.com/7/
*/
Options& dangerousPostForkPreExecCallback(
DangerousPostForkPreExecCallback* cob) {
dangerousPostForkPreExecCallback_ = cob;
return *this;
}
#if defined(__linux__)
/**
* This is an experimental feature, it is best you don't use it at this
* point of time.
* Although folly would support cloning with custom flags in some form, this
* API might change in the near future. So use the following assuming it is
* experimental. (Apr 11, 2017)
*
* This unlocks Subprocess to support clone flags, many of them need
* CAP_SYS_ADMIN permissions. It might also require you to go through the
* implementation to understand what happens before, between and after the
* fork-and-exec.
*
* `man 2 clone` would be a starting point for knowing about the available
* flags.
*/
using clone_flags_t = uint64_t;
Options& useCloneWithFlags(clone_flags_t cloneFlags) noexcept {
cloneFlags_ = cloneFlags;
return *this;
}
#endif
private:
typedef boost::container::flat_map<int, int> FdMap;
FdMap fdActions_;
bool closeOtherFds_{false};
bool usePath_{false};
bool processGroupLeader_{false};
bool detach_{false};
std::string childDir_; // "" keeps the parent's working directory
#if defined(__linux__)
int parentDeathSignal_{0};
#endif
DangerousPostForkPreExecCallback* dangerousPostForkPreExecCallback_{
nullptr};
#if defined(__linux__)
// none means `vfork()` instead of a custom `clone()`
// Optional<> is used because value of '0' means do clone without any flags.
Optional<clone_flags_t> cloneFlags_;
#endif
};
// Non-copiable, but movable
Subprocess(const Subprocess&) = delete;
Subprocess& operator=(const Subprocess&) = delete;
Subprocess(Subprocess&&) = default;
Subprocess& operator=(Subprocess&&) = default;
/**
* Create an uninitialized subprocess.
*
* In this state it can only be destroyed, or assigned to using the move
* assignment operator.
*/
Subprocess();
/**
* Create a subprocess from the given arguments. argv[0] must be listed.
* If not-null, executable must be the actual executable
* being used (otherwise it's the same as argv[0]).
*
* If env is not-null, it must contain name=value strings to be used
* as the child's environment; otherwise, we inherit the environment
* from the parent. env must be null if options.usePath is set.
*/
explicit Subprocess(
const std::vector<std::string>& argv,
const Options& options = Options(),
const char* executable = nullptr,
const std::vector<std::string>* env = nullptr);
~Subprocess();
/**
* Create a Subprocess object for an existing child process ID.
*
* The process ID must refer to an immediate child process of the current
* process. This allows using the poll() and wait() APIs on a process ID
* that was not originally spawned by Subprocess.
*/
static Subprocess fromExistingProcess(pid_t pid);
/**
* Create a subprocess run as a shell command (as shell -c 'command')
*
* The shell to use is taken from the environment variable $SHELL,
* or /bin/sh if $SHELL is unset.
*/
// clang-format off
[[deprecated(
"Prefer not running in a shell or use `shellify`.")]]
explicit Subprocess(
const std::string& cmd,
const Options& options = Options(),
const std::vector<std::string>* env = nullptr);
// clang-format on
////
//// The methods below only manipulate the process state, and do not
//// affect its communication pipes.
////
/**
* Return the child's pid, or -1 if the child wasn't successfully spawned
* or has already been wait()ed upon.
*/
pid_t pid() const;
/**
* Return the child's status (as per wait()) if the process has already
* been waited on, -1 if the process is still running, or -2 if the
* process hasn't been successfully started. NOTE that this does not call
* waitpid() or Subprocess::poll(), but simply returns the status stored
* in the Subprocess object.
*/
ProcessReturnCode returnCode() const {
return returnCode_;
}
/**
* Poll the child's status and return it. Return the exit status if the
* subprocess had quit, or RUNNING otherwise. Throws an std::logic_error
* if called on a Subprocess whose status is no longer RUNNING. No other
* exceptions are possible. Aborts on egregious violations of contract,
* e.g. if you wait for the underlying process without going through this
* Subprocess instance.
*/
ProcessReturnCode poll(struct rusage* ru = nullptr);
/**
* Poll the child's status. If the process is still running, return false.
* Otherwise, return true if the process exited with status 0 (success),
* or throw CalledProcessError if the process exited with a non-zero status.
*/
bool pollChecked();
/**
* Wait for the process to terminate and return its status. Like poll(),
* the only exception this can throw is std::logic_error if you call this
* on a Subprocess whose status is not RUNNING. Aborts on egregious
* violations of contract, like an out-of-band waitpid(p.pid(), 0, 0).
*/
ProcessReturnCode wait();
/**
* Wait for the process to terminate, throw if unsuccessful.
*/
void waitChecked();
using TimeoutDuration = std::chrono::milliseconds;
/**
* Call `waitpid` non-blockingly up to `timeout`. Throws std::logic_error if
* called on a Subprocess whose status is not RUNNING.
*
* The return code will be running() if waiting timed out.
*/
ProcessReturnCode waitTimeout(TimeoutDuration timeout);
/**
* Send a signal to the child. Shortcuts for the commonly used Unix
* signals are below.
*/
void sendSignal(int signal);
void terminate() {
sendSignal(SIGTERM);
}
void kill() {
sendSignal(SIGKILL);
}
/**
* Call `waitpid` non-blockingly up to `waitTimeout`. If the process hasn't
* terminated after that, fall back on `terminateOrKill` with
* `sigtermTimeoutSeconds`.
*/
ProcessReturnCode waitOrTerminateOrKill(
TimeoutDuration waitTimeout,
TimeoutDuration sigtermTimeout);
/**
* Send the SIGTERM to terminate the process, poll `waitpid` non-blockingly
* several times up to `sigtermTimeout`. If the process hasn't terminated
* after that, send SIGKILL to kill the process and call `waitpid` blockingly.
* Return the exit code of process.
*/
ProcessReturnCode terminateOrKill(TimeoutDuration sigtermTimeout);
////
//// The methods below only affect the process's communication pipes, but
//// not its return code or state (they do not poll() or wait()).
////
/**
* Communicate with the child until all pipes to/from the child are closed.
*
* The input buffer is written to the process' stdin pipe, and data is read
* from the stdout and stderr pipes. Non-blocking I/O is performed on all
* pipes simultaneously to avoid deadlocks.
*
* The stdin pipe will be closed after the full input buffer has been written.
* An error will be thrown if a non-empty input buffer is supplied but stdin
* was not configured as a pipe.
*
* Returns a pair of buffers containing the data read from stdout and stderr.
* If stdout or stderr is not a pipe, an empty IOBuf queue will be returned
* for the respective buffer.
*
* Note that communicate() and communicateIOBuf() both return when all
* pipes to/from the child are closed; the child might stay alive after
* that, so you must still wait().
*
* communicateIOBuf() uses IOBufQueue for buffering (which has the
* advantage that it won't try to allocate all data at once), but it does
* store the subprocess's entire output in memory before returning.
*
* communicate() uses strings for simplicity.
*/
std::pair<IOBufQueue, IOBufQueue> communicateIOBuf(
IOBufQueue input = IOBufQueue());
std::pair<std::string, std::string> communicate(
StringPiece input = StringPiece());
/**
* Communicate with the child until all pipes to/from the child are closed.
*
* == Semantics ==
*
* readCallback(pfd, cfd) will be called whenever there's data available
* on any pipe *from* the child (PIPE_OUT). pfd is the file descriptor
* in the parent (that you use to read from); cfd is the file descriptor
* in the child (used for identifying the stream; 1 = child's standard
* output, 2 = child's standard error, etc)
*
* writeCallback(pfd, cfd) will be called whenever a pipe *to* the child is
* writable (PIPE_IN). pfd is the file descriptor in the parent (that you
* use to write to); cfd is the file descriptor in the child (used for
* identifying the stream; 0 = child's standard input, etc)
*
* The read and write callbacks must read from / write to pfd and return
* false during normal operation. Return true to tell communicate() to
* close the pipe. For readCallback, this might send SIGPIPE to the
* child, or make its writes fail with EPIPE, so you should generally
* avoid returning true unless you've reached end-of-file.
*
* communicate() returns when all pipes to/from the child are closed; the
* child might stay alive after that, so you must still wait().
* Conversely, the child may quit long before its pipes are closed, since
* its descendants can keep them alive forever.
*
* Most users won't need to use this callback version; the simpler version
* of communicate (which buffers data in memory) will probably work fine.
*
* == Things you must get correct ==
*
* 1) You MUST consume all data passed to readCallback (or return true to
* close the pipe). Similarly, you MUST write to a writable pipe (or
* return true to close the pipe). To do otherwise is an error that can
* result in a deadlock. You must do this even for pipes you are not
* interested in.
*
* 2) pfd is nonblocking, so be prepared for read() / write() to return -1
* and set errno to EAGAIN (in which case you should return false). Use
* readNoInt() from FileUtil.h to handle interrupted reads for you.
*
* 3) Your callbacks MUST NOT call any of the Subprocess methods that
* manipulate the pipe FDs. Check the docblocks, but, for example,
* neither closeParentFd (return true instead) nor takeOwnershipOfPipes
* are safe. Stick to reading/writing from pfd, as appropriate.
*
* == Good to know ==
*
* 1) See ReadLinesCallback for an easy way to consume the child's output
* streams line-by-line (or tokenized by another delimiter).
*
* 2) "Wait until the descendants close the pipes" is usually the behavior
* you want, since the descendants may have something to say even if the
* immediate child is dead. If you need to be able to force-close all
* parent FDs, communicate() will NOT work for you. Do it your own way by
* using takeOwnershipOfPipes().
*
* Why not? You can return "true" from your callbacks to sever active
* pipes, but inactive ones can remain open indefinitely. It is
* impossible to safely close inactive pipes while another thread is
* blocked in communicate(). This is BY DESIGN. Racing communicate()'s
* read/write callbacks can result in wrong I/O and data corruption. This
* class would need internal synchronization and timeouts, a poor and
* expensive implementation choice, in order to make closeParentFd()
* thread-safe.
*/
using FdCallback = folly::Function<bool(int, int)>;
void communicate(FdCallback readCallback, FdCallback writeCallback);
/**
* A readCallback for Subprocess::communicate() that helps you consume
* lines (or other delimited pieces) from your subprocess's file
* descriptors. Use the readLinesCallback() helper to get template
* deduction. For example:
*
* subprocess.communicate(
* Subprocess::readLinesCallback(
* [](int fd, folly::StringPiece s) {
* std::cout << fd << " said: " << s;
* return false; // Keep reading from the child
* }
* ),
* [](int pdf, int cfd){ return true; } // Don't write to the child
* );
*
* If a file line exceeds maxLineLength, your callback will get some
* initial chunks of maxLineLength with no trailing delimiters. The final
* chunk of a line is delimiter-terminated iff the delimiter was present
* in the input. In particular, the last line in a file always lacks a
* delimiter -- so if a file ends on a delimiter, the final line is empty.
*
* Like a regular communicate() callback, your fdLineCb() normally returns
* false. It may return true to tell Subprocess to close the underlying
* file descriptor. The child process may then receive SIGPIPE or get
* EPIPE errors on writes.
*/
template <class Callback>
class ReadLinesCallback {
private:
// Binds an FD to the client-provided FD+line callback
struct StreamSplitterCallback {
StreamSplitterCallback(Callback& cb, int fd) : cb_(cb), fd_(fd) {}
// The return value semantics are inverted vs StreamSplitter
bool operator()(StringPiece s) {
return !cb_(fd_, s);
}
Callback& cb_;
int fd_;
};
typedef gen::StreamSplitter<StreamSplitterCallback> LineSplitter;
public:
explicit ReadLinesCallback(
Callback&& fdLineCb,
uint64_t maxLineLength = 0, // No line length limit by default
char delimiter = '\n',
uint64_t bufSize = 1024)
: fdLineCb_(std::forward<Callback>(fdLineCb)),
maxLineLength_(maxLineLength),
delimiter_(delimiter),
bufSize_(bufSize) {}
bool operator()(int pfd, int cfd) {
// Make a splitter for this cfd if it doesn't already exist
auto it = fdToSplitter_.find(cfd);
auto& splitter = (it != fdToSplitter_.end())
? it->second
: fdToSplitter_
.emplace(
cfd,
LineSplitter(
delimiter_,
StreamSplitterCallback(fdLineCb_, cfd),
maxLineLength_))
.first->second;
// Read as much as we can from this FD
char buf[bufSize_];
while (true) {
ssize_t ret = readNoInt(pfd, buf, bufSize_);
if (ret == -1 && errno == EAGAIN) { // No more data for now
return false;
}
checkUnixError(ret, "read");
if (ret == 0) { // Reached end-of-file
splitter.flush(); // Ignore return since the file is over anyway
return true;
}
if (!splitter(StringPiece(buf, ret))) {
return true; // The callback told us to stop
}
}
}
private:
Callback fdLineCb_;
const uint64_t maxLineLength_;
const char delimiter_;
const uint64_t bufSize_;
// We lazily make splitters for all cfds that get used.
std::unordered_map<int, LineSplitter> fdToSplitter_;
};
// Helper to enable template deduction
template <class Callback>
static auto readLinesCallback(
Callback&& fdLineCb,
uint64_t maxLineLength = 0, // No line length limit by default
char delimiter = '\n',
uint64_t bufSize = 1024)
-> ReadLinesCallback<typename std::decay<Callback>::type> {
return ReadLinesCallback<typename std::decay<Callback>::type>(
std::forward<Callback>(fdLineCb), maxLineLength, delimiter, bufSize);
}
/**
* communicate() callbacks can use this to temporarily enable/disable
* notifications (callbacks) for a pipe to/from the child. By default,
* all are enabled. Useful for "chatty" communication -- you want to
* disable write callbacks until you receive the expected message.
*
* Disabling a pipe does not free you from the requirement to consume all
* incoming data. Failing to do so will easily create deadlock bugs.
*
* Throws if the childFd is not known.
*/
void enableNotifications(int childFd, bool enabled);
/**
* Are notifications for one pipe to/from child enabled? Throws if the
* childFd is not known.
*/
bool notificationsEnabled(int childFd) const;
////
//// The following methods are meant for the cases when communicate() is
//// not suitable. You should not need them when you call communicate(),
//// and, in fact, it is INHERENTLY UNSAFE to use closeParentFd() or
//// takeOwnershipOfPipes() from a communicate() callback.
////
/**
* Close the parent file descriptor given a file descriptor in the child.
* DO NOT USE from communicate() callbacks; make them return true instead.
*/
void closeParentFd(int childFd);
/**
* Set all pipes from / to child to be non-blocking. communicate() does
* this for you.
*/
void setAllNonBlocking();
/**
* Get parent file descriptor corresponding to the given file descriptor
* in the child. Throws if childFd isn't a pipe (PIPE_IN / PIPE_OUT).
* Do not close() the returned file descriptor; use closeParentFd, above.
*/
int parentFd(int childFd) const {
return pipes_[findByChildFd(childFd)].pipe.fd();
}
int stdinFd() const {
return parentFd(0);
}
int stdoutFd() const {
return parentFd(1);
}
int stderrFd() const {
return parentFd(2);
}
/**
* The child's pipes are logically separate from the process metadata
* (they may even be kept alive by the child's descendants). This call
* lets you manage the pipes' lifetime separetely from the lifetime of the
* child process.
*
* After this call, the Subprocess instance will have no knowledge of
* these pipes, and the caller assumes responsibility for managing their
* lifetimes. Pro-tip: prefer to explicitly close() the pipes, since
* folly::File would otherwise silently suppress I/O errors.
*
* No, you may NOT call this from a communicate() callback.
*/
struct ChildPipe {
ChildPipe(int fd, folly::File&& ppe) : childFd(fd), pipe(std::move(ppe)) {}
int childFd;
folly::File pipe; // Owns the parent FD
};
std::vector<ChildPipe> takeOwnershipOfPipes();
private:
// spawn() sets up a pipe to read errors from the child,
// then calls spawnInternal() to do the bulk of the work. Once
// spawnInternal() returns it reads the error pipe to see if the child
// encountered any errors.
void spawn(
std::unique_ptr<const char*[]> argv,
const char* executable,
const Options& options,
const std::vector<std::string>* env);
void spawnInternal(
std::unique_ptr<const char*[]> argv,
const char* executable,
Options& options,
const std::vector<std::string>* env,
int errFd);
// Actions to run in child.
// Note that this runs after vfork(), so tread lightly.
// Returns 0 on success, or an errno value on failure.
int prepareChild(
const Options& options,
const sigset_t* sigmask,
const char* childDir) const;
int runChild(
const char* executable,
char** argv,
char** env,
const Options& options) const;
/**
* Read from the error pipe, and throw SubprocessSpawnError if the child
* failed before calling exec().
*/
void readChildErrorPipe(int pfd, const char* executable);
// Returns an index into pipes_. Throws std::invalid_argument if not found.
size_t findByChildFd(const int childFd) const;
pid_t pid_{-1};
ProcessReturnCode returnCode_;
/**
* Represents a pipe between this process, and the child process (or its
* descendant). To interact with these pipes, you can use communicate(),
* or use parentFd() and related methods, or separate them from the
* Subprocess instance entirely via takeOwnershipOfPipes().
*/
struct Pipe : private boost::totally_ordered<Pipe> {
folly::File pipe; // Our end of the pipe, wrapped in a File to auto-close.
int childFd = -1; // Identifies the pipe: what FD is this in the child?
int direction = PIPE_IN; // one of PIPE_IN / PIPE_OUT
bool enabled = true; // Are notifications enabled in communicate()?
bool operator<(const Pipe& other) const {
return childFd < other.childFd;
}
bool operator==(const Pipe& other) const {
return childFd == other.childFd;
}
};
// Populated at process start according to fdActions, empty after
// takeOwnershipOfPipes(). Sorted by childFd. Can only have elements
// erased, but not inserted, after being populated.
//
// The number of pipes between parent and child is assumed to be small,
// so we're happy with a vector here, even if it means linear erase.
std::vector<Pipe> pipes_;
};
} // namespace folly